From: Stephen Smith <stephen@curii.com>
Date: Wed, 5 Jun 2024 13:55:22 +0000 (-0400)
Subject: 21225: Connect click handlers accidentally disconnected from project data tables
X-Git-Url: https://git.arvados.org/arvados.git/commitdiff_plain/1ae39a6070af7bdb55babda5ac6ec632cb09dd13

21225: Connect click handlers accidentally disconnected from project data tables

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
---

diff --git a/services/workbench2/src/views/project-panel/project-panel-data.tsx b/services/workbench2/src/views/project-panel/project-panel-data.tsx
index 8526ebf083..a8bde2cd9c 100644
--- a/services/workbench2/src/views/project-panel/project-panel-data.tsx
+++ b/services/workbench2/src/views/project-panel/project-panel-data.tsx
@@ -152,19 +152,18 @@ const DEFAULT_VIEW_MESSAGES = ['No data found'];
 
 interface ProjectPanelDataProps {
     paperClassName?: string;
+    onRowClick: (uuid: string) => void;
+    onRowDoubleClick: (uuid: string) => void;
+    onContextMenu: (event: React.MouseEvent<HTMLElement>, resourceUuid: string) => void;
 };
 
 export const ProjectPanelData = class extends React.Component<ProjectPanelDataProps> {
-    handleRowClick = () => {};
-    handleRowDoubleClick = () => {};
-    handleContextMenu = () => {};
-
     render () {
         return <DataExplorer
             id={PROJECT_PANEL_DATA_ID}
-            onRowClick={this.handleRowClick}
-            onRowDoubleClick={this.handleRowDoubleClick}
-            onContextMenu={this.handleContextMenu}
+            onRowClick={this.props.onRowClick}
+            onRowDoubleClick={this.props.onRowDoubleClick}
+            onContextMenu={this.props.onContextMenu}
             contextMenuColumn={true}
             defaultViewIcon={ProjectIcon}
             defaultViewMessages={DEFAULT_VIEW_MESSAGES}
diff --git a/services/workbench2/src/views/project-panel/project-panel-run.tsx b/services/workbench2/src/views/project-panel/project-panel-run.tsx
index e89e761389..4413bfd492 100644
--- a/services/workbench2/src/views/project-panel/project-panel-run.tsx
+++ b/services/workbench2/src/views/project-panel/project-panel-run.tsx
@@ -175,9 +175,12 @@ const DEFAULT_VIEW_MESSAGES = ['No workflow runs found'];
 interface ProjectPanelRunProps {
     project?: ProjectResource;
     paperClassName?: string;
+    onRowClick: (uuid: string) => void;
+    onRowDoubleClick: (uuid: string) => void;
+    onContextMenu: (event: React.MouseEvent<HTMLElement>, resourceUuid: string) => void;
 }
 
-const mapStateToProps = (state: RootState): ProjectPanelRunProps => {
+const mapStateToProps = (state: RootState): Pick<ProjectPanelRunProps, 'project'> => {
     const projectUuid = getProjectPanelCurrentUuid(state) || "";
     const project = getResource<ProjectResource>(projectUuid)(state.resources);
     return {
@@ -186,15 +189,11 @@ const mapStateToProps = (state: RootState): ProjectPanelRunProps => {
 };
 
 export const ProjectPanelRun = connect(mapStateToProps)((props: ProjectPanelRunProps) => {
-    const handleRowClick = () => {};
-    const handleRowDoubleClick = () => {};
-    const handleContextMenu = () => {};
-
     return <DataExplorer
         id={PROJECT_PANEL_RUN_ID}
-        onRowClick={handleRowClick}
-        onRowDoubleClick={handleRowDoubleClick}
-        onContextMenu={handleContextMenu}
+        onRowClick={props.onRowClick}
+        onRowDoubleClick={props.onRowDoubleClick}
+        onContextMenu={props.onContextMenu}
         contextMenuColumn={true}
         defaultViewIcon={ProjectIcon}
         defaultViewMessages={DEFAULT_VIEW_MESSAGES}
diff --git a/services/workbench2/src/views/project-panel/project-panel.tsx b/services/workbench2/src/views/project-panel/project-panel.tsx
index f84d8e7090..7a447509c5 100644
--- a/services/workbench2/src/views/project-panel/project-panel.tsx
+++ b/services/workbench2/src/views/project-panel/project-panel.tsx
@@ -99,14 +99,22 @@ export const ProjectPanel = withStyles(styles)(
                             xs="auto"
                             data-cy="process-data"
                             className={classes.dataExplorer}>
-                            <ProjectPanelData />
+                            <ProjectPanelData
+                                onRowClick={this.handleRowClick}
+                                onRowDoubleClick={this.handleRowDoubleClick}
+                                onContextMenu={this.handleContextMenu}
+                            />
                         </MPVPanelContent>
                         <MPVPanelContent
                             forwardProps
                             xs="auto"
                             data-cy="process-run"
                             className={classes.dataExplorer}>
-                            <ProjectPanelRun />
+                            <ProjectPanelRun
+                                onRowClick={this.handleRowClick}
+                                onRowDoubleClick={this.handleRowDoubleClick}
+                                onContextMenu={this.handleContextMenu}
+                            />
                         </MPVPanelContent>
                     </MPVContainer>
                 </div>