From: Ward Vandewege <ward@curii.com>
Date: Fri, 15 Apr 2022 17:28:09 +0000 (-0400)
Subject: 18995: add scope to all <th> tags that are missing one.
X-Git-Tag: 2.5.0~203^2
X-Git-Url: https://git.arvados.org/arvados.git/commitdiff_plain/0ceaaf049f7042e54ccdafaded9fa4f7de4bdb8b

18995: add scope to all <th> tags that are missing one.

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>
---

diff --git a/apps/workbench/app/views/projects/_compute_node_summary.html.erb b/apps/workbench/app/views/projects/_compute_node_summary.html.erb
index 40a212e5b6..474fc7b9f5 100644
--- a/apps/workbench/app/views/projects/_compute_node_summary.html.erb
+++ b/apps/workbench/app/views/projects/_compute_node_summary.html.erb
@@ -13,8 +13,8 @@ SPDX-License-Identifier: AGPL-3.0 %>
         <td><%= nodes.select {|n| n.crunch_worker_state == "idle" }.size %></td>
       </tr>
       <tr>
-        <th>Busy nodes</th>
-        <th>Idle nodes</th>
+        <th scope="col">Busy nodes</th>
+        <th scope="col">Idle nodes</th>
       </tr>
     </table>
 </div>
diff --git a/apps/workbench/app/views/projects/_container_summary.html.erb b/apps/workbench/app/views/projects/_container_summary.html.erb
index 2df4d81c0f..c40ee370bd 100644
--- a/apps/workbench/app/views/projects/_container_summary.html.erb
+++ b/apps/workbench/app/views/projects/_container_summary.html.erb
@@ -9,8 +9,8 @@ SPDX-License-Identifier: AGPL-3.0 %>
         <col width="50%">
       </colgroup>
       <tr>
-        <th>Pending containers</th>
-	<th>Running containers</th>
+        <th scope="col">Pending containers</th>
+        <th scope="col">Running containers</th>
       </tr>
       <tr>
 	<% pending_containers = Container.order("created_at asc").filter([["state", "in", ["Queued", "Locked"]], ["priority", ">", 0]]).limit(1) %>
@@ -19,8 +19,8 @@ SPDX-License-Identifier: AGPL-3.0 %>
         <td><%= running_containers.items_available %></td>
       </tr>
       <tr>
-	<th>Oldest pending</th>
-	<th>Longest running</th>
+        <th scope="col">Oldest pending</th>
+        <th scope="col">Longest running</th>
       </tr>
       <tr>
         <td><% if pending_containers.first then %>
diff --git a/apps/workbench/app/views/users/activity.html.erb b/apps/workbench/app/views/users/activity.html.erb
index 9df4b1fce3..64be1ea4a7 100644
--- a/apps/workbench/app/views/users/activity.html.erb
+++ b/apps/workbench/app/views/users/activity.html.erb
@@ -24,9 +24,9 @@ table#users-activity-table .cell-for-span-Last-month {
   <% end %>
 
   <tr>
-    <th rowspan="2">User</th>
+    <th scope="col" rowspan="2">User</th>
     <% @spans.each do |span, start_at, end_at| %>
-    <th colspan="3" class="cell-for-span-<%= span.gsub ' ','-' %>">
+    <th scope="col" colspan="3" class="cell-for-span-<%= span.gsub ' ','-' %>">
       <%= span %>
       <br />
       <%= start_at.strftime('%b %-d') %>
@@ -37,9 +37,9 @@ table#users-activity-table .cell-for-span-Last-month {
   </tr>
   <tr>
     <% @spans.each do |span, _| %>
-    <th class="cell-for-span-<%= span.gsub ' ','-' %>">Logins</th>
-    <th class="cell-for-span-<%= span.gsub ' ','-' %>">Jobs</th>
-    <th class="cell-for-span-<%= span.gsub ' ','-' %>">Pipelines</th>
+    <th scope="col" class="cell-for-span-<%= span.gsub ' ','-' %>">Logins</th>
+    <th scope="col" class="cell-for-span-<%= span.gsub ' ','-' %>">Jobs</th>
+    <th scope="col" class="cell-for-span-<%= span.gsub ' ','-' %>">Pipelines</th>
     <% end %>
   </tr>
 
diff --git a/apps/workbench/app/views/users/storage.html.erb b/apps/workbench/app/views/users/storage.html.erb
index 151ea8bb93..2a5265c408 100644
--- a/apps/workbench/app/views/users/storage.html.erb
+++ b/apps/workbench/app/views/users/storage.html.erb
@@ -17,21 +17,21 @@ table#users-storage-table .byte-value {
   </colgroup>
 
   <tr>
-    <th rowspan="2">User</th>
-    <th colspan="2">
+    <th scope="col" rowspan="2">User</th>
+    <th scope="col" colspan="2">
       Collections Read Size
     </th>
-    <th colspan="2">
+    <th scope="col" colspan="2">
       Collections Persisted Storage
     </th>
-    <th rowspan="2">Measured At</th>
+    <th scope="col" rowspan="2">Measured At</th>
   </tr>
   <tr>
     <% 2.times do %>
-    <th class="byte-value">
+    <th scope="col" class="byte-value">
       Total (unweighted)
     </th>
-    <th class="byte-value">
+    <th scope="col" class="byte-value">
       Shared (weighted)
     </th>
     <% end %>