From: Tom Clegg <tom@curii.com>
Date: Fri, 4 Nov 2022 01:33:02 +0000 (-0400)
Subject: 19240: Fix url comparison.
X-Git-Tag: 2.5.0~44^2~5
X-Git-Url: https://git.arvados.org/arvados.git/commitdiff_plain/00087e9458f9ede8d4c2bb9621d782b8c2fadf29

19240: Fix url comparison.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>
---

diff --git a/services/api/app/models/api_client.rb b/services/api/app/models/api_client.rb
index c914051a34..55a4c6706c 100644
--- a/services/api/app/models/api_client.rb
+++ b/services/api/app/models/api_client.rb
@@ -43,11 +43,10 @@ class ApiClient < ArvadosModel
   def norm url
     # normalize URL for comparison
     url = URI(url.to_s)
-    if url.scheme == "https"
-      url.port == "443"
-    end
-    if url.scheme == "http"
-      url.port == "80"
+    if url.scheme == "https" && url.port == ""
+      url.port = "443"
+    elsif url.scheme == "http" && url.port == ""
+      url.port = "80"
     end
     url.path = "/"
     url