10231: validate_runtime_constraints should occur before set_container filter.
authorradhika <radhika@curoverse.com>
Wed, 2 Nov 2016 22:50:46 +0000 (18:50 -0400)
committerradhika <radhika@curoverse.com>
Wed, 2 Nov 2016 22:50:46 +0000 (18:50 -0400)
services/api/app/models/container_request.rb
services/api/test/unit/container_request_test.rb

index d0b3076028bf33ae16c16c5b403e85bf70898246..05738de81e50627654e62e3f3a34d6cc46754460 100644 (file)
@@ -13,11 +13,11 @@ class ContainerRequest < ArvadosModel
   serialize :command, Array
 
   before_validation :fill_field_defaults, :if => :new_record?
+  before_validation :validate_runtime_constraints
   before_validation :set_container
   validates :command, :container_image, :output_path, :cwd, :presence => true
   validate :validate_state_change
   validate :validate_change
-  validate :validate_runtime_constraints
   after_save :update_priority
   after_save :finalize_if_needed
   before_create :set_requesting_container_uuid
index b2b0d57df56f9fec8a899e4c2eb6edb53027cc24..34aa442c0938381e5fb56ebb2c6379616ad93976 100644 (file)
@@ -129,7 +129,7 @@ class ContainerRequestTest < ActiveSupport::TestCase
     assert_equal({}, c.environment)
     assert_equal({"/out" => {"kind"=>"tmp", "capacity"=>1000000}}, c.mounts)
     assert_equal "/out", c.output_path
-    assert_equal({"vcpus" => 2, "ram" => 30}, c.runtime_constraints)
+    assert_equal({"keep_cache_ram"=>268435456, "vcpus" => 2, "ram" => 30}, c.runtime_constraints)
     assert_equal 1, c.priority
 
     assert_raises(ActiveRecord::RecordInvalid) do