projects / arvados.git / commit
summary | shortlog | log | commit | commitdiff | tree
(parent: 9f34059) | patch
3411: code review
authorTim Pierce <twp@curoverse.com>
Tue, 16 Sep 2014 20:49:37 +0000 (16:49 -0400)
committerTim Pierce <twp@curoverse.com>
Tue, 16 Sep 2014 20:49:37 +0000 (16:49 -0400)
commit9d1876405f50e009b686bce51c2469a52d2f79ca
tree45cc426a1c02f41d2ad78c2a2a3db85b1cf6bb4ftree | snapshot
parent9f34059300412b551a21bb8ef8bae1ffa28cf9dccommit | diff
3411: code review

Feedback from code review:

* Dropped unnecessary lambda from Collection.default_scope.
* Set owner_uuid of new collection test fixtures to user 'active',
  removed unnecessary permission link test fixtures.
* Removed permit_unsigned_manifests from unit tests
* Added tests for :show and :update to expired and unexpired
  collections.
* Added rake config:check test to make sure default_trash_lifetime is at
  least 24 hours.
services/api/app/models/collection.rb diff | blob | history
services/api/db/structure.sql diff | blob | history
services/api/lib/tasks/config_check.rake diff | blob | history
services/api/test/fixtures/collections.yml diff | blob | history
services/api/test/fixtures/links.yml diff | blob | history
services/api/test/functional/arvados/v1/collections_controller_test.rb diff | blob | history