15803: Disallow setting is_active=false direct, use unsetup
authorPeter Amstutz <pamstutz@veritasgenetics.com>
Wed, 6 Nov 2019 21:16:41 +0000 (16:16 -0500)
committerPeter Amstutz <pamstutz@veritasgenetics.com>
Wed, 6 Nov 2019 21:16:41 +0000 (16:16 -0500)
commit92355462ad87335668ac9156e193fa4e7a82cec5
tree27f7c3f57d39a720615a66be31ffeba33535a483
parent1a5dfb2e9f8f2398cb1f11636258746705f3f77c
15803: Disallow setting is_active=false direct, use unsetup

Specifically, when setting is_active false it checks that the user has
been already removed from the 'All users' group, which means
'is_invited' won't be true (provided NewUsersAreActive is also false.)
This prevents the user from reactivating themself.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>
services/api/app/models/api_client_authorization.rb
services/api/app/models/user.rb
services/api/test/functional/arvados/v1/repositories_controller_test.rb
services/api/test/integration/remote_user_test.rb
services/api/test/integration/user_sessions_test.rb
services/api/test/integration/users_test.rb