20750/20927: Add TODO about network error handling
authorBrett Smith <brett.smith@curii.com>
Tue, 5 Sep 2023 20:46:54 +0000 (16:46 -0400)
committerBrett Smith <brett.smith@curii.com>
Tue, 5 Sep 2023 20:46:54 +0000 (16:46 -0400)
commit73931b1077dbf1f6cb195dfc427b1a7a6fe89a33
tree2f1abbcb770b75683b5ad2ef7082fc1f5ad140d4
parent8d6c085a1a7f0a7895245949a250d11d15117cf9
20750/20927: Add TODO about network error handling

The commit message for 9717f88d29310067fa70e19fb9afb3679c036bc4 says:

> This may also provide better behavior in cases of network hiccups or
> other remote server turbulence.

This was written with the expectation that those problems would raise
`HTTPClient::BadResponseError`. That was mistaken. Those problems
actually raise lower-level socket exceptions instead.

We now have a ticket to improve the error handling here. It's out of
scope for #20750, since the error handling is no worse than it was
before the branch.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith@curii.com>
services/api/app/models/api_client_authorization.rb