3857: code review feedback
authorTim Pierce <twp@curoverse.com>
Tue, 11 Nov 2014 16:04:19 +0000 (11:04 -0500)
committerTim Pierce <twp@curoverse.com>
Tue, 11 Nov 2014 20:18:36 +0000 (15:18 -0500)
commit69594694568da1abc2bd8e46134da81ec1f2a7c8
treebc932a6cecd199b14da3d23c1b6823c22d01df30
parent1fa1006e5b21cfc30e694890db969c20864af8c6
3857: code review feedback

* Set default timeouts to (20, 300) for proxies and (2, 300) for all
  else.
* KeepService:
** Removed unused 'timeout' argument to __init__()
** Trimmed unnecessary exceptions in last_status()
* Tests:
** test_collections.py: changed mock_api_call return value back to
   fake_httplib2_response
** Flattened test layers to eliminate KeepClientRetryGetTestMixin and
   KeepClientRetryPutTestMixin
** Moved proxy timeout tests to
   KeepClientServiceTestCase.test_proxy_get_request and
   .test_proxy_put_request
* Removed excess blank lines in docstrings
sdk/python/arvados/keep.py
sdk/python/tests/test_collections.py
sdk/python/tests/test_keep_client.py