4875: Let the OS choose port numbers for fake servers.
authorTom Clegg <tom@curoverse.com>
Sun, 21 Dec 2014 00:28:56 +0000 (19:28 -0500)
committerTom Clegg <tom@curoverse.com>
Sun, 21 Dec 2014 00:28:56 +0000 (19:28 -0500)
commit14421881c1962fdfba49dc004cfc69c0637fe454
tree013dc6effe47988af3c5f70e307188dd0c9de487
parentb12343e7eec124b34139efae07b52e95a74b253a
4875: Let the OS choose port numbers for fake servers.

Fixes a race condition where test case N+1 can't listen on port 2990
because test case N hasn't shut down its listener.

Also removes the artificial acceptance requirement that nobody else on
the testing host is using the arbitrarily assigned port range
2990..299x.

Incidental changes:

* rename RunBogusKeepServer to RunFakeKeepServer (to match
  RunSomeFakeKeepServers and fix the misleading implication that the
  resulting server does something bogus).

* return a KeepServer object from RunFakeKeepServer (for better parity
  with RunSomeFakeKeepServers).
sdk/go/keepclient/keepclient_test.go