X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/ff2e2d7b53edfec33a77ad1ff2b5a83f02a5be80..1a4282c6d30b209a882c255e0d5777851ff6f034:/services/api/test/functional/arvados/v1/groups_controller_test.rb diff --git a/services/api/test/functional/arvados/v1/groups_controller_test.rb b/services/api/test/functional/arvados/v1/groups_controller_test.rb index 6fa1d16770..c974076c6f 100644 --- a/services/api/test/functional/arvados/v1/groups_controller_test.rb +++ b/services/api/test/functional/arvados/v1/groups_controller_test.rb @@ -31,11 +31,11 @@ class Arvados::V1::GroupsControllerTest < ActionController::TestCase test "get list of groups that are not projects" do authorize_with :active - get :index, filters: [['group_class', '=', nil]], format: :json + get :index, filters: [['group_class', '!=', 'project']], format: :json assert_response :success group_uuids = [] json_response['items'].each do |group| - assert_equal nil, group['group_class'] + assert_not_equal 'project', group['group_class'] group_uuids << group['uuid'] end assert_not_includes group_uuids, groups(:aproject).uuid @@ -131,6 +131,47 @@ class Arvados::V1::GroupsControllerTest < ActionController::TestCase assert_includes ids, collections(:baz_file_in_asubproject).uuid end + [['asc', :<=], + ['desc', :>=]].each do |order, operator| + test "user with project read permission can sort project collections #{order}" do + authorize_with :project_viewer + get :contents, { + id: groups(:asubproject).uuid, + format: :json, + filters: [['uuid', 'is_a', "arvados#collection"]], + order: "collections.name #{order}" + } + sorted_names = json_response['items'].collect { |item| item["name"] } + # Here we avoid assuming too much about the database + # collation. Both "alice"<"Bob" and "alice">"Bob" can be + # correct. Hopefully it _is_ safe to assume that if "a" comes + # before "b" in the ascii alphabet, "aX">"bY" is never true for + # any strings X and Y. + reliably_sortable_names = sorted_names.select do |name| + name[0] >= 'a' and name[0] <= 'z' + end.uniq do |name| + name[0] + end + # Preserve order of sorted_names. But do not use &=. If + # sorted_names has out-of-order duplicates, we want to preserve + # them here, so we can detect them and fail the test below. + sorted_names.select! do |name| + reliably_sortable_names.include? name + end + actually_checked_anything = false + previous = nil + sorted_names.each do |entry| + if previous + assert_operator(previous, operator, entry, + "Entries sorted incorrectly.") + actually_checked_anything = true + end + previous = entry + end + assert actually_checked_anything, "Didn't even find two names to compare." + end + end + test 'list objects across multiple projects' do authorize_with :project_viewer get :contents, { @@ -239,44 +280,6 @@ class Arvados::V1::GroupsControllerTest < ActionController::TestCase assert_equal 0, json_response['items_available'] end - test "get all pages of group-owned objects" do - authorize_with :active - limit = 5 - offset = 0 - items_available = nil - uuid_received = {} - owner_received = {} - while true - # Behaving badly here, using the same controller multiple - # times within a test. - @json_response = nil - get :contents, { - id: groups(:aproject).uuid, - limit: limit, - offset: offset, - format: :json, - } - assert_response :success - assert_operator(0, :<, json_response['items'].count, - "items_available=#{items_available} but received 0 "\ - "items with offset=#{offset}") - items_available ||= json_response['items_available'] - assert_equal(items_available, json_response['items_available'], - "items_available changed between page #{offset/limit} "\ - "and page #{1+offset/limit}") - json_response['items'].each do |item| - uuid = item['uuid'] - assert_equal(nil, uuid_received[uuid], - "Received '#{uuid}' again on page #{1+offset/limit}") - uuid_received[uuid] = true - owner_received[item['owner_uuid']] = true - offset += 1 - assert_equal groups(:aproject).uuid, item['owner_uuid'] - end - break if offset >= items_available - end - end - %w(offset limit).each do |arg| ['foo', '', '1234five', '0x10', '-8'].each do |val| test "Raise error on bogus #{arg} parameter #{val.inspect}" do @@ -311,8 +314,9 @@ class Arvados::V1::GroupsControllerTest < ActionController::TestCase format: :json } assert_response :success - assert_nil(json_response['writable_by'], - "Should not receive uuid list in 'writable_by' field") + assert_equal([json_response['owner_uuid']], + json_response['writable_by'], + "Should only see owner_uuid in 'writable_by' field") end test 'get writable_by list by admin user' do @@ -328,4 +332,40 @@ class Arvados::V1::GroupsControllerTest < ActionController::TestCase users(:admin).uuid, "Current user should be included in 'writable_by' field") end + + test 'creating subproject with duplicate name fails' do + authorize_with :active + post :create, { + group: { + name: 'A Project', + owner_uuid: users(:active).uuid, + group_class: 'project', + }, + } + assert_response 422 + response_errors = json_response['errors'] + assert_not_nil response_errors, 'Expected error in response' + assert(response_errors.first.include?('duplicate key'), + "Expected 'duplicate key' error in #{response_errors.first}") + end + + test 'creating duplicate named subproject succeeds with ensure_unique_name' do + authorize_with :active + post :create, { + group: { + name: 'A Project', + owner_uuid: users(:active).uuid, + group_class: 'project', + }, + ensure_unique_name: true + } + assert_response :success + new_project = json_response + assert_not_equal(new_project['uuid'], + groups(:aproject).uuid, + "create returned same uuid as existing project") + assert_equal(new_project['name'], + 'A Project (2)', + "new project name '#{new_project['name']}' was expected to be 'A Project (2)'") + end end