X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/fe561d69b42d55191d6d1f01d4f3cdcf1fc9faaa..d63eaa465e157dd289a80738c5da83edaf03e784:/sdk/go/httpserver/logger_test.go

diff --git a/sdk/go/httpserver/logger_test.go b/sdk/go/httpserver/logger_test.go
index bdde3303e2..af45a640ca 100644
--- a/sdk/go/httpserver/logger_test.go
+++ b/sdk/go/httpserver/logger_test.go
@@ -1,18 +1,21 @@
 // Copyright (C) The Arvados Authors. All rights reserved.
 //
-// SPDX-License-Identifier: AGPL-3.0
+// SPDX-License-Identifier: Apache-2.0
 
 package httpserver
 
 import (
 	"bytes"
+	"context"
 	"encoding/json"
+	"fmt"
 	"net/http"
 	"net/http/httptest"
 	"testing"
 	"time"
 
-	"github.com/Sirupsen/logrus"
+	"git.arvados.org/arvados.git/sdk/go/ctxlog"
+	"github.com/sirupsen/logrus"
 	check "gopkg.in/check.v1"
 )
 
@@ -22,29 +25,40 @@ func Test(t *testing.T) {
 
 var _ = check.Suite(&Suite{})
 
-type Suite struct{}
+type Suite struct {
+	ctx     context.Context
+	log     *logrus.Logger
+	logdata *bytes.Buffer
+}
 
-func (s *Suite) TestLogRequests(c *check.C) {
-	captured := &bytes.Buffer{}
-	log := logrus.New()
-	log.Out = captured
-	log.Formatter = &logrus.JSONFormatter{
+func (s *Suite) SetUpTest(c *check.C) {
+	s.logdata = bytes.NewBuffer(nil)
+	s.log = logrus.New()
+	s.log.Out = s.logdata
+	s.log.Formatter = &logrus.JSONFormatter{
 		TimestampFormat: time.RFC3339Nano,
 	}
+	s.ctx = ctxlog.Context(context.Background(), s.log)
+}
+
+func (s *Suite) TestLogRequests(c *check.C) {
+	h := AddRequestIDs(LogRequests(
+		http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) {
+			w.Write([]byte("hello world"))
+		})))
 
-	h := http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) {
-		w.Write([]byte("hello world"))
-	})
 	req, err := http.NewRequest("GET", "https://foo.example/bar", nil)
 	req.Header.Set("X-Forwarded-For", "1.2.3.4:12345")
 	c.Assert(err, check.IsNil)
 	resp := httptest.NewRecorder()
-	AddRequestIDs(LogRequests(log, h)).ServeHTTP(resp, req)
 
-	dec := json.NewDecoder(captured)
+	HandlerWithContext(s.ctx, h).ServeHTTP(resp, req)
+
+	dec := json.NewDecoder(s.logdata)
 
 	gotReq := make(map[string]interface{})
 	err = dec.Decode(&gotReq)
+	c.Check(err, check.IsNil)
 	c.Logf("%#v", gotReq)
 	c.Check(gotReq["RequestID"], check.Matches, "req-[a-z0-9]{20}")
 	c.Check(gotReq["reqForwardedFor"], check.Equals, "1.2.3.4:12345")
@@ -52,6 +66,7 @@ func (s *Suite) TestLogRequests(c *check.C) {
 
 	gotResp := make(map[string]interface{})
 	err = dec.Decode(&gotResp)
+	c.Check(err, check.IsNil)
 	c.Logf("%#v", gotResp)
 	c.Check(gotResp["RequestID"], check.Equals, gotReq["RequestID"])
 	c.Check(gotResp["reqForwardedFor"], check.Equals, "1.2.3.4:12345")
@@ -66,3 +81,48 @@ func (s *Suite) TestLogRequests(c *check.C) {
 		c.Check(gotResp[key].(float64), check.Not(check.Equals), float64(0))
 	}
 }
+
+func (s *Suite) TestLogErrorBody(c *check.C) {
+	dec := json.NewDecoder(s.logdata)
+
+	for _, trial := range []struct {
+		label      string
+		statusCode int
+		sentBody   string
+		expectLog  bool
+		expectBody string
+	}{
+		{"ok", 200, "hello world", false, ""},
+		{"redir", 302, "<a href='http://foo.example/baz'>redir</a>", false, ""},
+		{"4xx short body", 400, "oops", true, "oops"},
+		{"4xx long body", 400, fmt.Sprintf("%0*d", sniffBytes*2, 1), true, fmt.Sprintf("%0*d", sniffBytes, 0)},
+		{"5xx empty body", 500, "", true, ""},
+	} {
+		comment := check.Commentf("in trial: %q", trial.label)
+
+		req, err := http.NewRequest("GET", "https://foo.example/bar", nil)
+		c.Assert(err, check.IsNil)
+		resp := httptest.NewRecorder()
+
+		HandlerWithContext(s.ctx, LogRequests(
+			http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) {
+				w.WriteHeader(trial.statusCode)
+				w.Write([]byte(trial.sentBody))
+			}),
+		)).ServeHTTP(resp, req)
+
+		gotReq := make(map[string]interface{})
+		err = dec.Decode(&gotReq)
+		c.Check(err, check.IsNil)
+		c.Logf("%#v", gotReq)
+		gotResp := make(map[string]interface{})
+		err = dec.Decode(&gotResp)
+		c.Check(err, check.IsNil)
+		c.Logf("%#v", gotResp)
+		if trial.expectLog {
+			c.Check(gotResp["respBody"], check.Equals, trial.expectBody, comment)
+		} else {
+			c.Check(gotResp["respBody"], check.IsNil, comment)
+		}
+	}
+}