X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/fe561d69b42d55191d6d1f01d4f3cdcf1fc9faaa..437d0dc1dfeea7b81999caa1c540da0903df87f7:/services/api/app/controllers/arvados/v1/containers_controller.rb diff --git a/services/api/app/controllers/arvados/v1/containers_controller.rb b/services/api/app/controllers/arvados/v1/containers_controller.rb index 25cb0037a2..041f559472 100644 --- a/services/api/app/controllers/arvados/v1/containers_controller.rb +++ b/services/api/app/controllers/arvados/v1/containers_controller.rb @@ -6,23 +6,30 @@ class Arvados::V1::ContainersController < ApplicationController accept_attribute_as_json :environment, Hash accept_attribute_as_json :mounts, Hash accept_attribute_as_json :runtime_constraints, Hash + accept_attribute_as_json :runtime_status, Hash accept_attribute_as_json :command, Array accept_attribute_as_json :scheduling_parameters, Hash - skip_before_filter :find_object_by_uuid, only: [:current] - skip_before_filter :render_404_if_no_object, only: [:current] + skip_before_action :find_object_by_uuid, only: [:current] + skip_before_action :render_404_if_no_object, only: [:current] def auth if @object.locked_by_uuid != Thread.current[:api_client_authorization].uuid raise ArvadosModel::PermissionDeniedError.new("Not locked by your token") end - @object = @object.auth + if @object.runtime_token.nil? + @object = @object.auth + else + @object = ApiClientAuthorization.validate(token: @object.runtime_token) + if @object.nil? + raise ArvadosModel::PermissionDeniedError.new("Invalid runtime_token") + end + end show end def update @object.with_lock do - @object.reload super end end @@ -31,7 +38,7 @@ class Arvados::V1::ContainersController < ApplicationController super if action_name == 'lock' || action_name == 'unlock' # Avoid loading more fields than we need - @objects = @objects.select(:id, :uuid, :state, :priority, :auth_uuid, :locked_by_uuid) + @objects = @objects.select(:id, :uuid, :state, :priority, :auth_uuid, :locked_by_uuid, :lock_count) @select = %w(uuid state priority auth_uuid locked_by_uuid) end end @@ -50,20 +57,18 @@ class Arvados::V1::ContainersController < ApplicationController if Thread.current[:api_client_authorization].nil? send_error("Not logged in", status: 401) else - c = Container.where(auth_uuid: Thread.current[:api_client_authorization].uuid).first - if c.nil? + @object = Container.for_current_token + if @object.nil? send_error("Token is not associated with a container.", status: 404) else - @object = c show end end end def secret_mounts - if @object && - @object.auth_uuid && - @object.auth_uuid == Thread.current[:api_client_authorization].uuid + c = Container.for_current_token + if @object && c && @object.uuid == c.uuid send_json({"secret_mounts" => @object.secret_mounts}) else send_error("Token is not associated with this container.", status: 403)