X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/fc69579b197cb963209111620f0a908c7811e1db..42c20b25e1325124b88e3b9b285544dc41122b56:/services/api/test/unit/node_test.rb diff --git a/services/api/test/unit/node_test.rb b/services/api/test/unit/node_test.rb index e5b88354fb..9fa3febe1e 100644 --- a/services/api/test/unit/node_test.rb +++ b/services/api/test/unit/node_test.rb @@ -1,4 +1,10 @@ +# Copyright (C) The Arvados Authors. All rights reserved. +# +# SPDX-License-Identifier: AGPL-3.0 + require 'test_helper' +require 'tmpdir' +require 'tempfile' class NodeTest < ActiveSupport::TestCase def ping_node(node_name, ping_data) @@ -28,18 +34,18 @@ class NodeTest < ActiveSupport::TestCase end test "dns_server_conf_template" do - Rails.configuration.dns_server_conf_dir = Rails.root.join 'tmp' - Rails.configuration.dns_server_conf_template = Rails.root.join 'config', 'unbound.template' + Rails.configuration.Containers.SLURM.Managed.DNSServerConfDir = Rails.root.join 'tmp' + Rails.configuration.Containers.SLURM.Managed.DNSServerConfTemplate = Rails.root.join 'config', 'unbound.template' conffile = Rails.root.join 'tmp', 'compute65535.conf' File.unlink conffile rescue nil assert Node.dns_server_update 'compute65535', '127.0.0.1' - assert_match /\"1\.0\.0\.127\.in-addr\.arpa\. IN PTR compute65535\.zzzzz\.arvadosapi\.com\"/, IO.read(conffile) + assert_match(/\"1\.0\.0\.127\.in-addr\.arpa\. IN PTR compute65535\.zzzzz\.arvadosapi\.com\"/, IO.read(conffile)) File.unlink conffile end test "dns_server_restart_command" do - Rails.configuration.dns_server_conf_dir = Rails.root.join 'tmp' - Rails.configuration.dns_server_reload_command = 'foobar' + Rails.configuration.Containers.SLURM.Managed.DNSServerConfDir = Rails.root.join 'tmp' + Rails.configuration.Containers.SLURM.Managed.DNSServerReloadCommand = 'foobar' restartfile = Rails.root.join 'tmp', 'restart.txt' File.unlink restartfile rescue nil assert Node.dns_server_update 'compute65535', '127.0.0.127' @@ -48,14 +54,14 @@ class NodeTest < ActiveSupport::TestCase end test "dns_server_restart_command fail" do - Rails.configuration.dns_server_conf_dir = Rails.root.join 'tmp', 'bogusdir' - Rails.configuration.dns_server_reload_command = 'foobar' + Rails.configuration.Containers.SLURM.Managed.DNSServerConfDir = Rails.root.join 'tmp', 'bogusdir' + Rails.configuration.Containers.SLURM.Managed.DNSServerReloadCommand = 'foobar' refute Node.dns_server_update 'compute65535', '127.0.0.127' end test "dns_server_update_command with valid command" do testfile = Rails.root.join('tmp', 'node_test_dns_server_update_command.txt') - Rails.configuration.dns_server_update_command = + Rails.configuration.Containers.SLURM.Managed.DNSServerUpdateCommand = ('echo -n "%{hostname} == %{ip_address}" >' + testfile.to_s.shellescape) assert Node.dns_server_update 'compute65535', '127.0.0.1' @@ -64,18 +70,28 @@ class NodeTest < ActiveSupport::TestCase end test "dns_server_update_command with failing command" do - Rails.configuration.dns_server_update_command = 'false %{hostname}' + Rails.configuration.Containers.SLURM.Managed.DNSServerUpdateCommand = 'false %{hostname}' refute Node.dns_server_update 'compute65535', '127.0.0.1' end test "dns update with no commands/dirs configured" do - Rails.configuration.dns_server_update_command = false - Rails.configuration.dns_server_conf_dir = false - Rails.configuration.dns_server_conf_template = 'ignored!' - Rails.configuration.dns_server_reload_command = 'ignored!' + Rails.configuration.Containers.SLURM.Managed.DNSServerUpdateCommand = "" + Rails.configuration.Containers.SLURM.Managed.DNSServerConfDir = "" + Rails.configuration.Containers.SLURM.Managed.DNSServerConfTemplate = 'ignored!' + Rails.configuration.Containers.SLURM.Managed.DNSServerReloadCommand = 'ignored!' assert Node.dns_server_update 'compute65535', '127.0.0.127' end + test "don't leave temp files behind if there's an error writing them" do + Rails.configuration.Containers.SLURM.Managed.DNSServerConfTemplate = Rails.root.join 'config', 'unbound.template' + Tempfile.any_instance.stubs(:puts).raises(IOError) + Dir.mktmpdir do |tmpdir| + Rails.configuration.Containers.SLURM.Managed.DNSServerConfDir = tmpdir + refute Node.dns_server_update 'compute65535', '127.0.0.127' + assert_empty Dir.entries(tmpdir).select{|f| File.file? f} + end + end + test "ping new node with no hostname and default config" do node = ping_node(:new_with_no_hostname, {}) slot_number = node.slot_number @@ -84,14 +100,14 @@ class NodeTest < ActiveSupport::TestCase end test "ping new node with no hostname and no config" do - Rails.configuration.assign_node_hostname = false + Rails.configuration.Containers.SLURM.Managed.AssignNodeHostname = false node = ping_node(:new_with_no_hostname, {}) refute_nil node.slot_number assert_nil node.hostname end test "ping new node with zero padding config" do - Rails.configuration.assign_node_hostname = 'compute%04d' + Rails.configuration.Containers.SLURM.Managed.AssignNodeHostname = 'compute%04d' node = ping_node(:new_with_no_hostname, {}) slot_number = node.slot_number refute_nil slot_number @@ -105,7 +121,7 @@ class NodeTest < ActiveSupport::TestCase end test "ping node with hostname and no config and expect hostname unchanged" do - Rails.configuration.assign_node_hostname = false + Rails.configuration.Containers.SLURM.Managed.AssignNodeHostname = false node = ping_node(:new_with_custom_hostname, {}) assert_equal(23, node.slot_number) assert_equal("custom1", node.hostname) @@ -116,13 +132,84 @@ class NodeTest < ActiveSupport::TestCase test "ping two nodes one with no hostname and one with hostname and check hostnames" do # ping node with no hostname and expect it set with config format node = ping_node(:new_with_no_hostname, {}) - slot_number = node.slot_number refute_nil node.slot_number - assert_equal "compute#{slot_number}", node.hostname + assert_equal "compute#{node.slot_number}", node.hostname # ping node with a hostname and expect it to be unchanged node2 = ping_node(:new_with_custom_hostname, {}) refute_nil node2.slot_number assert_equal "custom1", node2.hostname end + + test "update dns when hostname and ip_address are cleared" do + act_as_system_user do + node = ping_node(:new_with_custom_hostname, {}) + Node.expects(:dns_server_update).with(node.hostname, Node::UNUSED_NODE_IP) + node.update_attributes(hostname: nil, ip_address: nil) + end + end + + test "update dns when hostname changes" do + act_as_system_user do + node = ping_node(:new_with_custom_hostname, {}) + + Node.expects(:dns_server_update).with(node.hostname, Node::UNUSED_NODE_IP) + Node.expects(:dns_server_update).with('foo0', node.ip_address) + node.update_attributes!(hostname: 'foo0') + + Node.expects(:dns_server_update).with('foo0', Node::UNUSED_NODE_IP) + node.update_attributes!(hostname: nil, ip_address: nil) + + Node.expects(:dns_server_update).with('foo0', '10.11.12.13') + node.update_attributes!(hostname: 'foo0', ip_address: '10.11.12.13') + + Node.expects(:dns_server_update).with('foo0', '10.11.12.14') + node.update_attributes!(hostname: 'foo0', ip_address: '10.11.12.14') + end + end + + test 'newest ping wins IP address conflict' do + act_as_system_user do + n1, n2 = Node.create!, Node.create! + + n1.ping(ip: '10.5.5.5', ping_secret: n1.info['ping_secret']) + n1.reload + + Node.expects(:dns_server_update).with(n1.hostname, Node::UNUSED_NODE_IP) + Node.expects(:dns_server_update).with(Not(equals(n1.hostname)), '10.5.5.5') + n2.ping(ip: '10.5.5.5', ping_secret: n2.info['ping_secret']) + + n1.reload + n2.reload + assert_nil n1.ip_address + assert_equal '10.5.5.5', n2.ip_address + + Node.expects(:dns_server_update).with(n2.hostname, Node::UNUSED_NODE_IP) + Node.expects(:dns_server_update).with(n1.hostname, '10.5.5.5') + n1.ping(ip: '10.5.5.5', ping_secret: n1.info['ping_secret']) + + n1.reload + n2.reload + assert_nil n2.ip_address + assert_equal '10.5.5.5', n1.ip_address + end + end + + test 'run out of slots' do + Rails.configuration.Containers.MaxComputeVMs = 3 + act_as_system_user do + Node.destroy_all + (1..4).each do |i| + n = Node.create! + args = { ip: "10.0.0.#{i}", ping_secret: n.info['ping_secret'] } + if i <= Rails.configuration.Containers.MaxComputeVMs + n.ping(args) + else + assert_raises do + n.ping(args) + end + end + end + end + end end