X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/f5e7711b2b8b7f4d191b8fb47078cddd9c0c6727..74c3346a12b71f8c85e4fae6c390a9e374bc39a8:/services/api/app/models/user.rb diff --git a/services/api/app/models/user.rb b/services/api/app/models/user.rb index e87fb3159d..a85a63df7d 100644 --- a/services/api/app/models/user.rb +++ b/services/api/app/models/user.rb @@ -5,16 +5,21 @@ class User < ArvadosModel serialize :prefs, Hash has_many :api_client_authorizations before_update :prevent_privilege_escalation + before_update :prevent_inactive_admin + before_create :check_auto_admin + after_create AdminNotifier - has_many :authorized_keys, :foreign_key => :authorized_user, :primary_key => :uuid + has_many :authorized_keys, :foreign_key => :authorized_user_uuid, :primary_key => :uuid - api_accessible :superuser, :extend => :common do |t| + api_accessible :user, extend: :common do |t| t.add :email t.add :full_name t.add :first_name t.add :last_name t.add :identity_url + t.add :is_active t.add :is_admin + t.add :is_invited t.add :prefs end @@ -24,11 +29,18 @@ class User < ArvadosModel "#{first_name} #{last_name}" end + def is_invited + !!(self.is_active || + Rails.configuration.new_users_are_active || + self.groups_i_can(:read).select { |x| x.match /-f+$/ }.first) + end + def groups_i_can(verb) self.group_permissions.select { |uuid, mask| mask[verb] }.keys end def can?(actions) + return true if is_admin actions.each do |action, target| target_uuid = target if target.respond_to? :uuid @@ -37,10 +49,10 @@ class User < ArvadosModel next if target_uuid == self.uuid next if (group_permissions[target_uuid] and group_permissions[target_uuid][action]) - if target.respond_to? :owner - next if target.owner == self.uuid - next if (group_permissions[target.owner] and - group_permissions[target.owner][action]) + if target.respond_to? :owner_uuid + next if target.owner_uuid == self.uuid + next if (group_permissions[target.owner_uuid] and + group_permissions[target.owner_uuid][action]) end return false end @@ -51,25 +63,9 @@ class User < ArvadosModel Rails.cache.delete_matched(/^groups_for_user_/) end - protected - - def permission_to_create - Thread.current[:user] == self or - (Thread.current[:user] and Thread.current[:user].is_admin) - end - - def prevent_privilege_escalation - if self.is_admin_changed? and !current_user.is_admin - if current_user.uuid == self.uuid - if self.is_admin != self.is_admin_was - logger.warn "User #{self.uuid} tried to change is_admin from #{self.is_admin_was} to #{self.is_admin}" - self.is_admin = self.is_admin_was - end - end - end - true - end - + # Return a hash of {group_uuid: perm_hash} where perm_hash[:read] + # and perm_hash[:write] are true if this user can read and write + # objects owned by group_uuid. def group_permissions Rails.cache.fetch "groups_for_user_#{self.uuid}" do permissions_from = {} @@ -79,15 +75,22 @@ class User < ArvadosModel lookup_uuids = todo.keys lookup_uuids.each do |uuid| done[uuid] = true end todo = {} + newgroups = [] + Group.where('owner_uuid in (?)', lookup_uuids).each do |group| + newgroups << [group.owner_uuid, group.uuid, 'can_manage'] + end Link.where('tail_uuid in (?) and link_class = ? and head_kind = ?', lookup_uuids, 'permission', 'arvados#group').each do |link| - unless done.has_key? link.head_uuid - todo[link.head_uuid] = true + newgroups << [link.tail_uuid, link.head_uuid, link.name] + end + newgroups.each do |tail_uuid, head_uuid, perm_name| + unless done.has_key? head_uuid + todo[head_uuid] = true end link_permissions = {} - case link.name + case perm_name when 'can_read' link_permissions = {read:true} when 'can_write' @@ -95,10 +98,10 @@ class User < ArvadosModel when 'can_manage' link_permissions = ALL_PERMISSIONS end - permissions_from[link.tail_uuid] ||= {} - permissions_from[link.tail_uuid][link.head_uuid] ||= {} + permissions_from[tail_uuid] ||= {} + permissions_from[tail_uuid][head_uuid] ||= {} link_permissions.each do |k,v| - permissions_from[link.tail_uuid][link.head_uuid][k] ||= v + permissions_from[tail_uuid][head_uuid][k] ||= v end end end @@ -106,6 +109,58 @@ class User < ArvadosModel end end + protected + + def permission_to_update + # users must be able to update themselves (even if they are + # inactive) in order to create sessions + self == current_user or super + end + + def permission_to_create + current_user.andand.is_admin or + (self == current_user and + self.is_active == Rails.configuration.new_users_are_active) + end + + def check_auto_admin + if User.where("uuid not like '%-000000000000000'").where(:is_admin => true).count == 0 and not Rails.configuration.auto_admin_user.nil? + if current_user.email == Rails.configuration.auto_admin_user + self.is_admin = true + self.is_active = true + end + end + end + + def prevent_privilege_escalation + if current_user.andand.is_admin + return true + end + if self.is_active_changed? + if self.is_active != self.is_active_was + logger.warn "User #{current_user.uuid} tried to change is_active from #{self.is_admin_was} to #{self.is_admin} for #{self.uuid}" + self.is_active = self.is_active_was + end + end + if self.is_admin_changed? + if self.is_admin != self.is_admin_was + logger.warn "User #{current_user.uuid} tried to change is_admin from #{self.is_admin_was} to #{self.is_admin} for #{self.uuid}" + self.is_admin = self.is_admin_was + end + end + true + end + + def prevent_inactive_admin + if self.is_admin and not self.is_active + # There is no known use case for the strange set of permissions + # that would result from this change. It's safest to assume it's + # a mistake and disallow it outright. + raise "Admin users cannot be inactive" + end + true + end + def search_permissions(start, graph, merged={}, upstream_mask=nil, upstream_path={}) nextpaths = graph[start] return merged if !nextpaths