X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/f580cf6d3d86f6591e68b4501279fc45cbf847e0..8c9b4a1c7b4ad3feb5c0ccb14888aad7ed262e18:/services/api/test/functional/arvados/v1/users_controller_test.rb diff --git a/services/api/test/functional/arvados/v1/users_controller_test.rb b/services/api/test/functional/arvados/v1/users_controller_test.rb index 5f1a3f0225..04e74aae61 100644 --- a/services/api/test/functional/arvados/v1/users_controller_test.rb +++ b/services/api/test/functional/arvados/v1/users_controller_test.rb @@ -13,7 +13,7 @@ class Arvados::V1::UsersControllerTest < ActionController::TestCase get :current assert_response :success me = JSON.parse(@response.body) - post :activate, uuid: me['uuid'] + post :activate, id: me['uuid'] assert_response :success assert_not_nil assigns(:object) me = JSON.parse(@response.body) @@ -21,12 +21,37 @@ class Arvados::V1::UsersControllerTest < ActionController::TestCase end test "refuse to activate a user before signing UA" do + act_as_system_user do + required_uuids = Link.where("owner_uuid = ? and link_class = ? and name = ? and tail_uuid = ? and head_uuid like ?", + system_user_uuid, + 'signature', + 'require', + system_user_uuid, + Collection.uuid_like_pattern). + collect(&:head_uuid) + + assert required_uuids.length > 0 + + signed_uuids = Link.where(owner_uuid: system_user_uuid, + link_class: 'signature', + name: 'click', + tail_uuid: users(:inactive).uuid, + head_uuid: required_uuids). + collect(&:head_uuid) + + assert_equal 0, signed_uuids.length + end + authorize_with :inactive + get :current assert_response :success me = JSON.parse(@response.body) - post :activate, uuid: me['uuid'] + assert_equal false, me['is_active'] + + post :activate, id: me['uuid'] assert_response 403 + get :current assert_response :success me = JSON.parse(@response.body) @@ -38,12 +63,18 @@ class Arvados::V1::UsersControllerTest < ActionController::TestCase get :current assert_response :success me = JSON.parse(@response.body) - post :activate, uuid: me['uuid'] + post :activate, id: me['uuid'] assert_response :success me = JSON.parse(@response.body) assert_equal true, me['is_active'] end + test "respond 401 if given token exists but user record is missing" do + authorize_with :valid_token_deleted_user + get :current, {format: :json} + assert_response 401 + end + test "create new user with user as input" do authorize_with :admin post :create, user: { @@ -113,6 +144,7 @@ class Arvados::V1::UsersControllerTest < ActionController::TestCase email: "foo@example.com" } } + assert_response :success response_items = JSON.parse(@response.body)['items'] @@ -410,8 +442,11 @@ class Arvados::V1::UsersControllerTest < ActionController::TestCase 'expected same uuid as first create operation' assert_equal response_object['email'], 'foo@example.com', 'expected given email' - # +1 extra login link +1 extra system_group link pointing to the new User - verify_num_links @all_links_at_start, 6 + # +1 extra can_read 'all users' group link + # +1 extra system_group can_manage link pointing to the new User + # +1 extra can_login permission link + # no repo link, no vm link + verify_num_links @all_links_at_start, 7 end test "setup user with openid prefix" do @@ -663,7 +698,7 @@ class Arvados::V1::UsersControllerTest < ActionController::TestCase verify_link_existence created['uuid'], created['email'], true, true, true, true, false # now unsetup this user - post :unsetup, uuid: created['uuid'] + post :unsetup, id: created['uuid'] assert_response :success created2 = JSON.parse(@response.body) @@ -683,12 +718,12 @@ class Arvados::V1::UsersControllerTest < ActionController::TestCase assert active_user['is_invited'], 'expected is_invited for active user' verify_link_existence active_user['uuid'], active_user['email'], - false, false, false, true, true + false, true, false, true, true authorize_with :admin # now unsetup this user - post :unsetup, uuid: active_user['uuid'] + post :unsetup, id: active_user['uuid'] assert_response :success response_user = JSON.parse(@response.body) @@ -701,6 +736,58 @@ class Arvados::V1::UsersControllerTest < ActionController::TestCase false, false, false, false, false end + test "setup user with send notification param false and verify no email" do + authorize_with :admin + + post :setup, { + openid_prefix: 'http://www.example.com/account', + send_notification_email: 'false', + user: { + email: "foo@example.com" + } + } + + assert_response :success + response_items = JSON.parse(@response.body)['items'] + created = find_obj_in_resp response_items, 'User', nil + assert_not_nil created['uuid'], 'expected uuid for the new user' + assert_equal created['email'], 'foo@example.com', 'expected given email' + + setup_email = ActionMailer::Base.deliveries.last + assert_nil setup_email, 'expected no setup email' + end + + test "setup user with send notification param true and verify email" do + authorize_with :admin + + post :setup, { + openid_prefix: 'http://www.example.com/account', + send_notification_email: 'true', + user: { + email: "foo@example.com" + } + } + + assert_response :success + response_items = JSON.parse(@response.body)['items'] + created = find_obj_in_resp response_items, 'User', nil + assert_not_nil created['uuid'], 'expected uuid for the new user' + assert_equal created['email'], 'foo@example.com', 'expected given email' + + setup_email = ActionMailer::Base.deliveries.last + assert_not_nil setup_email, 'Expected email after setup' + + assert_equal Rails.configuration.user_notifier_email_from, setup_email.from[0] + assert_equal 'foo@example.com', setup_email.to[0] + assert_equal 'Welcome to Curoverse', setup_email.subject + assert (setup_email.body.to_s.include? 'Your Arvados account has been set up'), + 'Expected Your Arvados account has been set up in email body' + assert (setup_email.body.to_s.include? 'foo@example.com'), + 'Expected user email in email body' + assert (setup_email.body.to_s.include? Rails.configuration.workbench_address), + 'Expected workbench url in email body' + end + def verify_num_links (original_links, expected_additional_links) links_now = Link.all assert_equal expected_additional_links, Link.all.size-original_links.size, @@ -709,6 +796,7 @@ class Arvados::V1::UsersControllerTest < ActionController::TestCase def find_obj_in_resp (response_items, object_type, head_kind=nil) return_obj = nil + response_items response_items.each { |x| if !x next