X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/f5783fd9242883b10dcd6e371597b798e1eecc5e..15303f9cf99f00ccdef948e5ce593d9a3a88d21a:/apps/workbench/test/integration/application_layout_test.rb diff --git a/apps/workbench/test/integration/application_layout_test.rb b/apps/workbench/test/integration/application_layout_test.rb index 5ce850dd1a..b85977f213 100644 --- a/apps/workbench/test/integration/application_layout_test.rb +++ b/apps/workbench/test/integration/application_layout_test.rb @@ -1,21 +1,16 @@ require 'integration_helper' -require 'selenium-webdriver' -require 'headless' class ApplicationLayoutTest < ActionDispatch::IntegrationTest - setup do - headless = Headless.new - headless.start - Capybara.current_driver = :selenium - - @user_profile_form_fields = Rails.configuration.user_profile_form_fields - end + # These tests don't do state-changing API calls. Save some time by + # skipping the database reset. + reset_api_fixtures :after_each_test, false + reset_api_fixtures :after_suite, true - teardown do - Rails.configuration.user_profile_form_fields = @user_profile_form_fields + setup do + need_javascript end - def verify_homepage_with_profile user, invited, has_profile + def verify_homepage user, invited, has_profile profile_config = Rails.configuration.user_profile_form_fields if !user @@ -23,25 +18,28 @@ class ApplicationLayoutTest < ActionDispatch::IntegrationTest assert page.has_text?('The "Log in" button below will show you a Google sign-in page'), 'Not found text - google sign in page' assert page.has_no_text?('My projects'), 'Found text - My projects' assert page.has_link?("Log in to #{Rails.configuration.site_name}"), 'Not found text - log in to' - elsif profile_config && !has_profile && user['is_active'] - add_profile user elsif user['is_active'] - assert page.has_text?('My projects'), 'Not found text - My projects' - assert page.has_text?('Projects shared with me'), 'Not found text - Project shared with me' - assert page.has_no_text?('Save profile'), 'Found text - Save profile' + if profile_config && !has_profile + assert page.has_text?('Save profile'), 'No text - Save profile' + else + assert page.has_link?("Projects"), 'Not found link - Projects' + page.find("#projects-menu").click + assert page.has_text?('Projects shared with me'), 'Not found text - Project shared with me' + end elsif invited assert page.has_text?('Please check the box below to indicate that you have read and accepted the user agreement'), 'Not found text - Please check the box below . . .' - assert page.has_no_text?('Save profile'), 'Found text - Save profile' else assert page.has_text?('Your account is inactive'), 'Not found text - Your account is inactive' - assert page.has_no_text?('Save profile'), 'Found text - Save profile' end within('.navbar-fixed-top') do if !user + assert_text Rails.configuration.site_name.downcase + assert_no_selector 'a', text: Rails.configuration.site_name.downcase assert page.has_link?('Log in'), 'Not found link - Log in' else # my account menu + assert_selector 'a', text: Rails.configuration.site_name.downcase assert page.has_link?("#{user['email']}"), 'Not found link - email' find('a', text: "#{user['email']}").click within('.dropdown-menu') do @@ -56,6 +54,9 @@ class ApplicationLayoutTest < ActionDispatch::IntegrationTest else assert page.has_no_link?('Manage profile'), 'Found link - Manage profile' end + else + assert page.has_no_link?('Manage account'), 'Found link - Manage account' + assert page.has_no_link?('Manage profile'), 'Found link - Manage profile' end assert page.has_link?('Log out'), 'No link - Log out' end @@ -68,6 +69,8 @@ class ApplicationLayoutTest < ActionDispatch::IntegrationTest within('.navbar-fixed-top') do page.find("#arv-help").click within('.dropdown-menu') do + assert_selector 'a', text:'Getting Started ...' + assert_selector 'a', text:'Public Pipelines and Data sets' assert page.has_link?('Tutorials and User guide'), 'No link - Tutorials and User guide' assert page.has_link?('API Reference'), 'No link - API Reference' assert page.has_link?('SDK Reference'), 'No link - SDK Reference' @@ -79,133 +82,23 @@ class ApplicationLayoutTest < ActionDispatch::IntegrationTest end def verify_system_menu user - if user && user['is_active'] - look_for_add_new = nil + if user && user['is_admin'] + assert page.has_link?('system-menu'), 'No link - system menu' within('.navbar-fixed-top') do page.find("#system-menu").click - if user['is_admin'] - within('.dropdown-menu') do - assert page.has_text?('Groups'), 'No text - Groups' - assert page.has_link?('Repositories'), 'No link - Repositories' - assert page.has_link?('Virtual machines'), 'No link - Virtual machines' - assert page.has_link?('SSH keys'), 'No link - SSH keys' - assert page.has_link?('API tokens'), 'No link - API tokens' - find('a', text: 'Users').click - look_for_add_new = 'Add a new user' - end - else - within('.dropdown-menu') do - assert page.has_no_text?('Users'), 'Found text - Users' - assert page.has_no_link?('Repositories'), 'Found link - Repositories' - assert page.has_no_link?('Virtual machines'), 'Found link - Virtual machines' - assert page.has_no_link?('SSH keys'), 'Found link - SSH keys' - assert page.has_no_link?('API tokens'), 'Found link - API tokens' - - find('a', text: 'Groups').click - look_for_add_new = 'Add a new group' - end - end - end - if look_for_add_new - assert page.has_text? look_for_add_new - end - else - assert page.has_no_link?('#system-menu'), 'Found link - system menu' - end - end - - # test manage_account page - def verify_manage_account user - if user && user['is_active'] - within('.navbar-fixed-top') do - find('a', text: "#{user['email']}").click within('.dropdown-menu') do - find('a', text: 'Manage account').click + assert page.has_text?('Groups'), 'No text - Groups' + assert page.has_link?('Repositories'), 'No link - Repositories' + assert page.has_link?('Virtual machines'), 'No link - Virtual machines' + assert page.has_link?('SSH keys'), 'No link - SSH keys' + assert page.has_link?('API tokens'), 'No link - API tokens' + find('a', text: 'Users').click end end - - # now in manage account page - assert page.has_text?('Virtual Machines'), 'No text - Virtual Machines' - assert page.has_text?('Repositories'), 'No text - Repositories' - assert page.has_text?('SSH Keys'), 'No text - SSH Keys' - assert page.has_text?('Current Token'), 'No text - Current Token' - - assert page.has_text?('The Arvados API token is a secret key that enables the Arvados SDKs to access Arvados'), 'No text - Arvados API token' - - click_link 'Add new SSH key' - - within '.modal-content' do - assert page.has_text?('Public Key'), 'No text - Public Key' - assert page.has_button?('Cancel'), 'No button - Cancel' - assert page.has_button?('Submit'), 'No button - Submit' - - page.find_field('public_key').set 'first test with an incorrect ssh key value' - click_button 'Submit' - assert page.has_text?('Public key does not appear to be a valid ssh-rsa or dsa public key'), 'No text - Public key does not appear to be a valid' - - public_key_str = api_fixture('authorized_keys')['active']['public_key'] - page.find_field('public_key').set public_key_str - page.find_field('name').set 'added_in_test' - click_button 'Submit' - assert page.has_text?('Public key already exists in the database, use a different key.'), 'No text - Public key already exists' - - new_key = SSHKey.generate - page.find_field('public_key').set new_key.ssh_public_key - page.find_field('name').set 'added_in_test' - click_button 'Submit' - end - - # key must be added. look for it in the refreshed page - assert page.has_text?('added_in_test'), 'No text - added_in_test' - end - end - - # Check manage profile page and add missing profile to the user - def add_profile user - assert page.has_no_text?('My projects'), 'Found text - My projects' - assert page.has_no_text?('Projects shared with me'), 'Found text - Projects shared with me' - - assert page.has_text?('Profile'), 'No text - Profile' - assert page.has_text?('First name'), 'No text - First name' - assert page.has_text?('Last name'), 'No text - Last name' - assert page.has_text?('Identity URL'), 'No text - Identity URL' - assert page.has_text?('Email'), 'No text - Email' - assert page.has_text?(user['email']), 'No text - user email' - - # Using the default profile which has message and one required field - - # Save profile without filling in the required field. Expect to be back in this profile page again - click_button "Save profile" - assert page.has_text?('Profile'), 'No text - Profile' - assert page.has_text?('First name'), 'No text - First name' - assert page.has_text?('Last name'), 'No text - Last name' - assert page.has_text?('Save profile'), 'No text - Save profile' - - # This time fill in required field and then save. Expect to go to requested page after that. - profile_message = Rails.configuration.user_profile_form_message - required_field_title = '' - required_field_key = '' - profile_config = Rails.configuration.user_profile_form_fields - profile_config.andand.each do |entry| - if entry['required'] - required_field_key = entry['key'] - required_field_title = entry['form_field_title'] - end + assert page.has_text? 'Add a new user' + else + assert page.has_no_link?('system-menu'), 'Found link - system menu' end - - assert page.has_text? profile_message.gsub(/<.*?>/,'') - assert page.has_text?(required_field_title), 'No text - configured required field title' - - page.find_field('user[prefs][:profile][:'+required_field_key+']').set 'value to fill required field' - - click_button "Save profile" - # profile saved and in profile page now with success - assert page.has_text?('Thank you for filling in your profile'), 'No text - Thank you for filling' - click_link 'Back to work!' - - # profile saved and in home page now - assert page.has_text?('My projects'), 'No text - My projects' - assert page.has_text?('Projects shared with me'), 'No text - Projects shared with me' end [ @@ -215,56 +108,78 @@ class ApplicationLayoutTest < ActionDispatch::IntegrationTest ['active', api_fixture('users')['active'], true, true], ['admin', api_fixture('users')['admin'], true, true], ['active_no_prefs', api_fixture('users')['active_no_prefs'], true, false], - ['active_no_prefs_profile', api_fixture('users')['active_no_prefs_profile'], true, false], + ['active_no_prefs_profile_no_getting_started_shown', + api_fixture('users')['active_no_prefs_profile_no_getting_started_shown'], true, false], + ['active_no_prefs_profile_with_getting_started_shown', + api_fixture('users')['active_no_prefs_profile_with_getting_started_shown'], true, false], ].each do |token, user, invited, has_profile| - test "visit home page when profile is configured for user #{token}" do - # Our test config enabled profile by default. So, no need to update config + test "visit home page for user #{token}" do if !token visit ('/') else visit page_with_token(token) end - verify_homepage_with_profile user, invited, has_profile + verify_homepage user, invited, has_profile end - test "visit home page when profile not configured for user #{token}" do - Rails.configuration.user_profile_form_fields = false - + test "check help for user #{token}" do if !token visit ('/') else visit page_with_token(token) end - verify_homepage_with_profile user, invited, has_profile + check_help_menu end - test "check help for user #{token}" do + test "test system menu for user #{token}" do if !token visit ('/') else visit page_with_token(token) end - check_help_menu + verify_system_menu user end end - [ - ['active', api_fixture('users')['active']], - ['admin', api_fixture('users')['admin']], - ].each do |token, user| + test "test getting started help menu item" do + visit page_with_token('active') + within '.navbar-fixed-top' do + find('.help-menu > a').click + find('.help-menu .dropdown-menu a', text: 'Getting Started ...').click + end - test "test system menu for user #{token}" do - visit page_with_token(token) - verify_system_menu user + within '.modal-content' do + assert_text 'Getting Started' + assert_selector 'button:not([disabled])', text: 'Next' + assert_no_selector 'button:not([disabled])', text: 'Prev' + click_button 'Next' + assert_selector 'button:not([disabled])', text: 'Prev' # Prev button is now enabled + click_button 'Prev' + assert_no_selector 'button:not([disabled])', text: 'Prev' # Prev button is again disabled + first('button', text: 'x').click end + assert_text 'Active pipelines' # seeing dashboard now + end + + test "test arvados_public_data_doc_url config unset" do + Rails.configuration.arvados_public_data_doc_url = false + + visit page_with_token('active') + within '.navbar-fixed-top' do + find('.help-menu > a').click + + assert_no_selector 'a', text:'Public Pipelines and Data sets' - test "test manage account for user #{token}" do - visit page_with_token(token) - verify_manage_account user + assert_selector 'a', text:'Getting Started ...' + assert page.has_link?('Tutorials and User guide'), 'No link - Tutorials and User guide' + assert page.has_link?('API Reference'), 'No link - API Reference' + assert page.has_link?('SDK Reference'), 'No link - SDK Reference' + assert page.has_link?('Show version / debugging info ...'), 'No link - Show version / debugging info' + assert page.has_link?('Report a problem ...'), 'No link - Report a problem' end end end