X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/f4f0614d06c4ac9abeb34dc6df7c88ecb5feebda..b7c4169e3d729ab4c45fde472e1da26d900f808d:/lib/controller/handler_test.go diff --git a/lib/controller/handler_test.go b/lib/controller/handler_test.go index e8cd1efbad..7d8266a85c 100644 --- a/lib/controller/handler_test.go +++ b/lib/controller/handler_test.go @@ -19,6 +19,7 @@ import ( "git.arvados.org/arvados.git/sdk/go/arvados" "git.arvados.org/arvados.git/sdk/go/arvadostest" + "git.arvados.org/arvados.git/sdk/go/auth" "git.arvados.org/arvados.git/sdk/go/ctxlog" "git.arvados.org/arvados.git/sdk/go/httpserver" "github.com/prometheus/client_golang/prometheus" @@ -51,6 +52,7 @@ func (s *HandlerSuite) SetUpTest(c *check.C) { PostgreSQL: integrationTestCluster().PostgreSQL, ForceLegacyAPI14: forceLegacyAPI14, } + s.cluster.API.RequestTimeout = arvados.Duration(5 * time.Minute) s.cluster.TLS.Insecure = true arvadostest.SetServiceURL(&s.cluster.Services.RailsAPI, "https://"+os.Getenv("ARVADOS_TEST_API_HOST")) arvadostest.SetServiceURL(&s.cluster.Services.Controller, "http://localhost:/") @@ -70,7 +72,10 @@ func (s *HandlerSuite) TestConfigExport(c *check.C) { req := httptest.NewRequest(method, "/arvados/v1/config", nil) resp := httptest.NewRecorder() s.handler.ServeHTTP(resp, req) - c.Check(resp.Code, check.Equals, http.StatusOK) + c.Log(resp.Body.String()) + if !c.Check(resp.Code, check.Equals, http.StatusOK) { + continue + } c.Check(resp.Header().Get("Access-Control-Allow-Origin"), check.Equals, `*`) c.Check(resp.Header().Get("Access-Control-Allow-Methods"), check.Matches, `.*\bGET\b.*`) c.Check(resp.Header().Get("Access-Control-Allow-Headers"), check.Matches, `.+`) @@ -79,12 +84,11 @@ func (s *HandlerSuite) TestConfigExport(c *check.C) { continue } var cluster arvados.Cluster - c.Log(resp.Body.String()) err := json.Unmarshal(resp.Body.Bytes(), &cluster) c.Check(err, check.IsNil) c.Check(cluster.ManagementToken, check.Equals, "") c.Check(cluster.SystemRootToken, check.Equals, "") - c.Check(cluster.Collections.BlobSigning, check.DeepEquals, true) + c.Check(cluster.Collections.BlobSigning, check.Equals, true) c.Check(cluster.Collections.BlobSigningTTL, check.Equals, arvados.Duration(23*time.Second)) } } @@ -166,8 +170,9 @@ func (s *HandlerSuite) TestProxyNotFound(c *check.C) { } func (s *HandlerSuite) TestProxyRedirect(c *check.C) { - s.cluster.Login.ProviderAppID = "test" - s.cluster.Login.ProviderAppSecret = "test" + s.cluster.Login.SSO.Enable = true + s.cluster.Login.SSO.ProviderAppID = "test" + s.cluster.Login.SSO.ProviderAppSecret = "test" req := httptest.NewRequest("GET", "https://0.0.0.0:1/login?return_to=foo", nil) resp := httptest.NewRecorder() s.handler.ServeHTTP(resp, req) @@ -180,6 +185,34 @@ func (s *HandlerSuite) TestProxyRedirect(c *check.C) { c.Check(resp.Header().Get("Location"), check.Matches, `(https://0.0.0.0:1)?/auth/joshid\?return_to=%2Cfoo&?`) } +func (s *HandlerSuite) TestLogoutSSO(c *check.C) { + s.cluster.Login.SSO.Enable = true + s.cluster.Login.SSO.ProviderAppID = "test" + req := httptest.NewRequest("GET", "https://0.0.0.0:1/logout?return_to=https://example.com/foo", nil) + resp := httptest.NewRecorder() + s.handler.ServeHTTP(resp, req) + if !c.Check(resp.Code, check.Equals, http.StatusFound) { + c.Log(resp.Body.String()) + } + c.Check(resp.Header().Get("Location"), check.Equals, "http://localhost:3002/users/sign_out?"+url.Values{"redirect_uri": {"https://example.com/foo"}}.Encode()) +} + +func (s *HandlerSuite) TestLogoutGoogle(c *check.C) { + if s.cluster.ForceLegacyAPI14 { + // Google login N/A + return + } + s.cluster.Login.Google.Enable = true + s.cluster.Login.Google.ClientID = "test" + req := httptest.NewRequest("GET", "https://0.0.0.0:1/logout?return_to=https://example.com/foo", nil) + resp := httptest.NewRecorder() + s.handler.ServeHTTP(resp, req) + if !c.Check(resp.Code, check.Equals, http.StatusFound) { + c.Log(resp.Body.String()) + } + c.Check(resp.Header().Get("Location"), check.Equals, "https://example.com/foo") +} + func (s *HandlerSuite) TestValidateV1APIToken(c *check.C) { req := httptest.NewRequest("GET", "/arvados/v1/users/current", nil) user, ok, err := s.handler.(*Handler).validateAPItoken(req, arvadostest.ActiveToken) @@ -203,6 +236,26 @@ func (s *HandlerSuite) TestValidateV2APIToken(c *check.C) { c.Check(user.Authorization.TokenV2(), check.Equals, arvadostest.ActiveTokenV2) } +func (s *HandlerSuite) TestValidateRemoteToken(c *check.C) { + saltedToken, err := auth.SaltToken(arvadostest.ActiveTokenV2, "abcde") + c.Assert(err, check.IsNil) + for _, trial := range []struct { + code int + token string + }{ + {http.StatusOK, saltedToken}, + {http.StatusUnauthorized, "bogus"}, + } { + req := httptest.NewRequest("GET", "https://0.0.0.0:1/arvados/v1/users/current?remote=abcde", nil) + req.Header.Set("Authorization", "Bearer "+trial.token) + resp := httptest.NewRecorder() + s.handler.ServeHTTP(resp, req) + if !c.Check(resp.Code, check.Equals, trial.code) { + c.Logf("HTTP %d: %s", resp.Code, resp.Body.String()) + } + } +} + func (s *HandlerSuite) TestCreateAPIToken(c *check.C) { req := httptest.NewRequest("GET", "/arvados/v1/users/current", nil) auth, err := s.handler.(*Handler).createAPItoken(req, arvadostest.ActiveUserUUID, nil) @@ -219,30 +272,27 @@ func (s *HandlerSuite) TestCreateAPIToken(c *check.C) { c.Check(user.Authorization.TokenV2(), check.Equals, auth.TokenV2()) } -func (s *HandlerSuite) TestGetCollection(c *check.C) { +func (s *HandlerSuite) CheckObjectType(c *check.C, url string, token string, skippedFields map[string]bool) { var proxied, direct map[string]interface{} var err error - skippedFields := map[string]bool{ - "href": true, - } // Get collection from controller - fooURL := "/arvados/v1/collections/" + arvadostest.FooCollection - req := httptest.NewRequest("GET", fooURL, nil) - req.Header.Set("Authorization", "Bearer "+arvadostest.ActiveToken) + req := httptest.NewRequest("GET", url, nil) + req.Header.Set("Authorization", "Bearer "+token) resp := httptest.NewRecorder() s.handler.ServeHTTP(resp, req) - c.Check(resp.Code, check.Equals, http.StatusOK) + c.Assert(resp.Code, check.Equals, http.StatusOK, + check.Commentf("Wasn't able to get data from the controller at %q", url)) err = json.Unmarshal(resp.Body.Bytes(), &proxied) c.Check(err, check.Equals, nil) - // Get collection directly from railsAPI + // Get collection directly from RailsAPI client := &http.Client{ Transport: &http.Transport{ TLSClientConfig: &tls.Config{InsecureSkipVerify: true}, }, } - resp2, err := client.Get(s.cluster.Services.RailsAPI.ExternalURL.String() + fooURL + "/?api_token=" + arvadostest.ActiveToken) + resp2, err := client.Get(s.cluster.Services.RailsAPI.ExternalURL.String() + url + "/?api_token=" + token) c.Check(err, check.Equals, nil) defer resp2.Body.Close() db, err := ioutil.ReadAll(resp2.Body) @@ -255,15 +305,49 @@ func (s *HandlerSuite) TestGetCollection(c *check.C) { if _, ok := skippedFields[k]; ok { continue } else if val, ok := proxied[k]; ok { - if k == "manifest_text" { + if direct["kind"] == "arvados#collection" && k == "manifest_text" { // Tokens differ from request to request c.Check(strings.Split(val.(string), "+A")[0], check.Equals, strings.Split(direct[k].(string), "+A")[0]) } else { c.Check(val, check.DeepEquals, direct[k], - check.Commentf("RailsAPI key %q's value %q differs from controller's %q.", k, direct[k], val)) + check.Commentf("RailsAPI %s key %q's value %q differs from controller's %q.", direct["kind"], k, direct[k], val)) } } else { - c.Errorf("Key %q missing on controller's response.", k) + c.Errorf("%s's key %q missing on controller's response.", direct["kind"], k) } } } + +func (s *HandlerSuite) TestGetObjects(c *check.C) { + // Get the 1st keep service's uuid from the running test server. + req := httptest.NewRequest("GET", "/arvados/v1/keep_services/", nil) + req.Header.Set("Authorization", "Bearer "+arvadostest.AdminToken) + resp := httptest.NewRecorder() + s.handler.ServeHTTP(resp, req) + c.Assert(resp.Code, check.Equals, http.StatusOK) + var ksList arvados.KeepServiceList + json.Unmarshal(resp.Body.Bytes(), &ksList) + c.Assert(len(ksList.Items), check.Not(check.Equals), 0) + ksUUID := ksList.Items[0].UUID + + testCases := map[string]map[string]bool{ + "api_clients/" + arvadostest.TrustedWorkbenchAPIClientUUID: nil, + "api_client_authorizations/" + arvadostest.AdminTokenUUID: nil, + "authorized_keys/" + arvadostest.AdminAuthorizedKeysUUID: nil, + "collections/" + arvadostest.CollectionWithUniqueWordsUUID: {"href": true}, + "containers/" + arvadostest.RunningContainerUUID: nil, + "container_requests/" + arvadostest.QueuedContainerRequestUUID: nil, + "groups/" + arvadostest.AProjectUUID: nil, + "keep_services/" + ksUUID: nil, + "links/" + arvadostest.ActiveUserCanReadAllUsersLinkUUID: nil, + "logs/" + arvadostest.CrunchstatForRunningJobLogUUID: nil, + "nodes/" + arvadostest.IdleNodeUUID: nil, + "repositories/" + arvadostest.ArvadosRepoUUID: nil, + "users/" + arvadostest.ActiveUserUUID: {"href": true}, + "virtual_machines/" + arvadostest.TestVMUUID: nil, + "workflows/" + arvadostest.WorkflowWithDefinitionYAMLUUID: nil, + } + for url, skippedFields := range testCases { + s.CheckObjectType(c, "/arvados/v1/"+url, arvadostest.AdminToken, skippedFields) + } +}