X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/f0e6212bbe6e34f6ac4e928a236e77cca852895d..bf08477c7e766c7692731c08212c8d1c3c5628ea:/sdk/go/health/aggregator.go diff --git a/sdk/go/health/aggregator.go b/sdk/go/health/aggregator.go index 1ba1ee3c51..acfdbb7f8f 100644 --- a/sdk/go/health/aggregator.go +++ b/sdk/go/health/aggregator.go @@ -1,11 +1,16 @@ +// Copyright (C) The Arvados Authors. All rights reserved. +// +// SPDX-License-Identifier: Apache-2.0 + package health import ( "context" "encoding/json" + "errors" "fmt" - "net" "net/http" + "net/url" "sync" "time" @@ -23,7 +28,7 @@ type Aggregator struct { httpClient *http.Client timeout arvados.Duration - Config *arvados.Config + Cluster *arvados.Cluster // If non-nil, Log is called after handling each request. Log func(*http.Request, error) @@ -37,6 +42,10 @@ func (agg *Aggregator) setup() { } } +func (agg *Aggregator) CheckHealth() error { + return nil +} + func (agg *Aggregator) ServeHTTP(resp http.ResponseWriter, req *http.Request) { agg.setupOnce.Do(agg.setup) sendErr := func(statusCode int, err error) { @@ -49,22 +58,7 @@ func (agg *Aggregator) ServeHTTP(resp http.ResponseWriter, req *http.Request) { resp.Header().Set("Content-Type", "application/json") - if agg.Config == nil { - cfg, err := arvados.GetConfig() - if err != nil { - err = fmt.Errorf("arvados.GetConfig(): %s", err) - sendErr(http.StatusInternalServerError, err) - return - } - agg.Config = cfg - } - cluster, err := agg.Config.GetCluster("") - if err != nil { - err = fmt.Errorf("arvados.GetCluster(): %s", err) - sendErr(http.StatusInternalServerError, err) - return - } - if !agg.checkAuth(req, cluster) { + if !agg.checkAuth(req) { sendErr(http.StatusUnauthorized, errUnauthorized) return } @@ -72,83 +66,107 @@ func (agg *Aggregator) ServeHTTP(resp http.ResponseWriter, req *http.Request) { sendErr(http.StatusNotFound, errNotFound) return } - json.NewEncoder(resp).Encode(agg.ClusterHealth(cluster)) + json.NewEncoder(resp).Encode(agg.ClusterHealth()) if agg.Log != nil { agg.Log(req, nil) } } -type ServiceHealth struct { +type ClusterHealthResponse struct { + // "OK" if all needed services are OK, otherwise "ERROR". Health string `json:"health"` - N int `json:"n"` -} -type ClusterHealthResponse struct { - Health string `json:"health"` - Checks map[string]CheckResponse `json:"checks"` - Services map[string]ServiceHealth `json:"services"` + // An entry for each known health check of each known instance + // of each needed component: "instance of service S on node N + // reports health-check C is OK." + Checks map[string]CheckResult `json:"checks"` + + // An entry for each service type: "service S is OK." This + // exposes problems that can't be expressed in Checks, like + // "service S is needed, but isn't configured to run + // anywhere." + Services map[arvados.ServiceName]ServiceHealth `json:"services"` } -type CheckResponse struct { - Status int `json:"status"` - Health string `json:"health"` - Error string `json:"error,omitempty"` - ResponseTime json.Number `json:"responseTime"` +type CheckResult struct { + Health string `json:"health"` + Error string `json:"error,omitempty"` + HTTPStatusCode int `json:",omitempty"` + HTTPStatusText string `json:",omitempty"` + Response map[string]interface{} `json:"response"` + ResponseTime json.Number `json:"responseTime"` } -func (r *CheckResponse) OK() bool { - return r.Health == "OK" && r.Status == http.StatusOK +type ServiceHealth struct { + Health string `json:"health"` + N int `json:"n"` } -func (agg *Aggregator) ClusterHealth(cluster *arvados.Cluster) ClusterHealthResponse { +func (agg *Aggregator) ClusterHealth() ClusterHealthResponse { resp := ClusterHealthResponse{ Health: "OK", - Checks: make(map[string]CheckResponse), - Services: make(map[string]ServiceHealth), + Checks: make(map[string]CheckResult), + Services: make(map[arvados.ServiceName]ServiceHealth), } mtx := sync.Mutex{} wg := sync.WaitGroup{} - for node, nodeConfig := range cluster.SystemNodes { - for svc, addr := range map[string]string{ - "keepstore": nodeConfig.Keepstore.Listen, - } { - if addr == "" { - continue - } + for svcName, svc := range agg.Cluster.Services.Map() { + // Ensure svc is listed in resp.Services. + mtx.Lock() + if _, ok := resp.Services[svcName]; !ok { + resp.Services[svcName] = ServiceHealth{Health: "ERROR"} + } + mtx.Unlock() + + for addr := range svc.InternalURLs { wg.Add(1) - go func(node string) { + go func(svcName arvados.ServiceName, addr arvados.URL) { defer wg.Done() - pingResp := agg.ping(node, addr, cluster) + var result CheckResult + pingURL, err := agg.pingURL(addr) + if err != nil { + result = CheckResult{ + Health: "ERROR", + Error: err.Error(), + } + } else { + result = agg.ping(pingURL) + } mtx.Lock() defer mtx.Unlock() - resp.Checks[node+"/"+svc+"/_health/ping"] = pingResp - svHealth := resp.Services[svc] - if pingResp.OK() { - svHealth.N++ + resp.Checks[fmt.Sprintf("%s+%s", svcName, pingURL)] = result + if result.Health == "OK" { + h := resp.Services[svcName] + h.N++ + h.Health = "OK" + resp.Services[svcName] = h } else { resp.Health = "ERROR" } - resp.Services[svc] = svHealth - }(node) + }(svcName, addr) } } wg.Wait() - for svc, svHealth := range resp.Services { - if svHealth.N > 0 { - svHealth.Health = "OK" - } else { - svHealth.Health = "ERROR" + // Report ERROR if a needed service didn't fail any checks + // merely because it isn't configured to run anywhere. + for _, sh := range resp.Services { + if sh.Health != "OK" { + resp.Health = "ERROR" + break } - resp.Services[svc] = svHealth } - return resp } -func (agg *Aggregator) ping(node, addr string, cluster *arvados.Cluster) (result CheckResponse) { +func (agg *Aggregator) pingURL(svcURL arvados.URL) (*url.URL, error) { + base := url.URL(svcURL) + return base.Parse("/_health/ping") +} + +func (agg *Aggregator) ping(target *url.URL) (result CheckResult) { t0 := time.Now() var err error @@ -156,49 +174,45 @@ func (agg *Aggregator) ping(node, addr string, cluster *arvados.Cluster) (result result.ResponseTime = json.Number(fmt.Sprintf("%.6f", time.Since(t0).Seconds())) if err != nil { result.Health, result.Error = "ERROR", err.Error() + } else { + result.Health = "OK" } }() - _, port, err := net.SplitHostPort(addr) + req, err := http.NewRequest("GET", target.String(), nil) if err != nil { return } - req, err := http.NewRequest("GET", "http://"+node+":"+port+"/_health/ping", nil) - if err != nil { - return - } - req.Header.Set("Authorization", "Bearer "+cluster.ManagementToken) - - ctx, cancel := context.WithCancel(req.Context()) - go func() { - select { - case <-time.After(time.Duration(agg.timeout)): - cancel() - case <-ctx.Done(): - } - }() + req.Header.Set("Authorization", "Bearer "+agg.Cluster.ManagementToken) + + ctx, cancel := context.WithTimeout(req.Context(), time.Duration(agg.timeout)) + defer cancel() req = req.WithContext(ctx) resp, err := agg.httpClient.Do(req) if err != nil { return } - result.Status = resp.StatusCode - err = json.NewDecoder(resp.Body).Decode(&result) + result.HTTPStatusCode = resp.StatusCode + result.HTTPStatusText = resp.Status + err = json.NewDecoder(resp.Body).Decode(&result.Response) if err != nil { err = fmt.Errorf("cannot decode response: %s", err) - return - } - if resp.StatusCode != http.StatusOK { + } else if resp.StatusCode != http.StatusOK { err = fmt.Errorf("HTTP %d %s", resp.StatusCode, resp.Status) - return + } else if h, _ := result.Response["health"].(string); h != "OK" { + if e, ok := result.Response["error"].(string); ok && e != "" { + err = errors.New(e) + } else { + err = fmt.Errorf("health=%q in ping response", h) + } } return } -func (agg *Aggregator) checkAuth(req *http.Request, cluster *arvados.Cluster) bool { - creds := auth.NewCredentialsFromHTTPRequest(req) +func (agg *Aggregator) checkAuth(req *http.Request) bool { + creds := auth.CredentialsFromRequest(req) for _, token := range creds.Tokens { - if token != "" && token == cluster.ManagementToken { + if token != "" && token == agg.Cluster.ManagementToken { return true } }