X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/f04a6c74663185addff5564b47db0442679de78e..d084ca24b06c598271844d2ba4c8c40f251c0999:/apps/workbench/test/integration/collections_test.rb diff --git a/apps/workbench/test/integration/collections_test.rb b/apps/workbench/test/integration/collections_test.rb index 8190b35f00..8619858dfe 100644 --- a/apps/workbench/test/integration/collections_test.rb +++ b/apps/workbench/test/integration/collections_test.rb @@ -1,3 +1,7 @@ +# Copyright (C) The Arvados Authors. All rights reserved. +# +# SPDX-License-Identifier: AGPL-3.0 + require 'integration_helper' require_relative 'integration_test_utils' @@ -89,11 +93,11 @@ class CollectionsTest < ActionDispatch::IntegrationTest assert(page.has_text?(foo_collection['uuid']), "Collection page did not include foo file") assert(page.has_text?(bar_collection['uuid']), "Collection page did not include bar file") - within('tr', text: foo_collection['uuid']) do + within "tr[data-object-uuid=\"#{foo_collection['uuid']}\"]" do find('input[type=checkbox]').click end - within('tr', text: bar_collection['uuid']) do + within "tr[data-object-uuid=\"#{bar_collection['uuid']}\"]" do find('input[type=checkbox]').click end @@ -298,4 +302,210 @@ class CollectionsTest < ActionDispatch::IntegrationTest # Make sure we're not still on the old collection page. refute_match(%r{/collections/#{col['uuid']}}, page.current_url) end + + test "remove a file from collection using checkbox and dropdown option" do + need_selenium 'to confirm unlock' + + visit page_with_token('active', '/collections/zzzzz-4zz18-a21ux3541sxa8sf') + assert(page.has_text?('file1'), 'file not found - file1') + + unlock_collection + + # remove first file + input_files = page.all('input[type=checkbox]') + input_files[0].click + + click_button 'Selection...' + within('.selection-action-container') do + click_link 'Remove selected files' + end + + assert(page.has_no_text?('file1'), 'file found - file') + assert(page.has_text?('file2'), 'file not found - file2') + end + + test "remove a file in collection using trash icon" do + need_selenium 'to confirm unlock' + + visit page_with_token('active', '/collections/zzzzz-4zz18-a21ux3541sxa8sf') + assert(page.has_text?('file1'), 'file not found - file1') + + unlock_collection + + first('.fa-trash-o').click + accept_alert + + assert(page.has_no_text?('file1'), 'file found - file') + assert(page.has_text?('file2'), 'file not found - file2') + end + + test "rename a file in collection" do + need_selenium 'to confirm unlock' + + visit page_with_token('active', '/collections/zzzzz-4zz18-a21ux3541sxa8sf') + + unlock_collection + + within('.collection_files') do + first('.fa-pencil').click + find('.editable-input input').set('file1renamed') + find('.editable-submit').click + end + + assert(page.has_text?('file1renamed'), 'file not found - file1renamed') + end + + test "remove/rename file options not presented if user cannot update a collection" do + # visit a publicly accessible collection as 'spectator' + visit page_with_token('spectator', '/collections/zzzzz-4zz18-uukreo9rbgwsujr') + + click_button 'Selection' + within('.selection-action-container') do + assert_selector 'li', text: 'Create new collection with selected files' + assert_no_selector 'li', text: 'Remove selected files' + end + + within('.collection_files') do + assert(page.has_text?('GNU_General_Public_License'), 'file not found - GNU_General_Public_License') + assert_nil first('.fa-pencil') + assert_nil first('.fa-trash-o') + end + end + + test "unlock collection to modify files" do + need_selenium 'to confirm remove' + + collection = api_fixture('collections')['collection_owned_by_active'] + + # On load, collection is locked, and upload tab, rename and remove options are disabled + visit page_with_token('active', "/collections/#{collection['uuid']}") + + assert_selector 'a[data-toggle="disabled"]', text: 'Upload' + + within('.collection_files') do + file_ctrls = page.all('.btn-collection-file-control') + assert_equal 2, file_ctrls.size + assert_equal true, file_ctrls[0]['class'].include?('disabled') + assert_equal true, file_ctrls[1]['class'].include?('disabled') + find('input[type=checkbox]').click + end + + click_button 'Selection' + within('.selection-action-container') do + assert_selector 'li.disabled', text: 'Remove selected files' + assert_selector 'li', text: 'Create new collection with selected files' + end + + unlock_collection + + assert_no_selector 'a[data-toggle="disabled"]', text: 'Upload' + assert_selector 'a', text: 'Upload' + + within('.collection_files') do + file_ctrls = page.all('.btn-collection-file-control') + assert_equal 2, file_ctrls.size + assert_equal false, file_ctrls[0]['class'].include?('disabled') + assert_equal false, file_ctrls[1]['class'].include?('disabled') + + # previous checkbox selection won't result in firing a new event; + # undo and redo checkbox to fire the selection event again + find('input[type=checkbox]').click + find('input[type=checkbox]').click + end + + click_button 'Selection' + within('.selection-action-container') do + assert_no_selector 'li.disabled', text: 'Remove selected files' + assert_selector 'li', text: 'Remove selected files' + end + end + + def unlock_collection + first('.lock-collection-btn').click + accept_alert + end + + test "collection tags tab" do + visit page_with_token('active', '/collections/zzzzz-4zz18-bv31uwvy3neko21') + + click_link 'Tags' + wait_for_ajax + + # verify initial state + assert_selector 'a', text: 'Edit' + assert_no_selector 'a', text: 'Add new tag' + assert_no_selector 'a', text: 'Save' + assert_no_selector 'a', text: 'Cancel' + + # Verify controls in edit mode + first('.edit-collection-tags').click + assert_selector 'a.disabled', text: 'Edit' + assert_selector 'a', text: 'Add new tag' + assert_selector 'a', text: 'Save' + assert_selector 'a', text: 'Cancel' + + # add two tags + first('.glyphicon-plus').click + first('.collection-tag-field-key').click + first('.collection-tag-field-key').set('key 1') + first('.collection-tag-field-value').click + first('.collection-tag-field-value').set('value 1') + + first('.glyphicon-plus').click + editable_key_fields = page.all('.collection-tag-field-key') + editable_key_fields[1].click + editable_key_fields[1].set('key 2') + editable_val_fields = page.all('.collection-tag-field-value') + editable_val_fields[1].click + editable_val_fields[1].set('value 2') + + click_on 'Save' + wait_for_ajax + + # added tags; verify + assert_text 'key 1' + assert_text 'value 1' + assert_text 'key 2' + assert_text 'value 2' + assert_selector 'a', text: 'Edit' + assert_no_selector 'a', text: 'Save' + + # remove first tag + first('.edit-collection-tags').click + assert_not_nil first('.glyphicon-remove') + first('.glyphicon-remove').click + click_on 'Save' + wait_for_ajax + + assert_text 'key 2' + assert_text 'value 2' + assert_no_text 'key 1' + assert_no_text 'value 1' + assert_selector 'a', text: 'Edit' + + # Click on cancel and verify + first('.edit-collection-tags').click + first('.collection-tag-field-key').click + first('.collection-tag-field-key').set('this key wont stick') + first('.collection-tag-field-value').click + first('.collection-tag-field-value').set('this value wont stick') + + click_on 'Cancel' + wait_for_ajax + + assert_text 'key 2' + assert_text 'value 2' + assert_no_text 'this key wont stick' + assert_no_text 'this value wont stick' + + # remove all tags + first('.edit-collection-tags').click + first('.glyphicon-remove').click + click_on 'Save' + wait_for_ajax + + assert_selector 'a', text: 'Edit' + assert_no_text 'key 2' + assert_no_text 'value 2' + end end