X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/eb66b34d22cef6c98ad9ebdc228cf784b3136b72..f672f727fe79bf6642a2daab641a1ef5c84648df:/services/ws/event_source.go diff --git a/services/ws/event_source.go b/services/ws/event_source.go index edeb647e46..309dab7a40 100644 --- a/services/ws/event_source.go +++ b/services/ws/event_source.go @@ -8,7 +8,6 @@ import ( "context" "database/sql" "strconv" - "strings" "sync" "sync/atomic" "time" @@ -17,21 +16,6 @@ import ( "github.com/lib/pq" ) -type pgConfig map[string]string - -func (c pgConfig) ConnectionString() string { - s := "" - for k, v := range c { - s += k - s += "='" - s += strings.Replace( - strings.Replace(v, `\`, `\\`, -1), - `'`, `\'`, -1) - s += "' " - } - return s -} - type pgEventSource struct { DataSource string MaxOpenConns int @@ -248,7 +232,8 @@ func (ps *pgEventSource) DB() *sql.DB { } func (ps *pgEventSource) DBHealth() error { - ctx, _ := context.WithDeadline(context.Background(), time.Now().Add(time.Second)) + ctx, cancel := context.WithDeadline(context.Background(), time.Now().Add(time.Second)) + defer cancel() var i int return ps.db.QueryRowContext(ctx, "SELECT 1").Scan(&i) } @@ -287,7 +272,7 @@ func (sink *pgEventSink) Stop() { // Ensure this sink cannot fill up and block the // server-side queue (which otherwise could in turn // block our mtx.Lock() here) - for _ = range sink.channel { + for range sink.channel { } }() sink.source.mtx.Lock()