X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/ead22eaffc696e9619d0ba7a71c8d54099200685..1e1abe6a0146d3f31836334a7e5880e349afed24:/src/store/collections/collection-copy-actions.ts diff --git a/src/store/collections/collection-copy-actions.ts b/src/store/collections/collection-copy-actions.ts index e5a6676c6b..cf87f3f104 100644 --- a/src/store/collections/collection-copy-actions.ts +++ b/src/store/collections/collection-copy-actions.ts @@ -4,7 +4,7 @@ import { Dispatch } from "redux"; import { dialogActions } from "~/store/dialog/dialog-actions"; -import { initialize, startSubmit, stopSubmit } from 'redux-form'; +import { FormErrors, initialize, startSubmit, stopSubmit } from 'redux-form'; import { resetPickerProjectTree } from '~/store/project-tree-picker/project-tree-picker-actions'; import { RootState } from '~/store/store'; import { ServiceRepository } from '~/services/services'; @@ -28,23 +28,23 @@ export const copyCollection = (resource: CopyFormDialogData) => async (dispatch: Dispatch, getState: () => RootState, services: ServiceRepository) => { dispatch(startSubmit(COLLECTION_COPY_FORM_NAME)); try { - dispatch(progressIndicatorActions.START_WORKING(COLLECTION_COPY_FORM_NAME)); const collection = await services.collectionService.get(resource.uuid); - const uuidKey = 'uuid'; - delete collection[uuidKey]; const newCollection = await services.collectionService.create({ ...collection, ownerUuid: resource.ownerUuid, name: resource.name }); dispatch(dialogActions.CLOSE_DIALOG({ id: COLLECTION_COPY_FORM_NAME })); - dispatch(progressIndicatorActions.STOP_WORKING(COLLECTION_COPY_FORM_NAME)); return newCollection; } catch (e) { const error = getCommonResourceServiceError(e); - if (error === CommonResourceServiceError.UNIQUE_VIOLATION) { - dispatch(stopSubmit(COLLECTION_COPY_FORM_NAME, { ownerUuid: 'A collection with the same name already exists in the target project.' })); + if (error === CommonResourceServiceError.UNIQUE_NAME_VIOLATION) { + dispatch(stopSubmit( + COLLECTION_COPY_FORM_NAME, + { ownerUuid: 'A collection with the same name already exists in the target project.' } as FormErrors + )); } else { dispatch(dialogActions.CLOSE_DIALOG({ id: COLLECTION_COPY_FORM_NAME })); throw new Error('Could not copy the collection.'); } - dispatch(progressIndicatorActions.STOP_WORKING(COLLECTION_COPY_FORM_NAME)); return; + } finally { + dispatch(progressIndicatorActions.STOP_WORKING(COLLECTION_COPY_FORM_NAME)); } };