X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/e8d1a643cdbc3a5f4c0e5c745da58d9f7e1248d8..bf521e2fd9fae16bf5738f988496a3dbb1e32833:/services/api/test/unit/arvados_model_test.rb diff --git a/services/api/test/unit/arvados_model_test.rb b/services/api/test/unit/arvados_model_test.rb index 64f7807135..341a8462dd 100644 --- a/services/api/test/unit/arvados_model_test.rb +++ b/services/api/test/unit/arvados_model_test.rb @@ -8,20 +8,20 @@ class ArvadosModelTest < ActiveSupport::TestCase fixtures :all def create_with_attrs attrs - a = Specimen.create({material: 'caloric'}.merge(attrs)) + a = Collection.create({properties: {'foo' => 'bar'}}.merge(attrs)) a if a.valid? end test 'non-admin cannot assign uuid' do set_user_from_auth :active_trustedclient - want_uuid = Specimen.generate_uuid + want_uuid = Collection.generate_uuid a = create_with_attrs(uuid: want_uuid) assert_nil a, "Non-admin should not assign uuid." end test 'admin can assign valid uuid' do set_user_from_auth :admin_trustedclient - want_uuid = Specimen.generate_uuid + want_uuid = Collection.generate_uuid a = create_with_attrs(uuid: want_uuid) assert_equal want_uuid, a.uuid, "Admin should assign valid uuid." assert a.uuid.length==27, "Auto assigned uuid length is wrong." @@ -29,7 +29,7 @@ class ArvadosModelTest < ActiveSupport::TestCase test 'admin cannot assign uuid with wrong object type' do set_user_from_auth :admin_trustedclient - want_uuid = Human.generate_uuid + want_uuid = Group.generate_uuid a = create_with_attrs(uuid: want_uuid) assert_nil a, "Admin should not be able to assign invalid uuid." end @@ -126,10 +126,23 @@ class ArvadosModelTest < ActiveSupport::TestCase end test "search index exists on models that go into projects" do - all_tables = ActiveRecord::Base.connection.tables - all_tables.delete 'schema_migrations' - all_tables.delete 'permission_refresh_lock' - all_tables.delete 'ar_internal_metadata' + all_tables = ActiveRecord::Base.connection.tables - [ + 'ar_internal_metadata', + 'permission_refresh_lock', + 'schema_migrations', + # tables that may still exist in the database even though model + # classes have been deleted: + 'humans', + 'jobs', + 'job_tasks', + 'keep_disks', + 'nodes', + 'pipeline_instances', + 'pipeline_templates', + 'repositories', + 'specimens', + 'traits', + ] all_tables.each do |table| table_class = table.classify.constantize @@ -155,58 +168,10 @@ class ArvadosModelTest < ActiveSupport::TestCase end end - test "full text search index exists on models" do - indexes = {} - conn = ActiveRecord::Base.connection - conn.exec_query("SELECT i.relname as indname, - i.relowner as indowner, - idx.indrelid::regclass::text as table, - am.amname as indam, - idx.indkey, - ARRAY( - SELECT pg_get_indexdef(idx.indexrelid, k + 1, true) - FROM generate_subscripts(idx.indkey, 1) as k - ORDER BY k - ) as keys, - idx.indexprs IS NOT NULL as indexprs, - idx.indpred IS NOT NULL as indpred - FROM pg_index as idx - JOIN pg_class as i - ON i.oid = idx.indexrelid - JOIN pg_am as am - ON i.relam = am.oid - JOIN pg_namespace as ns - ON ns.oid = i.relnamespace - AND ns.nspname = ANY(current_schemas(false))").each do |idx| - if idx['keys'].match(/to_tsvector/) - indexes[idx['table']] ||= [] - indexes[idx['table']] << idx - end - end - fts_tables = ["collections", "container_requests", "groups", "jobs", - "pipeline_instances", "pipeline_templates", "workflows"] - fts_tables.each do |table| - table_class = table.classify.constantize - if table_class.respond_to?('full_text_searchable_columns') - expect = table_class.full_text_searchable_columns - ok = false - indexes[table].andand.each do |idx| - if expect == idx['keys'].scan(/COALESCE\(([A-Za-z_]+)/).flatten - ok = true - end - end - assert ok, "#{table} has no full-text index\nexpect: #{expect.inspect}\nfound: #{indexes[table].inspect}" - end - end - end - [ %w[collections collections_trgm_text_search_idx], %w[container_requests container_requests_trgm_text_search_idx], %w[groups groups_trgm_text_search_idx], - %w[jobs jobs_trgm_text_search_idx], - %w[pipeline_instances pipeline_instances_trgm_text_search_idx], - %w[pipeline_templates pipeline_templates_trgm_text_search_idx], %w[workflows workflows_trgm_text_search_idx] ].each do |model| table = model[0] @@ -225,25 +190,25 @@ class ArvadosModelTest < ActiveSupport::TestCase end test "selectable_attributes includes database attributes" do - assert_includes(Job.selectable_attributes, "success") + assert_includes(Collection.selectable_attributes, "name") end test "selectable_attributes includes non-database attributes" do - assert_includes(Job.selectable_attributes, "node_uuids") + assert_includes(Collection.selectable_attributes, "unsigned_manifest_text") end test "selectable_attributes includes common attributes in extensions" do - assert_includes(Job.selectable_attributes, "uuid") + assert_includes(Collection.selectable_attributes, "uuid") end test "selectable_attributes does not include unexposed attributes" do - refute_includes(Job.selectable_attributes, "nodes") + refute_includes(Collection.selectable_attributes, "id") end test "selectable_attributes on a non-default template" do - attr_a = Job.selectable_attributes(:common) + attr_a = Collection.selectable_attributes(:common) assert_includes(attr_a, "uuid") - refute_includes(attr_a, "success") + refute_includes(attr_a, "name") end test 'create and retrieve using created_at time' do @@ -262,13 +227,13 @@ class ArvadosModelTest < ActiveSupport::TestCase assert group.valid?, "group is not valid" # update 1 - group.update_attributes!(name: "test create and update name 1") + group.update!(name: "test create and update name 1") results = Group.where(uuid: group.uuid) assert_equal "test create and update name 1", results.first.name, "Expected name to be updated to 1" updated_at_1 = results.first.updated_at.to_f # update 2 - group.update_attributes!(name: "test create and update name 2") + group.update!(name: "test create and update name 2") results = Group.where(uuid: group.uuid) assert_equal "test create and update name 2", results.first.name, "Expected name to be updated to 2" updated_at_2 = results.first.updated_at.to_f @@ -282,15 +247,15 @@ class ArvadosModelTest < ActiveSupport::TestCase c = Collection.create!(properties: {}) assert_equal({}, c.properties) - c.update_attributes(properties: {'foo' => 'foo'}) + c.update(properties: {'foo' => 'foo'}) c.reload assert_equal({'foo' => 'foo'}, c.properties) - c.update_attributes(properties: nil) + c.update(properties: nil) c.reload assert_equal({}, c.properties) - c.update_attributes(properties: {foo: 'bar'}) + c.update(properties: {foo: 'bar'}) assert_equal({'foo' => 'bar'}, c.properties) c.reload assert_equal({'foo' => 'bar'}, c.properties) @@ -305,19 +270,21 @@ class ArvadosModelTest < ActiveSupport::TestCase else Rails.configuration.AuditLogs.MaxAge = 0 end + tested_serialized = false [ User.find_by_uuid(users(:active).uuid), ContainerRequest.find_by_uuid(container_requests(:queued).uuid), Container.find_by_uuid(containers(:queued).uuid), - PipelineInstance.find_by_uuid(pipeline_instances(:has_component_with_completed_jobs).uuid), - PipelineTemplate.find_by_uuid(pipeline_templates(:two_part).uuid), - Job.find_by_uuid(jobs(:running).uuid) + Group.find_by_uuid(groups(:afiltergroup).uuid), + Collection.find_by_uuid(collections(:collection_with_one_property).uuid), ].each do |obj| - assert_not(obj.class.serialized_attributes.empty?, - "#{obj.class} model doesn't have serialized attributes") + if !obj.class.serialized_attributes.empty? + tested_serialized = true + end # obj shouldn't have changed since it's just retrieved from the database assert_not(obj.changed?, "#{obj.class} model's attribute(s) appear as changed: '#{obj.changes.keys.join(',')}' with audit logs #{auditlogs_enabled ? '': 'not '}enabled.") end + assert(tested_serialized, "did not test any models with serialized attributes") end end end