X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/da3017f2d1c4a6838255814a96cbb66acde14d0a..0eb72b526bf8bbb011551ecf019f604e17a534f1:/apps/workbench/test/controllers/projects_controller_test.rb diff --git a/apps/workbench/test/controllers/projects_controller_test.rb b/apps/workbench/test/controllers/projects_controller_test.rb index 6bdab55ddf..f45f178395 100644 --- a/apps/workbench/test/controllers/projects_controller_test.rb +++ b/apps/workbench/test/controllers/projects_controller_test.rb @@ -1,3 +1,7 @@ +# Copyright (C) The Arvados Authors. All rights reserved. +# +# SPDX-License-Identifier: AGPL-3.0 + require 'test_helper' require 'helpers/share_object_helper' @@ -101,8 +105,9 @@ class ProjectsControllerTest < ActionController::TestCase end test "project admin can remove collections from the project" do - # Deleting an object that supports 'expires_at' should make it - # completely inaccessible to API queries, not simply moved out of the project. + # Deleting an object that supports 'trash_at' should make it + # completely inaccessible to API queries, not simply moved out of + # the project. coll_key = "collection_to_remove_from_subproject" coll_uuid = api_fixture("collections")[coll_key]["uuid"] delete(:remove_item, @@ -116,12 +121,12 @@ class ProjectsControllerTest < ActionController::TestCase use_token :subproject_admin assert_raise ArvadosApiClient::NotFoundException do - Collection.find(coll_uuid) + Collection.find(coll_uuid, cache: false) end end test "project admin can remove items from project other than collections" do - # An object which does not have an expired_at field (e.g. Specimen) + # An object which does not have an trash_at field (e.g. Specimen) # should be implicitly moved to the user's Home project when removed. specimen_uuid = api_fixture('specimens', 'in_asubproject')['uuid'] delete(:remove_item, @@ -387,14 +392,80 @@ class ProjectsControllerTest < ActionController::TestCase end [ - ["jobs", "/jobs"], - ["pipelines", "/pipeline_instances"], - ["collections", "/collections"], - ].each do |target,path| - test "test dashboard button all #{target}" do - get :index, {}, session_for(:active) - assert_includes @response.body, "href=\"#{path}\"" - assert_includes @response.body, "All #{target}" + [:admin, true], + [:active, false], + ].each do |user, expect_all_nodes| + test "in dashboard other index page links as #{user}" do + get :index, {}, session_for(user) + + [["processes", "/all_processes"], + ["collections", "/collections"], + ].each do |target, path| + assert_includes @response.body, "href=\"#{path}\"" + assert_includes @response.body, "All #{target}" + end + + if expect_all_nodes + assert_includes @response.body, "href=\"/nodes\"" + assert_includes @response.body, "All nodes" + else + assert_not_includes @response.body, "href=\"/nodes\"" + assert_not_includes @response.body, "All nodes" + end + end + end + + test "dashboard should show the correct status for processes" do + get :index, {}, session_for(:active) + assert_select 'div.panel-body.recent-processes' do + [ + { + fixture: 'container_requests', + state: 'completed', + selectors: [['div.progress', false], + ['span.label.label-success', true, 'Complete']] + }, + { + fixture: 'container_requests', + state: 'uncommitted', + selectors: [['div.progress', false], + ['span.label.label-default', true, 'Uncommitted']] + }, + { + fixture: 'container_requests', + state: 'queued', + selectors: [['div.progress', false], + ['span.label.label-default', true, 'Queued']] + }, + { + fixture: 'container_requests', + state: 'running', + selectors: [['div.progress', true]] + }, + { + fixture: 'pipeline_instances', + state: 'new_pipeline', + selectors: [['div.progress', false], + ['span.label.label-default', true, 'Not started']] + }, + { + fixture: 'pipeline_instances', + state: 'pipeline_in_running_state', + selectors: [['div.progress', true]] + }, + ].each do |c| + uuid = api_fixture(c[:fixture])[c[:state]]['uuid'] + assert_select "div.dashboard-panel-info-row.row-#{uuid}" do + if c.include? :selectors + c[:selectors].each do |selector, should_show, label| + assert_select selector, should_show, "UUID #{uuid} should #{should_show ? '' : 'not'} show '#{selector}'" + if should_show and not label.nil? + assert_select selector, label, "UUID #{uuid} state label should show #{label}" + end + end + end + end + end end end @@ -421,30 +492,81 @@ class ProjectsControllerTest < ActionController::TestCase [ ["active", 5, ["aproject", "asubproject"], "anonymously_accessible_project"], - ["user1_with_load", 2, ["project_with_10_collections"], "project_with_2_pipelines_and_60_jobs"], + ["user1_with_load", 2, ["project_with_10_collections"], "project_with_2_pipelines_and_60_crs"], ["admin", 5, ["anonymously_accessible_project", "subproject_in_anonymous_accessible_project"], "aproject"], ].each do |user, page_size, tree_segment, unexpected| + # Note: this test is sensitive to database collation. It passes + # with en_US.UTF-8. test "build my projects tree for #{user} user and verify #{unexpected} is omitted" do use_token user - ctrl = ProjectsController.new - - current_user = User.find(api_fixture('users')[user]['uuid']) - my_tree = ctrl.send :my_wanted_projects_tree, current_user, page_size + tree, _, _ = @controller.send(:my_wanted_projects_tree, + User.current, + page_size) tree_segment_at_depth_1 = api_fixture('groups')[tree_segment[0]] tree_segment_at_depth_2 = api_fixture('groups')[tree_segment[1]] if tree_segment[1] - tree_nodes = {} - my_tree[0].each do |x| - tree_nodes[x[:object]['uuid']] = x[:depth] + node_depth = {} + tree.each do |x| + node_depth[x[:object]['uuid']] = x[:depth] end - assert_equal(1, tree_nodes[tree_segment_at_depth_1['uuid']]) - assert_equal(2, tree_nodes[tree_segment_at_depth_2['uuid']]) if tree_segment[1] + assert_equal(1, node_depth[tree_segment_at_depth_1['uuid']]) + assert_equal(2, node_depth[tree_segment_at_depth_2['uuid']]) if tree_segment[1] unexpected_project = api_fixture('groups')[unexpected] - assert_nil(tree_nodes[unexpected_project['uuid']]) + assert_nil(node_depth[unexpected_project['uuid']], node_depth.inspect) + end + end + + [ + ["active", 1], + ["project_viewer", 1], + ["admin", 0], + ].each do |user, size| + test "starred projects for #{user}" do + use_token user + ctrl = ProjectsController.new + current_user = User.find(api_fixture('users')[user]['uuid']) + my_starred_project = ctrl.send :my_starred_projects, current_user + assert_equal(size, my_starred_project.andand.size) + + ctrl2 = ProjectsController.new + current_user = User.find(api_fixture('users')[user]['uuid']) + my_starred_project = ctrl2.send :my_starred_projects, current_user + assert_equal(size, my_starred_project.andand.size) end end + + test "unshare project and verify that it is no longer included in shared user's starred projects" do + # remove sharing link + use_token :system_user + Link.find(api_fixture('links')['share_starred_project_with_project_viewer']['uuid']).destroy + + # verify that project is no longer included in starred projects + use_token :project_viewer + current_user = User.find(api_fixture('users')['project_viewer']['uuid']) + ctrl = ProjectsController.new + my_starred_project = ctrl.send :my_starred_projects, current_user + assert_equal(0, my_starred_project.andand.size) + + # share it again + @controller = LinksController.new + post :create, { + link: { + link_class: 'permission', + name: 'can_read', + head_uuid: api_fixture('groups')['starred_and_shared_active_user_project']['uuid'], + tail_uuid: api_fixture('users')['project_viewer']['uuid'], + }, + format: :json + }, session_for(:system_user) + + # verify that the project is again included in starred projects + use_token :project_viewer + ctrl = ProjectsController.new + my_starred_project = ctrl.send :my_starred_projects, current_user + assert_equal(1, my_starred_project.andand.size) + end end