X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/d77c5b5925be6182430da592dedeeaaf05558554..4d56f9b913fcf41fbf89bf5016463b5353fa3a9f:/services/api/test/functional/application_controller_test.rb diff --git a/services/api/test/functional/application_controller_test.rb b/services/api/test/functional/application_controller_test.rb index d382c1c6a6..175a8f71ea 100644 --- a/services/api/test/functional/application_controller_test.rb +++ b/services/api/test/functional/application_controller_test.rb @@ -25,13 +25,15 @@ class ApplicationControllerTest < ActionController::TestCase assert_operator(token_time, :>=, @start_stamp, "error token too old") assert_operator(token_time, :<=, now_timestamp, "error token too new") json_response['errors'].each do |err| - assert_match(/req-[a-z0-9]{20}/, err) + assert_match(/req-[a-z0-9]{20}/, err, "X-Request-Id value missing on error message") end end def check_404(errmsg="Path not found") assert_response 404 - assert_includes(json_response['errors'].first, errmsg) + json_response['errors'].each do |err| + assert(err.include?(errmsg), "error message '#{err}' expected to include '#{errmsg}'") + end check_error_token end @@ -119,4 +121,16 @@ class ApplicationControllerTest < ActionController::TestCase end end end + + test "exceptions with backtraces get logged at exception_backtrace key" do + Group.stubs(:new).raises(Exception, 'Whoops') + Rails.logger.expects(:info).with(any_parameters) do |param| + param.include?('Whoops') and param.include?('"exception_backtrace":') + end + @controller = Arvados::V1::GroupsController.new + authorize_with :active + post :create, params: { + group: {}, + } + end end