X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/d71d4273d1f3d0b6381efafa649b81c6b4107cf1..554dc3c84338223df363a05a215919f7af90fc6a:/lib/boot/postgresql.go diff --git a/lib/boot/postgresql.go b/lib/boot/postgresql.go index daa0414a3c..d105b0b623 100644 --- a/lib/boot/postgresql.go +++ b/lib/boot/postgresql.go @@ -60,6 +60,7 @@ func (runPostgreSQL) Run(ctx context.Context, fail func(error), super *Superviso return err } prog, args := filepath.Join(bindir, "initdb"), []string{"-D", datadir, "-E", "utf8"} + opts := runOptions{} if iamroot { postgresUser, err := user.Lookup("postgres") if err != nil { @@ -85,15 +86,9 @@ func (runPostgreSQL) Run(ctx context.Context, fail func(error), super *Superviso if err != nil { return err } - // We can't use "sudo -u" here because it creates an - // intermediate process that interferes with our - // ability to reliably kill postgres. The setuidgid - // program just calls exec without forking, so it - // doesn't have this problem. - args = append([]string{"postgres", prog}, args...) - prog = "setuidgid" - } - err = super.RunProgram(ctx, super.tempdir, runOptions{}, prog, args...) + opts.user = "postgres" + } + err = super.RunProgram(ctx, super.tempdir, opts, prog, args...) if err != nil { return err } @@ -118,13 +113,14 @@ func (runPostgreSQL) Run(ctx context.Context, fail func(error), super *Superviso "-l", // enable ssl "-D", datadir, // data dir "-k", datadir, // socket dir + "-h", super.cluster.PostgreSQL.Connection["host"], "-p", super.cluster.PostgreSQL.Connection["port"], } + opts := runOptions{} if iamroot { - args = append([]string{"postgres", prog}, args...) - prog = "setuidgid" + opts.user = "postgres" } - fail(super.RunProgram(ctx, super.tempdir, runOptions{}, prog, args...)) + fail(super.RunProgram(ctx, super.tempdir, opts, prog, args...)) }() for {