X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/d585a31fb1a2b2c4964ff2c8928a42358e8a060f..6f7456f84209e9bf5955ba4158c4ce673d876be0:/apps/workbench/test/integration/projects_test.rb diff --git a/apps/workbench/test/integration/projects_test.rb b/apps/workbench/test/integration/projects_test.rb index c0443cc46c..0ca0a78b41 100644 --- a/apps/workbench/test/integration/projects_test.rb +++ b/apps/workbench/test/integration/projects_test.rb @@ -16,8 +16,8 @@ class ProjectsTest < ActionDispatch::IntegrationTest test 'Find a project and edit its description' do visit page_with_token 'active', '/' - find('.arv-project-list a,button', text: 'A Project'). - click + find("#projects-menu").click + find(".dropdown-menu a", text: "A Project").click within('.container-fluid', text: api_fixture('groups')['aproject']['name']) do find('span', text: api_fixture('groups')['aproject']['name']).click within('.arv-description-as-subtitle') do @@ -34,8 +34,8 @@ class ProjectsTest < ActionDispatch::IntegrationTest test 'Find a project and edit description to textile description' do visit page_with_token 'active', '/' - find('.arv-project-list a,button', text: 'A Project'). - click + find("#projects-menu").click + find(".dropdown-menu a", text: "A Project").click within('.container-fluid', text: api_fixture('groups')['aproject']['name']) do find('span', text: api_fixture('groups')['aproject']['name']).click within('.arv-description-as-subtitle') do @@ -59,17 +59,13 @@ class ProjectsTest < ActionDispatch::IntegrationTest click_link 'take me home' # now in dashboard - assert(page.has_text?('My projects'), 'My projects - not found on dashboard') - assert(page.has_text?('Projects shared with me'), 'Projects shared with me - not found on dashboard') - assert(page.has_text?('Textile description for A project'), "Project description not found") - assert(page.has_no_text?('*Textile description for A project*'), "Project description is not rendered properly in dashboard") - assert(page.has_no_text?('And a new paragraph in description'), "Project description is not truncated after first paragraph") + assert(page.has_text?('Active pipelines'), 'Active pipelines - not found on dashboard') end test 'Find a project and edit description to html description' do visit page_with_token 'active', '/' - find('.arv-project-list a,button', text: 'A Project'). - click + find("#projects-menu").click + find(".dropdown-menu a", text: "A Project").click within('.container-fluid', text: api_fixture('groups')['aproject']['name']) do find('span', text: api_fixture('groups')['aproject']['name']).click within('.arv-description-as-subtitle') do @@ -86,14 +82,13 @@ class ProjectsTest < ActionDispatch::IntegrationTest "Textile description is displayed with uninterpreted formatting characters") assert(page.has_link?("take me home"),"link not found in description") click_link 'take me home' - assert page.has_text?('My projects') - assert page.has_text?('Projects shared with me') + assert page.has_text?('Active pipelines') end test 'Find a project and edit description to textile description with link to object' do visit page_with_token 'active', '/' - find('.arv-project-list a,button', text: 'A Project'). - click + find("#projects-menu").click + find(".dropdown-menu a", text: "A Project").click within('.container-fluid', text: api_fixture('groups')['aproject']['name']) do find('span', text: api_fixture('groups')['aproject']['name']).click within('.arv-description-as-subtitle') do @@ -143,7 +138,9 @@ class ProjectsTest < ActionDispatch::IntegrationTest test 'Create a project and move it into a different project' do visit page_with_token 'active', '/projects' - find('.btn', text: "Add new project").click + find("#projects-menu").click + find(".dropdown-menu a", text: "Home").click + find('.btn', text: "Add a subproject").click # within('.editable', text: 'New project') do within('h2') do @@ -154,7 +151,9 @@ class ProjectsTest < ActionDispatch::IntegrationTest wait_for_ajax visit '/projects' - find('.btn', text: "Add new project").click + find("#projects-menu").click + find(".dropdown-menu a", text: "Home").click + find('.btn', text: "Add a subproject").click within('h2') do find('.fa-pencil').click find('.editable-input input').set('Project 5678') @@ -162,7 +161,7 @@ class ProjectsTest < ActionDispatch::IntegrationTest end wait_for_ajax - click_link 'Move to project...' + click_link 'Move project...' find('.selectable', text: 'Project 1234').click find('.modal-footer a,button', text: 'Move').click wait_for_ajax @@ -267,22 +266,24 @@ class ProjectsTest < ActionDispatch::IntegrationTest end [ - 'Move', - 'Remove', - 'Copy', - ].each do |action| - test "selection #{action} for project" do - src = api_fixture('groups')['aproject'] - dest = api_fixture('groups')['asubproject'] - my_collection = api_fixture('collections')['collection_to_move_around_in_aproject'] - + ['Move',api_fixture('collections')['collection_to_move_around_in_aproject'], + api_fixture('groups')['aproject'],api_fixture('groups')['asubproject']], + ['Remove',api_fixture('collections')['collection_to_move_around_in_aproject'], + api_fixture('groups')['aproject']], + ['Copy',api_fixture('collections')['collection_to_move_around_in_aproject'], + api_fixture('groups')['aproject'],api_fixture('groups')['asubproject']], + ['Remove',api_fixture('collections')['collection_in_aproject_with_same_name_as_in_home_project'], + api_fixture('groups')['aproject'],nil,true], + ].each do |action, my_collection, src, dest=nil, expect_name_change=nil| + test "selection #{action} #{expect_name_change} for project" do perform_selection_action src, dest, my_collection, action case action when 'Copy' assert page.has_text?(my_collection['name']), 'Collection not found in src project after copy' visit page_with_token 'active', '/' - find('.arv-project-list a,button', text: dest['name']).click + find("#projects-menu").click + find(".dropdown-menu a", text: dest['name']).click assert page.has_text?(my_collection['name']), 'Collection not found in dest project after copy' # now remove it from destination project to restore to original state @@ -290,7 +291,8 @@ class ProjectsTest < ActionDispatch::IntegrationTest when 'Move' assert page.has_no_text?(my_collection['name']), 'Collection still found in src project after move' visit page_with_token 'active', '/' - find('.arv-project-list a,button', text: dest['name']).click + find("#projects-menu").click + find(".dropdown-menu a", text: dest['name']).click assert page.has_text?(my_collection['name']), 'Collection not found in dest project after move' # move it back to src project to restore to original state @@ -298,15 +300,21 @@ class ProjectsTest < ActionDispatch::IntegrationTest when 'Remove' assert page.has_no_text?(my_collection['name']), 'Collection still found in src project after remove' visit page_with_token 'active', '/' - find('.arv-project-list a,button', text: 'Home').click + find("#projects-menu").click + find(".dropdown-menu a", text: "Home").click assert page.has_text?(my_collection['name']), 'Collection not found in home project after remove' + if expect_name_change + assert page.has_text?(my_collection['name']+' removed from ' + src['name']), + 'Collection with update name is not found in home project after remove' + end end end end def perform_selection_action src, dest, item, action visit page_with_token 'active', '/' - find('.arv-project-list a,button', text: src['name']).click + find("#projects-menu").click + find(".dropdown-menu a", text: src['name']).click assert page.has_text?(item['name']), 'Collection not found in src project' within('tr', text: item['name']) do @@ -342,7 +350,8 @@ class ProjectsTest < ActionDispatch::IntegrationTest # verify that selection options are disabled on the project until an item is selected visit page_with_token 'active', '/' - find('.arv-project-list a,button', text: my_project['name']).click + find("#projects-menu").click + find(".dropdown-menu a", text: my_project['name']).click click_button 'Selection...' within('.selection-action-container') do @@ -355,7 +364,8 @@ class ProjectsTest < ActionDispatch::IntegrationTest # select collection and verify links are enabled visit page_with_token 'active', '/' - find('.arv-project-list a,button', text: my_project['name']).click + find("#projects-menu").click + find(".dropdown-menu a", text: my_project['name']).click assert page.has_text?(my_collection['name']), 'Collection not found in project' within('tr', text: my_collection['name']) do @@ -377,7 +387,8 @@ class ProjectsTest < ActionDispatch::IntegrationTest # select subproject and verify that copy action is disabled visit page_with_token 'active', '/' - find('.arv-project-list a,button', text: my_project['name']).click + find("#projects-menu").click + find(".dropdown-menu a", text: my_project['name']).click click_link 'Subprojects' assert page.has_text?(my_subproject['name']), 'Subproject not found in project' @@ -399,7 +410,8 @@ class ProjectsTest < ActionDispatch::IntegrationTest # select subproject and a collection and verify that copy action is still disabled visit page_with_token 'active', '/' - find('.arv-project-list a,button', text: my_project['name']).click + find("#projects-menu").click + find(".dropdown-menu a", text: my_project['name']).click click_link 'Subprojects' assert page.has_text?(my_subproject['name']), 'Subproject not found in project' @@ -427,26 +439,174 @@ class ProjectsTest < ActionDispatch::IntegrationTest end end - test "combine selected collections into new collection" do - my_project = api_fixture('groups')['aproject'] - my_collection = api_fixture('collections')['collection_to_move_around_in_aproject'] + [ + ['active', true], + ['project_viewer', false], + ].each do |user, expect_collection_in_aproject| + test "combine selected collections into new collection #{user} #{expect_collection_in_aproject}" do + my_project = api_fixture('groups')['aproject'] + my_collection = api_fixture('collections')['collection_to_move_around_in_aproject'] - visit page_with_token 'active', '/' - find('.arv-project-list a,button', text: my_project['name']).click - assert page.has_text?(my_collection['name']), 'Collection not found in project' + visit page_with_token user, '/' + find("#projects-menu").click + find(".dropdown-menu a", text: my_project['name']).click + assert page.has_text?(my_collection['name']), 'Collection not found in project' - within('tr', text: my_collection['name']) do - find('input[type=checkbox]').click + within('tr', text: my_collection['name']) do + find('input[type=checkbox]').click + end + + click_button 'Selection...' + within('.selection-action-container') do + click_link 'Create new collection with selected collections' + end + + # now in the new collection page + if expect_collection_in_aproject + assert page.has_text?("Created new collection in the project #{my_project['name']}"), + 'Not found flash message that new collection is created in aproject' + else + assert page.has_text?("Created new collection in your Home project"), + 'Not found flash message that new collection is created in Home project' + end + assert page.has_text?('Content hash'), 'Not found content hash in collection page' end + end - click_button 'Selection...' - within('.selection-action-container') do - click_link 'Create new collection with selected collections' + [ + ["jobs", "/jobs"], + ["pipelines", "/pipeline_instances"], + ["collections", "/collections"] + ].each do |target,path| + test "Test dashboard button all #{target}" do + visit page_with_token 'active', '/' + click_link "All #{target}" + assert_equal path, current_path + end + end + + [ + ['project with 10 collections', 10], + ['project with 201 collections', 201], # two pages of data + ].each do |project_name, amount| + test "scroll collections tab for #{project_name} with #{amount} objects" do + visit page_with_token 'user1_with_load' + + find("#projects-menu").click + find(".dropdown-menu a", text: project_name).click + + my_collections = [] + for i in 1..amount + my_collections << "Collection_#{i}" + end + + # verify Data collections scroll + assert(page.has_text?("Data collections (#{amount})"), "Number of collections did not match the input amount") + + click_link 'Data collections' + begin + wait_for_ajax + rescue + end + + verify_collections = my_collections.dup + unexpected_items = [] + collections_count = 0 + within('.arv-project-Data_collections') do + scrollbar_present = page.execute_script("return document.documentElement.scrollHeight>document.documentElement.clientHeight;"); + if scrollbar_present + page.execute_script "window.scrollBy(0,10000)" + begin + wait_for_ajax + rescue + end + end + + # Visit all rows. If not all expected collections are found, retry + found_collections = page.all('tr[data-kind="arvados#collection"]') + collections_count = found_collections.count + + (0..collections_count-1).each do |i| + # Found row text would be of the format "Show Collection_#{n} " + collection_name = found_collections[i].text.split[1] + if !my_collections.include? collection_name + unexpected_items << collection_name + else + verify_collections.delete collection_name + end + end + + assert_equal true, unexpected_items.empty?, "Found unexpected items #{unexpected_items.inspect}" + if amount > 200 + assert_equal 200, collections_count, "Found different number of collections" + assert_equal amount-200, verify_collections.length, "Did not find all the collections" + else + assert_equal amount, collections_count, "Found different number of collections" + assert_equal true, verify_collections.empty?, "Did not find all the collections" + end + end end + end - # back in project page - assert page.has_text?(my_collection['name']), 'Collection not found in project' - assert page.has_link?('Jobs and pipelines'), 'Jobs and pipelines link not found in project' + [ + ['project with 10 pipelines', 10, 0], + ['project with 20 pipelines and jobs', 20, 20], +# ['project with 250 pipelines', 250, 0], + ].each do |project_name, num_pipelines, num_jobs| + test "scroll pipeline instances tab for #{project_name} with #{num_pipelines} pipelines and #{num_jobs} jobs" do + visit page_with_token 'user1_with_load' + + find("#projects-menu").click + find(".dropdown-menu a", text: project_name).click + + my_pipelines = [] + (1..num_pipelines).each do |i| + name = "pipeline_#{i}" + my_pipelines << name + end + + # verify Jobs and pipelines tab scroll + assert(page.has_text?("Jobs and pipelines (#{num_pipelines+num_jobs})"), "Number of objects did not match the input counts") + click_link 'Jobs and pipelines' + begin + wait_for_ajax + rescue + end + + verify_pipelines = my_pipelines.dup + unexpected_items = [] + object_count = 0 + within('.arv-project-Jobs_and_pipelines') do + scrollbar_present = page.execute_script("return document.documentElement.scrollHeight>document.documentElement.clientHeight;"); + if scrollbar_present + page.execute_script "window.scrollBy(0,10000)" + begin + wait_for_ajax + rescue + end + end + + # Visit all rows. Repeat if not all expected my_pipelines are found (inifinite scrolling should kick in) + pipelines_found = page.all('tr[data-kind="arvados#pipelineInstance"]') + pipeline_count = pipelines_found.count + (0..pipeline_count-1).each do |i| + name = pipelines_found[i].text.split[1] + if !my_pipelines.include? name + unexpected_items << name + else + verify_pipelines.delete name + end + + assert_equal true, unexpected_items.empty?, "Found unexpected items #{unexpected_items.inspect}" + end + assert_equal num_pipelines, pipeline_count, "Found different number of pipelines" + assert_equal true, verify_pipelines.empty?, "Did not find all the pipelines" + + jobs_found = page.all('tr[data-kind="arvados#job"]') + job_count = jobs_found.count + assert_equal num_jobs, job_count, 'Did not find expected number of jobs' + end + end end end