X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/cebc9af013fbe65d83cb4a60813e3d1871f7ca3a..89be4b30feccc3680ca77339711b29367754dc05:/services/fuse/arvados_fuse/command.py diff --git a/services/fuse/arvados_fuse/command.py b/services/fuse/arvados_fuse/command.py index fff0c99a8e..f174d1bb02 100644 --- a/services/fuse/arvados_fuse/command.py +++ b/services/fuse/arvados_fuse/command.py @@ -1,3 +1,7 @@ +# Copyright (C) The Arvados Authors. All rights reserved. +# +# SPDX-License-Identifier: AGPL-3.0 + import argparse import arvados import daemon @@ -11,7 +15,9 @@ import sys import time import arvados.commands._util as arv_cmd +from arvados_fuse import crunchstat from arvados_fuse import * +from arvados_fuse.unmount import unmount from arvados_fuse._version import __version__ class ArgumentParser(argparse.ArgumentParser): @@ -89,10 +95,13 @@ class ArgumentParser(argparse.ArgumentParser): self.add_argument('--crunchstat-interval', type=float, help="Write stats to stderr every N seconds (default disabled)", default=0) - self.add_argument('--unmount', action='store_true', default=False, - help="Forcefully unmount the specified mountpoint (if it's a fuse mount) and exit. Use /path/... to unmount all fuse mounts below /path as well as /path itself.") - self.add_argument('--replace', action='store_true', default=False, - help="If a fuse mount is already present at mountpoint, forcefully unmount it before mounting") + unmount = self.add_mutually_exclusive_group() + unmount.add_argument('--unmount', action='store_true', default=False, + help="Forcefully unmount the specified mountpoint (if it's a fuse mount) and exit. If --subtype is given, unmount only if the mount has the specified subtype. WARNING: This command can affect any kind of fuse mount, not just arv-mount.") + unmount.add_argument('--unmount-all', action='store_true', default=False, + help="Forcefully unmount every fuse mount at or below the specified path and exit. If --subtype is given, unmount only mounts that have the specified subtype. Exit non-zero if any other types of mounts are found at or below the given path. WARNING: This command can affect any kind of fuse mount, not just arv-mount.") + unmount.add_argument('--replace', action='store_true', default=False, + help="If a fuse mount is already present at mountpoint, forcefully unmount it before mounting") self.add_argument('--unmount-timeout', type=float, default=2.0, help="Time to wait for graceful shutdown after --exec program exits and filesystem is unmounted") @@ -104,6 +113,7 @@ class ArgumentParser(argparse.ArgumentParser): class Mount(object): def __init__(self, args, logger=logging.getLogger('arvados.arv-mount')): + self.daemon = False self.logger = logger self.args = args self.listen_for_events = False @@ -122,8 +132,15 @@ class Mount(object): def __enter__(self): if self.args.replace: - unmount(self.args.mountpoint, timeout=self.args.unmount_timeout) + unmount(path=self.args.mountpoint, + timeout=self.args.unmount_timeout) llfuse.init(self.operations, self.args.mountpoint, self._fuse_options()) + if self.daemon: + daemon.DaemonContext( + working_directory=os.path.dirname(self.args.mountpoint), + files_preserve=range( + 3, resource.getrlimit(resource.RLIMIT_NOFILE)[1]) + ).open() if self.listen_for_events and not self.args.disable_event_listening: self.operations.listen_for_events() self.llfuse_thread = threading.Thread(None, lambda: self._llfuse_main()) @@ -144,8 +161,11 @@ class Mount(object): self.args.unmount_timeout) def run(self): - if self.args.unmount: - unmount_all(self.args.mountpoint, timeout=self.args.unmount_timeout) + if self.args.unmount or self.args.unmount_all: + unmount(path=self.args.mountpoint, + subtype=self.args.subtype, + timeout=self.args.unmount_timeout, + recursive=self.args.unmount_all) elif self.args.exec_args: self._run_exec() else: @@ -182,15 +202,20 @@ class Mount(object): logging.getLogger('arvados.collection').setLevel(logging.DEBUG) self.logger.debug("arv-mount debugging enabled") + self.logger.info("%s %s started", sys.argv[0], __version__) self.logger.info("enable write is %s", self.args.enable_write) def _setup_api(self): - self.api = arvados.safeapi.ThreadSafeApiCache( - apiconfig=arvados.config.settings(), - keep_params={ - 'block_cache': arvados.keep.KeepBlockCache(self.args.file_cache), - 'num_retries': self.args.retries, - }) + try: + self.api = arvados.safeapi.ThreadSafeApiCache( + apiconfig=arvados.config.settings(), + keep_params={ + 'block_cache': arvados.keep.KeepBlockCache(self.args.file_cache), + 'num_retries': self.args.retries, + }) + except KeyError as e: + self.logger.error("Missing environment: %s", e) + exit(1) # Do a sanity check that we have a working arvados host + token. self.api.users().current().execute() @@ -345,20 +370,9 @@ From here, the following directories are available: def _run_standalone(self): try: - llfuse.init(self.operations, self.args.mountpoint, self._fuse_options()) - - if not self.args.foreground: - self.daemon_ctx = daemon.DaemonContext( - working_directory=os.path.dirname(self.args.mountpoint), - files_preserve=range( - 3, resource.getrlimit(resource.RLIMIT_NOFILE)[1])) - self.daemon_ctx.open() - - # Subscribe to change events from API server - if self.listen_for_events and not self.args.disable_event_listening: - self.operations.listen_for_events() - - self._llfuse_main() + self.daemon = not self.args.foreground + with self: + self.llfuse_thread.join(timeout=None) except Exception as e: self.logger.exception('arv-mount: exception during mount: %s', e) exit(getattr(e, 'errno', 1))