X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/cbfc8eea7f3fc96f478530c77441b7175a043a17..f580cf6d3d86f6591e68b4501279fc45cbf847e0:/services/api/test/functional/arvados/v1/users_controller_test.rb?ds=sidebyside diff --git a/services/api/test/functional/arvados/v1/users_controller_test.rb b/services/api/test/functional/arvados/v1/users_controller_test.rb index 1da8509c31..5f1a3f0225 100644 --- a/services/api/test/functional/arvados/v1/users_controller_test.rb +++ b/services/api/test/functional/arvados/v1/users_controller_test.rb @@ -1,6 +1,12 @@ require 'test_helper' class Arvados::V1::UsersControllerTest < ActionController::TestCase + include CurrentApiClient + + setup do + @all_links_at_start = Link.all + @vm_uuid = virtual_machines(:testvm).uuid + end test "activate a user after signing UA" do authorize_with :inactive_but_signed_user_agreement @@ -38,34 +44,782 @@ class Arvados::V1::UsersControllerTest < ActionController::TestCase assert_equal true, me['is_active'] end - test "create new user" do + test "create new user with user as input" do authorize_with :admin post :create, user: { first_name: "test_first_name", last_name: "test_last_name", - email: "test@abc.com" + email: "foo@example.com" } assert_response :success created = JSON.parse(@response.body) assert_equal 'test_first_name', created['first_name'] - assert_not_nil created['uuid'], 'expected non-null uuid for the newly created user' - assert_not_nil created['email'], 'since email was given, expected non-nil email' - assert_nil created['identity_url'], 'even though email is provided, expected no identity_url since users_controller only creates user at this time' + assert_not_nil created['uuid'], 'expected uuid for the newly created user' + assert_not_nil created['email'], 'expected non-nil email' + assert_nil created['identity_url'], 'expected no identity_url' end - test "create user with vm and repo" do + test "create user with user, vm and repo as input" do authorize_with :admin + repo_name = 'test_repo' - post :create, { + post :setup, { + repo_name: repo_name, + openid_prefix: 'https://www.google.com/accounts/o8/id', + user: { + uuid: 'zzzzz-tpzed-abcdefghijklmno', + first_name: "in_create_test_first_name", + last_name: "test_last_name", + email: "foo@example.com" + } + } + assert_response :success + response_items = JSON.parse(@response.body)['items'] + + created = find_obj_in_resp response_items, 'User', nil + + assert_equal 'in_create_test_first_name', created['first_name'] + assert_not_nil created['uuid'], 'expected non-null uuid for the new user' + assert_equal 'zzzzz-tpzed-abcdefghijklmno', created['uuid'] + assert_not_nil created['email'], 'expected non-nil email' + assert_nil created['identity_url'], 'expected no identity_url' + + # arvados#user, repo link and link add user to 'All users' group + verify_num_links @all_links_at_start, 4 + + verify_link response_items, 'arvados#user', true, 'permission', 'can_login', + created['uuid'], created['email'], 'arvados#user', false, 'User' + + verify_link response_items, 'arvados#repository', true, 'permission', 'can_write', + repo_name, created['uuid'], 'arvados#repository', true, 'Repository' + + verify_link response_items, 'arvados#group', true, 'permission', 'can_read', + 'All users', created['uuid'], 'arvados#group', true, 'Group' + + verify_link response_items, 'arvados#virtualMachine', false, 'permission', 'can_login', + nil, created['uuid'], 'arvados#virtualMachine', false, 'VirtualMachine' + + verify_system_group_permission_link_for created['uuid'] + + # invoke setup again with the same data + post :setup, { + repo_name: repo_name, + vm_uuid: @vm_uuid, + openid_prefix: 'https://www.google.com/accounts/o8/id', + user: { + uuid: 'zzzzz-tpzed-abcdefghijklmno', + first_name: "in_create_test_first_name", + last_name: "test_last_name", + email: "foo@example.com" + } + } + + response_items = JSON.parse(@response.body)['items'] + + created = find_obj_in_resp response_items, 'User', nil + assert_equal 'in_create_test_first_name', created['first_name'] + assert_not_nil created['uuid'], 'expected non-null uuid for the new user' + assert_equal 'zzzzz-tpzed-abcdefghijklmno', created['uuid'] + assert_not_nil created['email'], 'expected non-nil email' + assert_nil created['identity_url'], 'expected no identity_url' + + # arvados#user, repo link and link add user to 'All users' group + verify_num_links @all_links_at_start, 5 + + verify_link response_items, 'arvados#repository', true, 'permission', 'can_write', + repo_name, created['uuid'], 'arvados#repository', true, 'Repository' + + verify_link response_items, 'arvados#group', true, 'permission', 'can_read', + 'All users', created['uuid'], 'arvados#group', true, 'Group' + + verify_link response_items, 'arvados#virtualMachine', true, 'permission', 'can_login', + @vm_uuid, created['uuid'], 'arvados#virtualMachine', false, 'VirtualMachine' + + verify_system_group_permission_link_for created['uuid'] + end + + test "setup user with bogus uuid and expect error" do + authorize_with :admin + + post :setup, { + uuid: 'bogus_uuid', + repo_name: 'test_repo', + vm_uuid: @vm_uuid + } + response_body = JSON.parse(@response.body) + response_errors = response_body['errors'] + assert_not_nil response_errors, 'Expected error in response' + assert (response_errors.first.include? 'Path not found'), 'Expected 404' + end + + test "setup user with bogus uuid in user and expect error" do + authorize_with :admin + + post :setup, { + user: {uuid: 'bogus_uuid'}, + repo_name: 'test_repo', + vm_uuid: @vm_uuid, + openid_prefix: 'https://www.google.com/accounts/o8/id' + } + response_body = JSON.parse(@response.body) + response_errors = response_body['errors'] + assert_not_nil response_errors, 'Expected error in response' + assert (response_errors.first.include? 'ArgumentError: Require user email'), + 'Expected RuntimeError' + end + + test "setup user with no uuid and user, expect error" do + authorize_with :admin + + post :setup, { + repo_name: 'test_repo', + vm_uuid: @vm_uuid, + openid_prefix: 'https://www.google.com/accounts/o8/id' + } + response_body = JSON.parse(@response.body) + response_errors = response_body['errors'] + assert_not_nil response_errors, 'Expected error in response' + assert (response_errors.first.include? 'Required uuid or user'), + 'Expected ArgumentError' + end + + test "setup user with no uuid and email, expect error" do + authorize_with :admin + + post :setup, { + user: {}, + repo_name: 'test_repo', + vm_uuid: @vm_uuid, + openid_prefix: 'https://www.google.com/accounts/o8/id' + } + response_body = JSON.parse(@response.body) + response_errors = response_body['errors'] + assert_not_nil response_errors, 'Expected error in response' + assert (response_errors.first.include? '