X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/c93eb8717c79922f3e68b13405b5250bb1345d72..443a0b96316ed46600dc5035193adae6ac4d1f74:/sdk/go/httpserver/logger.go diff --git a/sdk/go/httpserver/logger.go b/sdk/go/httpserver/logger.go index 569931a3ed..357daee269 100644 --- a/sdk/go/httpserver/logger.go +++ b/sdk/go/httpserver/logger.go @@ -10,37 +10,55 @@ import ( "time" "git.curoverse.com/arvados.git/sdk/go/stats" - "github.com/Sirupsen/logrus" + "github.com/sirupsen/logrus" ) type contextKey struct { name string } -var requestTimeContextKey = contextKey{"requestTime"} - -var Logger logrus.FieldLogger = logrus.StandardLogger() +var ( + requestTimeContextKey = contextKey{"requestTime"} + loggerContextKey = contextKey{"logger"} +) // LogRequests wraps an http.Handler, logging each request and -// response via logrus. -func LogRequests(h http.Handler) http.Handler { +// response via logger. +func LogRequests(logger logrus.FieldLogger, h http.Handler) http.Handler { + if logger == nil { + logger = logrus.StandardLogger() + } return http.HandlerFunc(func(wrapped http.ResponseWriter, req *http.Request) { w := &responseTimer{ResponseWriter: WrapResponseWriter(wrapped)} - req = req.WithContext(context.WithValue(req.Context(), &requestTimeContextKey, time.Now())) - lgr := Logger.WithFields(logrus.Fields{ + lgr := logger.WithFields(logrus.Fields{ "RequestID": req.Header.Get("X-Request-Id"), "remoteAddr": req.RemoteAddr, "reqForwardedFor": req.Header.Get("X-Forwarded-For"), "reqMethod": req.Method, + "reqHost": req.Host, "reqPath": req.URL.Path[1:], + "reqQuery": req.URL.RawQuery, "reqBytes": req.ContentLength, }) + ctx := req.Context() + ctx = context.WithValue(ctx, &requestTimeContextKey, time.Now()) + ctx = context.WithValue(ctx, &loggerContextKey, lgr) + req = req.WithContext(ctx) + logRequest(w, req, lgr) defer logResponse(w, req, lgr) h.ServeHTTP(w, req) }) } +func Logger(req *http.Request) logrus.FieldLogger { + if lgr, ok := req.Context().Value(&loggerContextKey).(logrus.FieldLogger); ok { + return lgr + } else { + return logrus.StandardLogger() + } +} + func logRequest(w *responseTimer, req *http.Request, lgr *logrus.Entry) { lgr.Info("request") }