X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/c52c3788fbbf161db40118261c4cfff52ebf8ceb..409d130ddcc4b76def5fa8d61d2584725c61152a:/services/ws/session_v0.go diff --git a/services/ws/session_v0.go b/services/ws/session_v0.go index 2bcce6073e..44e2a1deb5 100644 --- a/services/ws/session_v0.go +++ b/services/ws/session_v0.go @@ -16,13 +16,14 @@ var ( errQueueFull = errors.New("client queue full") errFrameTooBig = errors.New("frame too big") - sendObjectAttributes = []string{"state", "name"} + sendObjectAttributes = []string{"state", "name", "owner_uuid", "portable_data_hash"} v0subscribeOK = []byte(`{"status":200}`) v0subscribeFail = []byte(`{"status":400}`) ) type v0session struct { + ac *arvados.Client ws wsConn sendq chan<- interface{} db *sql.DB @@ -34,12 +35,16 @@ type v0session struct { setupOnce sync.Once } -func NewSessionV0(ws wsConn, sendq chan<- interface{}, ac arvados.Client, db *sql.DB) (session, error) { +// newSessionV0 returns a v0 session: a partial port of the Rails/puma +// implementation, with just enough functionality to support Workbench +// and arv-mount. +func newSessionV0(ws wsConn, sendq chan<- interface{}, db *sql.DB, pc permChecker, ac *arvados.Client) (session, error) { sess := &v0session{ sendq: sendq, ws: ws, db: db, - permChecker: NewPermChecker(ac), + ac: ac, + permChecker: pc, log: logger(ws.Request().Context()), } @@ -86,13 +91,16 @@ func (sess *v0session) EventMessage(e *event) ([]byte, error) { return nil, err } + kind, _ := sess.ac.KindForUUID(detail.ObjectUUID) msg := map[string]interface{}{ "msgID": atomic.AddUint64(&sess.lastMsgID, 1), "id": detail.ID, "uuid": detail.UUID, "object_uuid": detail.ObjectUUID, "object_owner_uuid": detail.ObjectOwnerUUID, + "object_kind": kind, "event_type": detail.EventType, + "event_at": detail.EventAt, } if detail.Properties != nil && detail.Properties["text"] != nil { msg["properties"] = detail.Properties @@ -165,13 +173,19 @@ func (sub *v0subscribe) sendOldEvents(sess *v0session) { // same thing all over again. time.Sleep(100 * time.Millisecond) } + now := time.Now() e := &event{ LogID: id, - Received: time.Now(), + Received: now, + Ready: now, db: sess.db, } if sub.match(sess, e) { - sess.sendq <- e + select { + case sess.sendq <- e: + case <-sess.ws.Request().Context().Done(): + return + } } } if err := rows.Err(); err != nil {