X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/c152ee1d170bf419ef49241cbde030e8fce68882..8a27fe370239ecb8e50d53f46b45ed61203a35ca:/services/keep-web/cadaver_test.go?ds=sidebyside diff --git a/services/keep-web/cadaver_test.go b/services/keep-web/cadaver_test.go index eb323674b9..742140f7f3 100644 --- a/services/keep-web/cadaver_test.go +++ b/services/keep-web/cadaver_test.go @@ -2,51 +2,82 @@ // // SPDX-License-Identifier: AGPL-3.0 -package main +package keepweb import ( "bytes" + "fmt" "io" "io/ioutil" - "net/url" "os" "os/exec" + "path/filepath" "strings" "time" - "git.curoverse.com/arvados.git/sdk/go/arvados" - "git.curoverse.com/arvados.git/sdk/go/arvadostest" + "git.arvados.org/arvados.git/sdk/go/arvados" + "git.arvados.org/arvados.git/sdk/go/arvadostest" check "gopkg.in/check.v1" ) -func (s *IntegrationSuite) TestWebdavWithCadaver(c *check.C) { +func (s *IntegrationSuite) TestCadaverHTTPAuth(c *check.C) { + s.testCadaver(c, arvadostest.ActiveToken, func(newCollection arvados.Collection) (string, string, string) { + r := "/c=" + arvadostest.FooAndBarFilesInDirUUID + "/" + w := "/c=" + newCollection.UUID + "/" + pdh := "/c=" + strings.Replace(arvadostest.FooAndBarFilesInDirPDH, "+", "-", -1) + "/" + return r, w, pdh + }, nil) +} + +func (s *IntegrationSuite) TestCadaverPathAuth(c *check.C) { + s.testCadaver(c, "", func(newCollection arvados.Collection) (string, string, string) { + r := "/c=" + arvadostest.FooAndBarFilesInDirUUID + "/t=" + arvadostest.ActiveToken + "/" + w := "/c=" + newCollection.UUID + "/t=" + arvadostest.ActiveToken + "/" + pdh := "/c=" + strings.Replace(arvadostest.FooAndBarFilesInDirPDH, "+", "-", -1) + "/t=" + arvadostest.ActiveToken + "/" + return r, w, pdh + }, nil) +} + +func (s *IntegrationSuite) TestCadaverUserProject(c *check.C) { + rpath := "/users/active/foo_file_in_dir/" + s.testCadaver(c, arvadostest.ActiveToken, func(newCollection arvados.Collection) (string, string, string) { + wpath := "/users/active/" + newCollection.Name + pdh := "/c=" + strings.Replace(arvadostest.FooAndBarFilesInDirPDH, "+", "-", -1) + "/" + return rpath, wpath, pdh + }, func(path string) bool { + // Skip tests that rely on writes, because /users/ + // tree is read-only. + return !strings.HasPrefix(path, rpath) || strings.HasPrefix(path, rpath+"_/") + }) +} + +func (s *IntegrationSuite) testCadaver(c *check.C, password string, pathFunc func(arvados.Collection) (string, string, string), skip func(string) bool) { testdata := []byte("the human tragedy consists in the necessity of living with the consequences of actions performed under the pressure of compulsions we do not understand") - localfile, err := ioutil.TempFile("", "localfile") + tempdir, err := ioutil.TempDir("", "keep-web-test-") + c.Assert(err, check.IsNil) + defer os.RemoveAll(tempdir) + + localfile, err := ioutil.TempFile(tempdir, "localfile") c.Assert(err, check.IsNil) - defer os.Remove(localfile.Name()) localfile.Write(testdata) - emptyfile, err := ioutil.TempFile("", "emptyfile") + emptyfile, err := ioutil.TempFile(tempdir, "emptyfile") c.Assert(err, check.IsNil) - defer os.Remove(emptyfile.Name()) - checkfile, err := ioutil.TempFile("", "checkfile") + checkfile, err := ioutil.TempFile(tempdir, "checkfile") c.Assert(err, check.IsNil) - defer os.Remove(checkfile.Name()) var newCollection arvados.Collection arv := arvados.NewClientFromEnv() arv.AuthToken = arvadostest.ActiveToken - err = arv.RequestAndDecode(&newCollection, "POST", "/arvados/v1/collections", bytes.NewBufferString(url.Values{"collection": {"{}"}}.Encode()), nil) + err = arv.RequestAndDecode(&newCollection, "POST", "arvados/v1/collections", nil, map[string]interface{}{"collection": map[string]interface{}{}}) c.Assert(err, check.IsNil) - writePath := "/c=" + newCollection.UUID + "/t=" + arv.AuthToken + "/" - pdhPath := "/c=" + strings.Replace(arvadostest.FooAndBarFilesInDirPDH, "+", "-", -1) + "/t=" + arv.AuthToken + "/" + readPath, writePath, pdhPath := pathFunc(newCollection) matchToday := time.Now().Format("Jan +2") - readPath := "/c=" + arvadostest.FooAndBarFilesInDirUUID + "/t=" + arvadostest.ActiveToken + "/" type testcase struct { path string cmd string @@ -101,6 +132,16 @@ func (s *IntegrationSuite) TestWebdavWithCadaver(c *check.C) { match: `(?ms).*succeeded.*`, data: testdata, }, + { + path: writePath, + cmd: "move testfile \"test &#!%20 file\"\n", + match: `(?ms).*Moving .* succeeded.*`, + }, + { + path: writePath, + cmd: "move \"test &#!%20 file\" testfile\n", + match: `(?ms).*Moving .* succeeded.*`, + }, { path: writePath, cmd: "move testfile newdir0/\n", @@ -111,6 +152,16 @@ func (s *IntegrationSuite) TestWebdavWithCadaver(c *check.C) { cmd: "move testfile newdir0/\n", match: `(?ms).*Moving .* failed.*`, }, + { + path: writePath, + cmd: "lock newdir0/testfile\n", + match: `(?ms).*Locking .* succeeded.*`, + }, + { + path: writePath, + cmd: "unlock newdir0/testfile\nasdf\n", + match: `(?ms).*Unlocking .* succeeded.*`, + }, { path: writePath, cmd: "ls\n", @@ -126,6 +177,16 @@ func (s *IntegrationSuite) TestWebdavWithCadaver(c *check.C) { cmd: "mkcol newdir1\n", match: `(?ms).*Creating .* succeeded.*`, }, + { + path: writePath, + cmd: "move newdir1/ newdir1x/\n", + match: `(?ms).*Moving .* succeeded.*`, + }, + { + path: writePath, + cmd: "move newdir1x newdir1\n", + match: `(?ms).*Moving .* succeeded.*`, + }, { path: writePath, cmd: "move newdir0/testfile newdir1/\n", @@ -209,24 +270,22 @@ func (s *IntegrationSuite) TestWebdavWithCadaver(c *check.C) { cmd: "delete foo\n", match: `(?ms).*Deleting .* failed:.*405 Method Not Allowed.*`, }, + { + path: pdhPath, + cmd: "lock foo\n", + match: `(?ms).*Locking .* failed:.*405 Method Not Allowed.*`, + }, } { - c.Logf("%s %+v", "http://"+s.testServer.Addr, trial) + c.Logf("%s %+v", s.testServer.URL, trial) + if skip != nil && skip(trial.path) { + c.Log("(skip)") + continue + } os.Remove(checkfile.Name()) - cmd := exec.Command("cadaver", "http://"+s.testServer.Addr+trial.path) - cmd.Stdin = bytes.NewBufferString(trial.cmd) - stdout, err := cmd.StdoutPipe() - c.Assert(err, check.Equals, nil) - cmd.Stderr = cmd.Stdout - go cmd.Start() - - var buf bytes.Buffer - _, err = io.Copy(&buf, stdout) - c.Check(err, check.Equals, nil) - err = cmd.Wait() - c.Check(err, check.Equals, nil) - c.Check(buf.String(), check.Matches, trial.match) + stdout := s.runCadaver(c, password, trial.path, trial.cmd) + c.Check(stdout, check.Matches, trial.match) if trial.data == nil { continue @@ -239,3 +298,75 @@ func (s *IntegrationSuite) TestWebdavWithCadaver(c *check.C) { c.Check(err, check.IsNil) } } + +func (s *IntegrationSuite) TestCadaverByID(c *check.C) { + for _, path := range []string{"/by_id", "/by_id/"} { + stdout := s.runCadaver(c, arvadostest.ActiveToken, path, "ls") + c.Check(stdout, check.Matches, `(?ms).*collection is empty.*`) + } + for _, path := range []string{ + "/by_id/" + arvadostest.FooCollectionPDH, + "/by_id/" + arvadostest.FooCollectionPDH + "/", + "/by_id/" + arvadostest.FooCollection, + "/by_id/" + arvadostest.FooCollection + "/", + } { + stdout := s.runCadaver(c, arvadostest.ActiveToken, path, "ls") + c.Check(stdout, check.Matches, `(?ms).*\s+foo\s+3 .*`) + } +} + +func (s *IntegrationSuite) TestCadaverUsersDir(c *check.C) { + for _, path := range []string{"/"} { + stdout := s.runCadaver(c, arvadostest.ActiveToken, path, "ls") + c.Check(stdout, check.Matches, `(?ms).*Coll:\s+by_id\s+0 .*`) + c.Check(stdout, check.Matches, `(?ms).*Coll:\s+users\s+0 .*`) + } + for _, path := range []string{"/users", "/users/"} { + stdout := s.runCadaver(c, arvadostest.ActiveToken, path, "ls") + c.Check(stdout, check.Matches, `(?ms).*Coll:\s+active.*`) + } + for _, path := range []string{"/users/active", "/users/active/"} { + stdout := s.runCadaver(c, arvadostest.ActiveToken, path, "ls") + c.Check(stdout, check.Matches, `(?ms).*Coll:\s+A Project\s+0 .*`) + c.Check(stdout, check.Matches, `(?ms).*Coll:\s+bar_file\s+0 .*`) + } + for _, path := range []string{"/users/admin", "/users/doesnotexist", "/users/doesnotexist/"} { + stdout := s.runCadaver(c, arvadostest.ActiveToken, path, "ls") + c.Check(stdout, check.Matches, `(?ms).*404 Not Found.*`) + } +} + +func (s *IntegrationSuite) runCadaver(c *check.C, password, path, stdin string) string { + tempdir, err := ioutil.TempDir("", "keep-web-test-") + c.Assert(err, check.IsNil) + defer os.RemoveAll(tempdir) + + cmd := exec.Command("cadaver", s.testServer.URL+path) + if password != "" { + // cadaver won't try username/password authentication + // unless the server responds 401 to an + // unauthenticated request, which it only does in + // AttachmentOnlyHost, TrustAllContent, and + // per-collection vhost cases. + s.handler.Cluster.Services.WebDAVDownload.ExternalURL.Host = s.testServer.URL[7:] + + cmd.Env = append(os.Environ(), "HOME="+tempdir) + f, err := os.OpenFile(filepath.Join(tempdir, ".netrc"), os.O_CREATE|os.O_TRUNC|os.O_WRONLY, 0600) + c.Assert(err, check.IsNil) + _, err = fmt.Fprintf(f, "default login none password %s\n", password) + c.Assert(err, check.IsNil) + c.Assert(f.Close(), check.IsNil) + } + cmd.Stdin = bytes.NewBufferString(stdin) + stdout, err := cmd.StdoutPipe() + c.Assert(err, check.Equals, nil) + cmd.Stderr = cmd.Stdout + go cmd.Start() + + var buf bytes.Buffer + _, err = io.Copy(&buf, stdout) + c.Check(err, check.Equals, nil) + err = cmd.Wait() + c.Check(err, check.Equals, nil) + return buf.String() +}