X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/c11055f2d6ce8385088bc221eab1175e31777ec0..cfeff7ff252c475975587a740e25ee419a515d3c:/src/components/data-table/data-table.test.tsx

diff --git a/src/components/data-table/data-table.test.tsx b/src/components/data-table/data-table.test.tsx
index 77c7825bc1..d0b83b9696 100644
--- a/src/components/data-table/data-table.test.tsx
+++ b/src/components/data-table/data-table.test.tsx
@@ -4,35 +4,39 @@
 
 import * as React from "react";
 import { mount, configure } from "enzyme";
+import { pipe } from 'lodash/fp';
 import { TableHead, TableCell, Typography, TableBody, Button, TableSortLabel } from "@material-ui/core";
 import * as Adapter from "enzyme-adapter-react-16";
 import { DataTable, DataColumns } from "./data-table";
-import { DataTableFilters } from "../data-table-filters/data-table-filters";
-import { SortDirection } from "./data-column";
+import { DataTableFilters } from "~/components/data-table-filters/data-table-filters";
+import { SortDirection, createDataColumn } from "./data-column";
+import { DataTableFiltersPopover } from '~/components/data-table-filters/data-table-filters-popover';
+import { createTree, setNode, initTreeNode } from '~/models/tree';
+import { DataTableFilterItem } from "~/components/data-table-filters/data-table-filters-tree";
 
 configure({ adapter: new Adapter() });
 
 describe("<DataTable />", () => {
     it("shows only selected columns", () => {
         const columns: DataColumns<string> = [
-            {
+            createDataColumn({
                 name: "Column 1",
                 render: () => <span />,
                 selected: true,
                 configurable: true
-            },
-            {
+            }),
+            createDataColumn({
                 name: "Column 2",
                 render: () => <span />,
                 selected: true,
                 configurable: true
-            },
-            {
+            }),
+            createDataColumn({
                 name: "Column 3",
                 render: () => <span />,
                 selected: false,
                 configurable: true
-            }
+            }),
         ];
         const dataTable = mount(<DataTable
             columns={columns}
@@ -47,12 +51,12 @@ describe("<DataTable />", () => {
 
     it("renders column name", () => {
         const columns: DataColumns<string> = [
-            {
+            createDataColumn({
                 name: "Column 1",
                 render: () => <span />,
                 selected: true,
                 configurable: true
-            }
+            }),
         ];
         const dataTable = mount(<DataTable
             columns={columns}
@@ -67,13 +71,13 @@ describe("<DataTable />", () => {
 
     it("uses renderHeader instead of name prop", () => {
         const columns: DataColumns<string> = [
-            {
+            createDataColumn({
                 name: "Column 1",
                 renderHeader: () => <span>Column Header</span>,
                 render: () => <span />,
                 selected: true,
                 configurable: true
-            }
+            }),
         ];
         const dataTable = mount(<DataTable
             columns={columns}
@@ -88,13 +92,13 @@ describe("<DataTable />", () => {
 
     it("passes column key prop to corresponding cells", () => {
         const columns: DataColumns<string> = [
-            {
+            createDataColumn({
                 name: "Column 1",
                 key: "column-1-key",
                 render: () => <span />,
                 selected: true,
                 configurable: true
-            }
+            })
         ];
         const dataTable = mount(<DataTable
             columns={columns}
@@ -110,18 +114,18 @@ describe("<DataTable />", () => {
 
     it("renders items", () => {
         const columns: DataColumns<string> = [
-            {
+            createDataColumn({
                 name: "Column 1",
                 render: (item) => <Typography>{item}</Typography>,
                 selected: true,
                 configurable: true
-            },
-            {
+            }),
+            createDataColumn({
                 name: "Column 2",
                 render: (item) => <Button>{item}</Button>,
                 selected: true,
                 configurable: true
-            }
+            })
         ];
         const dataTable = mount(<DataTable
             columns={columns}
@@ -136,13 +140,14 @@ describe("<DataTable />", () => {
     });
 
     it("passes sorting props to <TableSortLabel />", () => {
-        const columns: DataColumns<string> = [{
-            name: "Column 1",
-            sortDirection: SortDirection.ASC,
-            selected: true,
-            configurable: true,
-            render: (item) => <Typography>{item}</Typography>
-        }];
+        const columns: DataColumns<string> = [
+            createDataColumn({
+                name: "Column 1",
+                sortDirection: SortDirection.ASC,
+                selected: true,
+                configurable: true,
+                render: (item) => <Typography>{item}</Typography>
+            })];
         const onSortToggle = jest.fn();
         const dataTable = mount(<DataTable
             columns={columns}
@@ -157,13 +162,13 @@ describe("<DataTable />", () => {
         expect(onSortToggle).toHaveBeenCalledWith(columns[0]);
     });
 
-    it("passes filter props to <DataTableFilter />", () => {
+    it("does not display <DataTableFilter /> if there is no filters provided", () => {
         const columns: DataColumns<string> = [{
             name: "Column 1",
             sortDirection: SortDirection.ASC,
             selected: true,
             configurable: true,
-            filters: [{ name: "Filter 1", selected: true }],
+            filters: [],
             render: (item) => <Typography>{item}</Typography>
         }];
         const onFiltersChange = jest.fn();
@@ -175,8 +180,53 @@ describe("<DataTable />", () => {
             onRowDoubleClick={jest.fn()}
             onSortToggle={jest.fn()}
             onContextMenu={jest.fn()} />);
-        expect(dataTable.find(DataTableFilters).prop("filters")).toBe(columns[0].filters);
-        dataTable.find(DataTableFilters).prop("onChange")([]);
+        expect(dataTable.find(DataTableFilters)).toHaveLength(0);
+    });
+
+    it("passes filter props to <DataTableFiltersPopover />", () => {
+        const filters = pipe(
+            () => createTree<DataTableFilterItem>(),
+            setNode(initTreeNode({ id: 'filter', value: { name: 'filter' } }))
+        );
+        const columns: DataColumns<string> = [{
+            name: "Column 1",
+            sortDirection: SortDirection.ASC,
+            selected: true,
+            configurable: true,
+            filters: filters(),
+            render: (item) => <Typography>{item}</Typography>
+        }];
+        const onFiltersChange = jest.fn();
+        const dataTable = mount(<DataTable
+            columns={columns}
+            items={[]}
+            onFiltersChange={onFiltersChange}
+            onRowClick={jest.fn()}
+            onRowDoubleClick={jest.fn()}
+            onSortToggle={jest.fn()}
+            onContextMenu={jest.fn()} />);
+        expect(dataTable.find(DataTableFiltersPopover).prop("filters")).toBe(columns[0].filters);
+        dataTable.find(DataTableFiltersPopover).prop("onChange")([]);
         expect(onFiltersChange).toHaveBeenCalledWith([], columns[0]);
     });
+
+    // it("shows default view if there is no items", () => {
+    //     const columns: DataColumns<string> = [
+    //         createDataColumn({
+    //             name: "Column 1",
+    //             render: () => <span />,
+    //             selected: true,
+    //             configurable: true
+    //         }),
+    //     ];
+    //     const dataTable = mount(<DataTable
+    //         columns={columns}
+    //         items={[]}
+    //         onFiltersChange={jest.fn()}
+    //         onRowClick={jest.fn()}
+    //         onRowDoubleClick={jest.fn()}
+    //         onContextMenu={jest.fn()}
+    //         onSortToggle={jest.fn()} />);
+    //     expect(dataTable.find(DataTableDefaultView)).toHaveLength(1);
+    // });
 });
