X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/c0b66870cafce4d75625e16b5b36bed8b58d7c8e..7943691e146fecc929f1dcde2f794ab32fadc565:/services/api/test/functional/arvados/v1/job_reuse_controller_test.rb diff --git a/services/api/test/functional/arvados/v1/job_reuse_controller_test.rb b/services/api/test/functional/arvados/v1/job_reuse_controller_test.rb index 03e577f48d..01f2b9c51b 100644 --- a/services/api/test/functional/arvados/v1/job_reuse_controller_test.rb +++ b/services/api/test/functional/arvados/v1/job_reuse_controller_test.rb @@ -1,16 +1,20 @@ require 'test_helper' -load 'test/functional/arvados/v1/git_setup.rb' +require 'helpers/git_test_helper' class Arvados::V1::JobReuseControllerTest < ActionController::TestCase - fixtures :repositories, :users, :jobs, :links + fixtures :repositories, :users, :jobs, :links, :collections # See git_setup.rb for the commit log for test.git.tar - include GitSetup + include GitTestHelper - test "test_reuse_job" do + setup do @controller = Arvados::V1::JobsController.new authorize_with :active + end + + test "reuse job with no_reuse=false" do post :create, job: { + no_reuse: false, script: "hash", script_version: "4fe459abe02d9b365932b8f5dc419439ab4e2577", repository: "foo", @@ -26,10 +30,127 @@ class Arvados::V1::JobReuseControllerTest < ActionController::TestCase assert_equal '4fe459abe02d9b365932b8f5dc419439ab4e2577', new_job['script_version'] end + test "reuse job with find_or_create=true" do + post :create, { + job: { + script: "hash", + script_version: "4fe459abe02d9b365932b8f5dc419439ab4e2577", + repository: "foo", + script_parameters: { + input: 'fa7aeb5140e2848d39b416daeef4ffc5+45', + an_integer: '1' + } + }, + find_or_create: true + } + assert_response :success + assert_not_nil assigns(:object) + new_job = JSON.parse(@response.body) + assert_equal 'zzzzz-8i9sb-cjs4pklxxjykqqq', new_job['uuid'] + assert_equal '4fe459abe02d9b365932b8f5dc419439ab4e2577', new_job['script_version'] + end + + test "reuse job with symbolic script_version" do + post :create, { + job: { + script: "hash", + script_version: "tag1", + repository: "foo", + script_parameters: { + input: 'fa7aeb5140e2848d39b416daeef4ffc5+45', + an_integer: '1' + } + }, + find_or_create: true + } + assert_response :success + assert_not_nil assigns(:object) + new_job = JSON.parse(@response.body) + assert_equal 'zzzzz-8i9sb-cjs4pklxxjykqqq', new_job['uuid'] + assert_equal '4fe459abe02d9b365932b8f5dc419439ab4e2577', new_job['script_version'] + end + + test "do not reuse job because no_reuse=true" do + post :create, { + job: { + no_reuse: true, + script: "hash", + script_version: "4fe459abe02d9b365932b8f5dc419439ab4e2577", + repository: "foo", + script_parameters: { + input: 'fa7aeb5140e2848d39b416daeef4ffc5+45', + an_integer: '1' + } + } + } + assert_response :success + assert_not_nil assigns(:object) + new_job = JSON.parse(@response.body) + assert_not_equal 'zzzzz-8i9sb-cjs4pklxxjykqqq', new_job['uuid'] + assert_equal '4fe459abe02d9b365932b8f5dc419439ab4e2577', new_job['script_version'] + end + + test "do not reuse job because find_or_create=false" do + post :create, { + job: { + script: "hash", + script_version: "4fe459abe02d9b365932b8f5dc419439ab4e2577", + repository: "foo", + script_parameters: { + input: 'fa7aeb5140e2848d39b416daeef4ffc5+45', + an_integer: '1' + } + }, + find_or_create: false + } + assert_response :success + assert_not_nil assigns(:object) + new_job = JSON.parse(@response.body) + assert_not_equal 'zzzzz-8i9sb-cjs4pklxxjykqqq', new_job['uuid'] + assert_equal '4fe459abe02d9b365932b8f5dc419439ab4e2577', new_job['script_version'] + end + + test "do not reuse job because output is not readable by user" do + authorize_with :job_reader + post :create, { + job: { + script: "hash", + script_version: "4fe459abe02d9b365932b8f5dc419439ab4e2577", + repository: "foo", + script_parameters: { + input: 'fa7aeb5140e2848d39b416daeef4ffc5+45', + an_integer: '1' + } + }, + find_or_create: true + } + assert_response :success + assert_not_nil assigns(:object) + new_job = JSON.parse(@response.body) + assert_not_equal 'zzzzz-8i9sb-cjs4pklxxjykqqq', new_job['uuid'] + assert_equal '4fe459abe02d9b365932b8f5dc419439ab4e2577', new_job['script_version'] + end + + test "test_cannot_reuse_job_no_output" do + post :create, job: { + no_reuse: false, + script: "hash", + script_version: "4fe459abe02d9b365932b8f5dc419439ab4e2577", + repository: "foo", + script_parameters: { + input: 'fa7aeb5140e2848d39b416daeef4ffc5+45', + an_integer: '2' + } + } + assert_response :success + assert_not_nil assigns(:object) + new_job = JSON.parse(@response.body) + assert_not_equal 'zzzzz-8i9sb-cjs4pklxxjykppp', new_job['uuid'] + end + test "test_reuse_job_range" do - @controller = Arvados::V1::JobsController.new - authorize_with :active post :create, job: { + no_reuse: false, script: "hash", minimum_script_version: "tag1", script_version: "master", @@ -46,10 +167,27 @@ class Arvados::V1::JobReuseControllerTest < ActionController::TestCase assert_equal '4fe459abe02d9b365932b8f5dc419439ab4e2577', new_job['script_version'] end + test "cannot_reuse_job_no_minimum_given_so_must_use_specified_commit" do + post :create, job: { + no_reuse: false, + script: "hash", + script_version: "master", + repository: "foo", + script_parameters: { + input: 'fa7aeb5140e2848d39b416daeef4ffc5+45', + an_integer: '1' + } + } + assert_response :success + assert_not_nil assigns(:object) + new_job = JSON.parse(@response.body) + assert_not_equal 'zzzzz-8i9sb-cjs4pklxxjykqqq', new_job['uuid'] + assert_equal '077ba2ad3ea24a929091a9e6ce545c93199b8e57', new_job['script_version'] + end + test "test_cannot_reuse_job_different_input" do - @controller = Arvados::V1::JobsController.new - authorize_with :active post :create, job: { + no_reuse: false, script: "hash", script_version: "4fe459abe02d9b365932b8f5dc419439ab4e2577", repository: "foo", @@ -66,9 +204,8 @@ class Arvados::V1::JobReuseControllerTest < ActionController::TestCase end test "test_cannot_reuse_job_different_version" do - @controller = Arvados::V1::JobsController.new - authorize_with :active post :create, job: { + no_reuse: false, script: "hash", script_version: "master", repository: "foo", @@ -84,10 +221,9 @@ class Arvados::V1::JobReuseControllerTest < ActionController::TestCase assert_equal '077ba2ad3ea24a929091a9e6ce545c93199b8e57', new_job['script_version'] end - test "test_cannot_reuse_job_submitted_nondeterministic" do - @controller = Arvados::V1::JobsController.new - authorize_with :active + test "test_can_reuse_job_submitted_nondeterministic" do post :create, job: { + no_reuse: false, script: "hash", script_version: "4fe459abe02d9b365932b8f5dc419439ab4e2577", repository: "foo", @@ -100,14 +236,13 @@ class Arvados::V1::JobReuseControllerTest < ActionController::TestCase assert_response :success assert_not_nil assigns(:object) new_job = JSON.parse(@response.body) - assert_not_equal 'zzzzz-8i9sb-cjs4pklxxjykqqq', new_job['uuid'] + assert_equal 'zzzzz-8i9sb-cjs4pklxxjykqqq', new_job['uuid'] assert_equal '4fe459abe02d9b365932b8f5dc419439ab4e2577', new_job['script_version'] end test "test_cannot_reuse_job_past_nondeterministic" do - @controller = Arvados::V1::JobsController.new - authorize_with :active post :create, job: { + no_reuse: false, script: "hash2", script_version: "4fe459abe02d9b365932b8f5dc419439ab4e2577", repository: "foo", @@ -124,9 +259,9 @@ class Arvados::V1::JobReuseControllerTest < ActionController::TestCase end test "test_cannot_reuse_job_no_permission" do - @controller = Arvados::V1::JobsController.new authorize_with :spectator post :create, job: { + no_reuse: false, script: "hash", script_version: "4fe459abe02d9b365932b8f5dc419439ab4e2577", repository: "foo", @@ -143,9 +278,8 @@ class Arvados::V1::JobReuseControllerTest < ActionController::TestCase end test "test_cannot_reuse_job_excluded" do - @controller = Arvados::V1::JobsController.new - authorize_with :active post :create, job: { + no_reuse: false, script: "hash", minimum_script_version: "31ce37fe365b3dc204300a3e4c396ad333ed0556", script_version: "master", @@ -163,5 +297,370 @@ class Arvados::V1::JobReuseControllerTest < ActionController::TestCase assert_equal '077ba2ad3ea24a929091a9e6ce545c93199b8e57', new_job['script_version'] end + test "cannot reuse job with find_or_create but excluded version" do + post :create, { + job: { + script: "hash", + script_version: "master", + repository: "foo", + script_parameters: { + input: 'fa7aeb5140e2848d39b416daeef4ffc5+45', + an_integer: '1' + } + }, + find_or_create: true, + minimum_script_version: "31ce37fe365b3dc204300a3e4c396ad333ed0556", + exclude_script_versions: ["tag1"], + } + assert_response :success + assert_not_nil assigns(:object) + new_job = JSON.parse(@response.body) + assert_not_equal 'zzzzz-8i9sb-cjs4pklxxjykqqq', new_job['uuid'] + assert_equal '077ba2ad3ea24a929091a9e6ce545c93199b8e57', new_job['script_version'] + end + + BASE_FILTERS = { + 'repository' => ['=', 'foo'], + 'script' => ['=', 'hash'], + 'script_version' => ['in git', 'master'], + 'docker_image_locator' => ['=', nil], + } + + def filters_from_hash(hash) + hash.each_pair.map { |name, filter| [name] + filter } + end + + test "can reuse a Job based on filters" do + filter_h = BASE_FILTERS. + merge('script_version' => ['in git', 'tag1']) + post(:create, { + job: { + script: "hash", + script_version: "master", + repository: "foo", + script_parameters: { + input: 'fa7aeb5140e2848d39b416daeef4ffc5+45', + an_integer: '1' + } + }, + filters: filters_from_hash(filter_h), + find_or_create: true, + }) + assert_response :success + assert_not_nil assigns(:object) + new_job = JSON.parse(@response.body) + assert_equal 'zzzzz-8i9sb-cjs4pklxxjykqqq', new_job['uuid'] + assert_equal '4fe459abe02d9b365932b8f5dc419439ab4e2577', new_job['script_version'] + end + + test "can not reuse a Job based on filters" do + filter_a = filters_from_hash(BASE_FILTERS.reject { |k| k == 'script_version' }) + filter_a += [["script_version", "in git", + "31ce37fe365b3dc204300a3e4c396ad333ed0556"], + ["script_version", "not in git", ["tag1"]]] + post(:create, { + job: { + script: "hash", + script_version: "master", + repository: "foo", + script_parameters: { + input: 'fa7aeb5140e2848d39b416daeef4ffc5+45', + an_integer: '1' + } + }, + filters: filter_a, + find_or_create: true, + }) + assert_response :success + assert_not_nil assigns(:object) + new_job = JSON.parse(@response.body) + assert_not_equal 'zzzzz-8i9sb-cjs4pklxxjykqqq', new_job['uuid'] + assert_equal '077ba2ad3ea24a929091a9e6ce545c93199b8e57', new_job['script_version'] + end + + test "can not reuse a Job based on arbitrary filters" do + filter_h = BASE_FILTERS. + merge("created_at" => ["<", "2010-01-01T00:00:00Z"]) + post(:create, { + job: { + script: "hash", + script_version: "4fe459abe02d9b365932b8f5dc419439ab4e2577", + repository: "foo", + script_parameters: { + input: 'fa7aeb5140e2848d39b416daeef4ffc5+45', + an_integer: '1' + } + }, + filters: filters_from_hash(filter_h), + find_or_create: true, + }) + assert_response :success + assert_not_nil assigns(:object) + new_job = JSON.parse(@response.body) + assert_not_equal 'zzzzz-8i9sb-cjs4pklxxjykqqq', new_job['uuid'] + assert_equal '4fe459abe02d9b365932b8f5dc419439ab4e2577', new_job['script_version'] + end + test "can reuse a Job with a Docker image" do + post(:create, { + job: { + script: "hash", + script_version: "4fe459abe02d9b365932b8f5dc419439ab4e2577", + repository: "foo", + script_parameters: { + input: 'fa7aeb5140e2848d39b416daeef4ffc5+45', + an_integer: '1' + }, + runtime_constraints: { + docker_image: 'arvados/apitestfixture', + } + }, + find_or_create: true, + }) + assert_response :success + new_job = assigns(:object) + assert_not_nil new_job + target_job = jobs(:previous_docker_job_run) + [:uuid, :script_version, :docker_image_locator].each do |attr| + assert_equal(target_job.send(attr), new_job.send(attr)) + end + end + + test "can reuse a Job with a Docker image hash filter" do + filter_h = BASE_FILTERS. + merge("script_version" => + ["=", "4fe459abe02d9b365932b8f5dc419439ab4e2577"], + "docker_image_locator" => + ["in docker", links(:docker_image_collection_hash).name]) + post(:create, { + job: { + script: "hash", + script_version: "4fe459abe02d9b365932b8f5dc419439ab4e2577", + repository: "foo", + script_parameters: { + input: 'fa7aeb5140e2848d39b416daeef4ffc5+45', + an_integer: '1' + }, + }, + filters: filters_from_hash(filter_h), + find_or_create: true, + }) + assert_response :success + new_job = assigns(:object) + assert_not_nil new_job + target_job = jobs(:previous_docker_job_run) + [:uuid, :script_version, :docker_image_locator].each do |attr| + assert_equal(target_job.send(attr), new_job.send(attr)) + end + end + + test "reuse Job with Docker image repo+tag" do + filter_h = BASE_FILTERS. + merge("script_version" => + ["=", "4fe459abe02d9b365932b8f5dc419439ab4e2577"], + "docker_image_locator" => + ["in docker", links(:docker_image_collection_tag2).name]) + post(:create, { + job: { + script: "hash", + script_version: "4fe459abe02d9b365932b8f5dc419439ab4e2577", + repository: "foo", + script_parameters: { + input: 'fa7aeb5140e2848d39b416daeef4ffc5+45', + an_integer: '1' + }, + }, + filters: filters_from_hash(filter_h), + find_or_create: true, + }) + assert_response :success + new_job = assigns(:object) + assert_not_nil new_job + target_job = jobs(:previous_docker_job_run) + [:uuid, :script_version, :docker_image_locator].each do |attr| + assert_equal(target_job.send(attr), new_job.send(attr)) + end + end + + test "new job with unknown Docker image filter" do + filter_h = BASE_FILTERS. + merge("docker_image_locator" => ["in docker", "_nonesuchname_"]) + post(:create, { + job: { + script: "hash", + script_version: "4fe459abe02d9b365932b8f5dc419439ab4e2577", + repository: "foo", + script_parameters: { + input: 'fa7aeb5140e2848d39b416daeef4ffc5+45', + an_integer: '1' + }, + }, + filters: filters_from_hash(filter_h), + find_or_create: true, + }) + assert_response :success + new_job = assigns(:object) + assert_not_nil new_job + assert_not_equal(jobs(:previous_docker_job_run).uuid, new_job.uuid) + end + + ["repository", "script"].each do |skip_key| + test "missing #{skip_key} filter raises an error" do + filter_a = filters_from_hash(BASE_FILTERS.reject { |k| k == skip_key }) + post(:create, { + job: { + script: "hash", + script_version: "master", + repository: "foo", + script_parameters: { + input: 'fa7aeb5140e2848d39b416daeef4ffc5+45', + an_integer: '1' + } + }, + filters: filter_a, + find_or_create: true, + }) + assert_includes(405..599, @response.code.to_i, + "bad status code with missing #{skip_key} filter") + end + end + + test "find Job with script version range" do + get :index, filters: [["repository", "=", "foo"], + ["script", "=", "hash"], + ["script_version", "in git", "tag1"]] + assert_response :success + assert_not_nil assigns(:objects) + assert_includes(assigns(:objects).map { |job| job.uuid }, + jobs(:previous_job_run).uuid) + end + + test "find Job with script version range exclusions" do + get :index, filters: [["repository", "=", "foo"], + ["script", "=", "hash"], + ["script_version", "not in git", "tag1"]] + assert_response :success + assert_not_nil assigns(:objects) + refute_includes(assigns(:objects).map { |job| job.uuid }, + jobs(:previous_job_run).uuid) + end + + test "find Job with Docker image range" do + get :index, filters: [["docker_image_locator", "in docker", + "arvados/apitestfixture"]] + assert_response :success + assert_not_nil assigns(:objects) + assert_includes(assigns(:objects).map { |job| job.uuid }, + jobs(:previous_docker_job_run).uuid) + refute_includes(assigns(:objects).map { |job| job.uuid }, + jobs(:previous_job_run).uuid) + end + + test "find Job with Docker image using reader tokens" do + authorize_with :inactive + get(:index, { + filters: [["docker_image_locator", "in docker", + "arvados/apitestfixture"]], + reader_tokens: [api_token(:active)], + }) + assert_response :success + assert_not_nil assigns(:objects) + assert_includes(assigns(:objects).map { |job| job.uuid }, + jobs(:previous_docker_job_run).uuid) + refute_includes(assigns(:objects).map { |job| job.uuid }, + jobs(:previous_job_run).uuid) + end + + test "'in docker' filter accepts arrays" do + get :index, filters: [["docker_image_locator", "in docker", + ["_nonesuchname_", "arvados/apitestfixture"]]] + assert_response :success + assert_not_nil assigns(:objects) + assert_includes(assigns(:objects).map { |job| job.uuid }, + jobs(:previous_docker_job_run).uuid) + refute_includes(assigns(:objects).map { |job| job.uuid }, + jobs(:previous_job_run).uuid) + end + + test "'not in docker' filter accepts arrays" do + get :index, filters: [["docker_image_locator", "not in docker", + ["_nonesuchname_", "arvados/apitestfixture"]]] + assert_response :success + assert_not_nil assigns(:objects) + assert_includes(assigns(:objects).map { |job| job.uuid }, + jobs(:previous_job_run).uuid) + refute_includes(assigns(:objects).map { |job| job.uuid }, + jobs(:previous_docker_job_run).uuid) + end + + def create_foo_hash_job_params(params) + if not params.has_key?(:find_or_create) + params[:find_or_create] = true + end + job_attrs = params.delete(:job) || {} + params[:job] = { + script: "hash", + script_version: "4fe459abe02d9b365932b8f5dc419439ab4e2577", + repository: "foo", + script_parameters: { + input: 'fa7aeb5140e2848d39b416daeef4ffc5+45', + an_integer: '1', + }, + }.merge(job_attrs) + params + end + + def check_new_job_created_from(params) + start_time = Time.now + post(:create, create_foo_hash_job_params(params)) + assert_response :success + new_job = assigns(:object) + assert_not_nil new_job + assert_operator(start_time, :<=, new_job.created_at) + new_job + end + + def check_errors_from(params) + post(:create, create_foo_hash_job_params(params)) + assert_includes(405..499, @response.code.to_i) + errors = json_response.fetch("errors", []) + assert(errors.any?, "no errors assigned from #{params}") + refute(errors.any? { |msg| msg =~ /^#<[A-Za-z]+: / }, + "errors include raw exception") + errors + end + + # 1de84a8 is on the b1 branch, after master's tip. + test "new job created from unsatisfiable minimum version filter" do + filter_h = BASE_FILTERS.merge("script_version" => ["in git", "1de84a8"]) + check_new_job_created_from(filters: filters_from_hash(filter_h)) + end + + test "new job created from unsatisfiable minimum version parameter" do + check_new_job_created_from(minimum_script_version: "1de84a8") + end + + test "new job created from unsatisfiable minimum version attribute" do + check_new_job_created_from(job: {minimum_script_version: "1de84a8"}) + end + + test "graceful error from nonexistent minimum version filter" do + filter_h = BASE_FILTERS.merge("script_version" => + ["in git", "__nosuchbranch__"]) + errors = check_errors_from(filters: filters_from_hash(filter_h)) + assert(errors.any? { |msg| msg.include? "__nosuchbranch__" }, + "bad refspec not mentioned in error message") + end + + test "graceful error from nonexistent minimum version parameter" do + errors = check_errors_from(minimum_script_version: "__nosuchbranch__") + assert(errors.any? { |msg| msg.include? "__nosuchbranch__" }, + "bad refspec not mentioned in error message") + end + + test "graceful error from nonexistent minimum version attribute" do + errors = check_errors_from(job: {minimum_script_version: "__nosuchbranch__"}) + assert(errors.any? { |msg| msg.include? "__nosuchbranch__" }, + "bad refspec not mentioned in error message") + end end