X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/bef091f69353d5a1ec7ef6c4e84f81756023596b..08fe9bab402a591674993e6cd472570967e92dec:/sdk/cli/test/test_arv-keep-get.rb diff --git a/sdk/cli/test/test_arv-keep-get.rb b/sdk/cli/test/test_arv-keep-get.rb index 2aa1e67248..41e997b2bb 100644 --- a/sdk/cli/test/test_arv-keep-get.rb +++ b/sdk/cli/test/test_arv-keep-get.rb @@ -21,15 +21,17 @@ class TestArvKeepGet < Minitest::Test assert_arv_get false end assert_equal '', out - assert_match /^usage:/, err + assert_match(/^usage:/, err) end def test_get_version out, err = capture_subprocess_io do assert_arv_get '--version' end - assert_empty(out, "STDOUT not expected: '#{out}'") - assert_match(/[0-9]+\.[0-9]+\.[0-9]+/, err, "Version information incorrect: '#{err}'") + # python3 handles action='version' differently than python2 + # https://dev.arvados.org/issues/15888#note-23 + assert_empty(err, "STDERR not expected: '#{err}'") + assert_match(/[0-9]+\.[0-9]+\.[0-9]+/, out, "Version information incorrect: '#{out}'") end def test_help @@ -38,7 +40,7 @@ class TestArvKeepGet < Minitest::Test end $stderr.write err assert_equal '', err - assert_match /^usage:/, out + assert_match(/^usage:/, out) end def test_file_to_dev_stdout @@ -70,7 +72,7 @@ class TestArvKeepGet < Minitest::Test out, err = capture_subprocess_io do assert_arv_get false, @@foo_manifest_locator + '/foo', 'tmp/foo' end - assert_match /Local file tmp\/foo already exists/, err + assert_match(/Local file tmp\/foo already exists/, err) assert_equal '', out assert_equal 'baz', IO.read('tmp/foo') end @@ -82,7 +84,7 @@ class TestArvKeepGet < Minitest::Test out, err = capture_subprocess_io do assert_arv_get false, @@foo_manifest_locator + '/', 'tmp/' end - assert_match /Local file tmp\/foo already exists/, err + assert_match(/Local file tmp\/foo already exists/, err) assert_equal '', out assert_equal 'baz', IO.read('tmp/foo') end @@ -128,7 +130,7 @@ class TestArvKeepGet < Minitest::Test assert_arv_get false, @@foo_manifest_locator + '/', 'tmp/foo' end assert_equal '', out - assert_match /^usage:/, err + assert_match(/^usage:/, err) end def test_dir_to_empty_string @@ -136,7 +138,7 @@ class TestArvKeepGet < Minitest::Test assert_arv_get false, @@foo_manifest_locator + '/', '' end assert_equal '', out - assert_match /^usage:/, err + assert_match(/^usage:/, err) end def test_nonexistent_block @@ -144,7 +146,7 @@ class TestArvKeepGet < Minitest::Test assert_arv_get false, 'e796ab2294f3e48ec709ffa8d6daf58c' end assert_equal '', out - assert_match /ERROR:/, err + assert_match(/ERROR:/, err) end def test_nonexistent_manifest @@ -152,7 +154,7 @@ class TestArvKeepGet < Minitest::Test assert_arv_get false, 'acbd18db4cc2f85cedef654fccc4a4d8/', 'tmp/' end assert_equal '', out - assert_match /ERROR:/, err + assert_match(/ERROR:/, err) end def test_manifest_root_to_dir