X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/bd720586c0152ca4e7d109389bda2c0e463c76bb..f81f84e19902e37c28fd1610999cfefa1c4a0b71:/services/api/lib/record_filters.rb diff --git a/services/api/lib/record_filters.rb b/services/api/lib/record_filters.rb index 1e6be5f5ac..350c3802fc 100644 --- a/services/api/lib/record_filters.rb +++ b/services/api/lib/record_filters.rb @@ -42,11 +42,16 @@ module RecordFilters if attrs_in != 'any' raise ArgumentError.new("Full text search on individual columns is not supported") end - attrs = [] # skip the generic per-column operator loop below - # Use to_tsquery since plainto_tsquery does not support prefix search. - # Instead split operand, add ':*' to each word and join the words with ' & ' + if operand.is_a? Array + raise ArgumentError.new("Full text search not supported for array operands") + end + + # Skip the generic per-column operator loop below + attrs = [] + # Use to_tsquery since plainto_tsquery does not support prefix + # search. And, split operand and join the words with ' & ' cond_out << model_class.full_text_tsvector+" @@ to_tsquery(?)" - param_out << operand.split.each {|s| s.concat(':*')}.join(' & ') + param_out << operand.split.join(' & ') end attrs.each do |attr| if !model_class.searchable_columns(operator).index attr.to_s @@ -72,7 +77,12 @@ module RecordFilters "boolean attribute '#{attr}'") end end - cond_out << "#{ar_table_name}.#{attr} #{operator} ?" + if operator == '<>' + # explicitly allow NULL + cond_out << "#{ar_table_name}.#{attr} #{operator} ? OR #{ar_table_name}.#{attr} IS NULL" + else + cond_out << "#{ar_table_name}.#{attr} #{operator} ?" + end if (# any operator that operates on value rather than # representation: operator.match(/[<=>]/) and (attr_type == :datetime))