X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/bb45025e80abc00f8da524d9a78c0bab976d4f3a..2993bc9aea20c2295d1b2b3cbecf3b1f7e06bb17:/services/api/test/unit/user_test.rb diff --git a/services/api/test/unit/user_test.rb b/services/api/test/unit/user_test.rb index 6cee757ee1..4df6cc0b36 100644 --- a/services/api/test/unit/user_test.rb +++ b/services/api/test/unit/user_test.rb @@ -7,23 +7,227 @@ class UserTest < ActiveSupport::TestCase setup do # Make sure system_user exists before making "pre-test users" list system_user + end - @all_users = User.find(:all) + %w(a aa a0 aA Aa AA A0).each do |username| + test "#{username.inspect} is a valid username" do + user = User.new(username: username) + assert(user.valid?) + end + end + + test "username is not required" do + user = User.new(username: nil) + assert(user.valid?) + end + + test "username beginning with numeral is invalid" do + user = User.new(username: "0a") + refute(user.valid?) + end + + "\\.-_/!@#$%^&*()[]{}".each_char do |bad_char| + test "username containing #{bad_char.inspect} is invalid" do + user = User.new(username: "bad#{bad_char}username") + refute(user.valid?) + end + end + + test "username must be unique" do + user = User.new(username: users(:active).username) + refute(user.valid?) + end + + test "non-admin can't update username" do + set_user_from_auth :rominiadmin + user = User.find_by_uuid(users(:rominiadmin).uuid) + user.username = "selfupdate" + assert_not_allowed { user.save } + end + + def check_admin_username_change(fixture_name) + set_user_from_auth :admin_trustedclient + user = User.find_by_uuid(users(fixture_name).uuid) + user.username = "newnamefromtest" + assert(user.save) + end + + test "admin can set username" do + check_admin_username_change(:active_no_prefs) + end - @all_users.each do |user| - if user.uuid == system_user_uuid - @system_user = user - elsif user.is_admin && user.is_active - @admin_user = user - elsif user.is_active && !user.is_admin - @active_user = user - elsif !user.is_active && !user.is_invited - @uninvited_user = user + test "admin can update username" do + check_admin_username_change(:active) + end + + test "admin can update own username" do + check_admin_username_change(:admin) + end + + def check_new_username_setting(email_name, expect_name) + set_user_from_auth :admin + user = User.create!(email: "#{email_name}@example.org") + assert_equal(expect_name, user.username) + end + + test "new username set from e-mail" do + check_new_username_setting("dakota", "dakota") + end + + test "new username set from e-mail with leading digits" do + check_new_username_setting("1dakota9", "dakota9") + end + + test "new username set from e-mail with punctuation" do + check_new_username_setting("dakota.9", "dakota9") + end + + test "new username set from e-mail with leading digits and punctuation" do + check_new_username_setting("1.dakota.z", "dakotaz") + end + + test "new username set from e-mail with extra part" do + check_new_username_setting("dakota+arvados", "dakota") + end + + test "new username set with deduplication" do + name = users(:active).username + check_new_username_setting(name, "#{name}2") + check_new_username_setting(name, "#{name}3") + # Insert some out-of-order conflicts, to ensure our "sort by + # username, stop when we see a hole" strategy doesn't depend on + # insert order. + check_new_username_setting("#{name}13", "#{name}13") + check_new_username_setting("#{name}5", "#{name}5") + check_new_username_setting(name, "#{name}4") + 6.upto(12).each do |n| + check_new_username_setting(name, "#{name}#{n}") + end + end + + test "new username set avoiding blacklist" do + Rails.configuration.auto_setup_name_blacklist = ["root"] + check_new_username_setting("root", "root2") + end + + test "no username set when no base available" do + check_new_username_setting("_", nil) + end + + test "updating username updates repository names" do + set_user_from_auth :admin + user = users(:active) + user.username = "newtestname" + assert(user.save, "username update failed") + {foo: "newtestname/foo", repository2: "newtestname/foo2"}. + each_pair do |repo_sym, expect_name| + assert_equal(expect_name, repositories(repo_sym).name) + end + end + + test "admin can clear username when user owns no repositories" do + set_user_from_auth :admin + user = users(:spectator) + user.username = nil + assert(user.save) + assert_nil(user.username) + end + + test "admin can't clear username when user owns repositories" do + set_user_from_auth :admin + user = users(:active) + start_username = user.username + user.username = nil + assert_not_allowed { user.save } + refute_empty(user.errors[:username]) + end + + test "failed username update doesn't change repository names" do + set_user_from_auth :admin + user = users(:active) + user.username = users(:fuse).username + assert_not_allowed { user.save } + assert_equal("active/foo", repositories(:foo).name) + end + + [[false, 'foo@example.com', true, nil], + [false, 'bar@example.com', nil, true], + [true, 'foo@example.com', true, nil], + [true, 'bar@example.com', true, true], + [false, false, nil, nil], + [true, false, true, nil] + ].each do |auto_admin_first_user_config, auto_admin_user_config, foo_should_be_admin, bar_should_be_admin| + # In each case, 'foo' is created first, then 'bar', then 'bar2', then 'baz'. + test "auto admin with auto_admin_first=#{auto_admin_first_user_config} auto_admin=#{auto_admin_user_config}" do + + if auto_admin_first_user_config + # This test requires no admin users exist (except for the system user) + users(:admin).delete + @all_users = User.where("uuid not like '%-000000000000000'").where(:is_admin => true).find(:all) + assert_equal 0, @all_users.size, "No admin users should exist (except for the system user)" + end + + Rails.configuration.auto_admin_first_user = auto_admin_first_user_config + Rails.configuration.auto_admin_user = auto_admin_user_config + + # See if the foo user has is_admin + foo = User.new + foo.first_name = 'foo' + foo.email = 'foo@example.com' + + act_as_system_user do + foo.save! end + + foo = User.find(foo.id) # get the user back + assert_equal foo_should_be_admin, foo.is_admin, "is_admin is wrong for user foo" + assert_equal 'foo', foo.first_name + + # See if the bar user has is_admin + bar = User.new + bar.first_name = 'bar' + bar.email = 'bar@example.com' + + act_as_system_user do + bar.save! + end + + bar = User.find(bar.id) # get the user back + assert_equal bar_should_be_admin, bar.is_admin, "is_admin is wrong for user bar" + assert_equal 'bar', bar.first_name + + # A subsequent user with the bar@example.com address should never be + # elevated to admin + bar2 = User.new + bar2.first_name = 'bar2' + bar2.email = 'bar@example.com' + + act_as_system_user do + bar2.save! + end + + bar2 = User.find(bar2.id) # get the user back + assert !bar2.is_admin, "is_admin is wrong for user bar2" + assert_equal 'bar2', bar2.first_name + + # An ordinary new user should not be elevated to admin + baz = User.new + baz.first_name = 'baz' + baz.email = 'baz@example.com' + + act_as_system_user do + baz.save! + end + + baz = User.find(baz.id) # get the user back + assert !baz.is_admin + assert_equal 'baz', baz.first_name + end end test "check non-admin active user properties" do + @active_user = users(:active) # get the active user assert !@active_user.is_admin, 'is_admin should not be set for a non-admin user' assert @active_user.is_active, 'user should be active' assert @active_user.is_invited, 'is_invited should be set' @@ -35,12 +239,14 @@ class UserTest < ActiveSupport::TestCase assert @active_user.groups_i_can(:read).size > 0, "active user should be able read at least one group" # non-admin user cannot manage or write other user objects + @uninvited_user = users(:inactive_uninvited) # get the uninvited user assert !(@active_user.can? :read=>"#{@uninvited_user.uuid}") assert !(@active_user.can? :write=>"#{@uninvited_user.uuid}") assert !(@active_user.can? :manage=>"#{@uninvited_user.uuid}") end test "check admin user properties" do + @admin_user = users(:admin) # get the admin user assert @admin_user.is_admin, 'is_admin should be set for admin user' assert @admin_user.is_active, 'admin user cannot be inactive' assert @admin_user.is_invited, 'is_invited should be set' @@ -56,12 +262,14 @@ class UserTest < ActiveSupport::TestCase assert @admin_user.groups_i_can(:manage).size > 0, "admin active user should be able manage at least one group" # admin user can also write or manage other users + @uninvited_user = users(:inactive_uninvited) # get the uninvited user assert @admin_user.can? :read=>"#{@uninvited_user.uuid}" assert @admin_user.can? :write=>"#{@uninvited_user.uuid}" assert @admin_user.can? :manage=>"#{@uninvited_user.uuid}" end test "check inactive and uninvited user properties" do + @uninvited_user = users(:inactive_uninvited) # get the uninvited user assert !@uninvited_user.is_admin, 'is_admin should not be set for a non-admin user' assert !@uninvited_user.is_active, 'user should be inactive' assert !@uninvited_user.is_invited, 'is_invited should not be set' @@ -69,7 +277,8 @@ class UserTest < ActiveSupport::TestCase assert @uninvited_user.can? :write=>"#{@uninvited_user.uuid}" assert @uninvited_user.can? :manage=>"#{@uninvited_user.uuid}" - assert @uninvited_user.groups_i_can(:read).size == 0, "inactive and uninvited user should not be able read any groups" + assert @uninvited_user.groups_i_can(:read).size == 1, "inactive and uninvited user can only read anonymous user group" + assert @uninvited_user.groups_i_can(:read).first.ends_with? 'anonymouspublic' , "inactive and uninvited user can only read anonymous user group" assert @uninvited_user.groups_i_can(:write).size == 0, "inactive and uninvited user should not be able write to any groups" assert @uninvited_user.groups_i_can(:manage).size == 0, "inactive and uninvited user should not be able manage any groups" end @@ -87,8 +296,23 @@ class UserTest < ActiveSupport::TestCase assert_equal found_user.identity_url, user.identity_url end + test "full name should not contain spurious whitespace" do + set_user_from_auth :admin + + user = User.create ({uuid: 'zzzzz-tpzed-abcdefghijklmno', email: 'foo@example.com' }) + + assert_equal '', user.full_name + + user.first_name = 'John' + user.last_name = 'Smith' + + assert_equal user.first_name + ' ' + user.last_name, user.full_name + end + test "create new user" do - Thread.current[:user] = @admin_user # set admin user as the current user + set_user_from_auth :admin + + @all_users = User.find(:all) user = User.new user.first_name = "first_name_for_newly_created_user" @@ -109,8 +333,71 @@ class UserTest < ActiveSupport::TestCase assert_equal(user.first_name, 'first_name_for_newly_created_user_updated') end + test "create new user with notifications" do + set_user_from_auth :admin + + create_user_and_verify_setup_and_notifications true, 'active-notify-address@example.com', 'inactive-notify-address@example.com', nil, nil + create_user_and_verify_setup_and_notifications true, 'active-notify-address@example.com', [], nil, nil + create_user_and_verify_setup_and_notifications true, [], [], nil, nil + create_user_and_verify_setup_and_notifications false, 'active-notify-address@example.com', 'inactive-notify-address@example.com', nil, nil + create_user_and_verify_setup_and_notifications false, [], 'inactive-notify-address@example.com', nil, nil + create_user_and_verify_setup_and_notifications false, [], [], nil, nil + end + + [ + # Easy inactive user tests. + [false, [], [], "inactive-none@example.com", false, false, "inactivenone"], + [false, [], [], "inactive-vm@example.com", true, false, "inactivevm"], + [false, [], [], "inactive-repo@example.com", false, true, "inactiverepo"], + [false, [], [], "inactive-both@example.com", true, true, "inactiveboth"], + + # Easy active user tests. + [true, "active-notify@example.com", "inactive-notify@example.com", "active-none@example.com", false, false, "activenone"], + [true, "active-notify@example.com", "inactive-notify@example.com", "active-vm@example.com", true, false, "activevm"], + [true, "active-notify@example.com", "inactive-notify@example.com", "active-repo@example.com", false, true, "activerepo"], + [true, "active-notify@example.com", "inactive-notify@example.com", "active-both@example.com", true, true, "activeboth"], + + # Test users with malformed e-mail addresses. + [false, [], [], nil, true, true, nil], + [false, [], [], "arvados", true, true, nil], + [false, [], [], "@example.com", true, true, nil], + [true, "active-notify@example.com", "inactive-notify@example.com", "*!*@example.com", true, false, nil], + [true, "active-notify@example.com", "inactive-notify@example.com", "*!*@example.com", false, false, nil], + + # Test users with various username transformations. + [false, [], [], "arvados@example.com", false, false, "arvados2"], + [true, "active-notify@example.com", "inactive-notify@example.com", "arvados@example.com", false, false, "arvados2"], + [true, "active-notify@example.com", "inactive-notify@example.com", "root@example.com", true, false, "root2"], + [false, "active-notify@example.com", "inactive-notify@example.com", "root@example.com", true, false, "root2"], + [true, "active-notify@example.com", "inactive-notify@example.com", "roo_t@example.com", false, true, "root2"], + [false, [], [], "^^incorrect_format@example.com", true, true, "incorrectformat"], + [true, "active-notify@example.com", "inactive-notify@example.com", "&4a_d9.@example.com", true, true, "ad9"], + [true, "active-notify@example.com", "inactive-notify@example.com", "&4a_d9.@example.com", false, false, "ad9"], + [false, "active-notify@example.com", "inactive-notify@example.com", "&4a_d9.@example.com", true, true, "ad9"], + [false, "active-notify@example.com", "inactive-notify@example.com", "&4a_d9.@example.com", false, false, "ad9"], + ].each do |active, new_user_recipients, inactive_recipients, email, auto_setup_vm, auto_setup_repo, expect_username| + test "create new user with auto setup #{active} #{email} #{auto_setup_vm} #{auto_setup_repo}" do + set_user_from_auth :admin + + Rails.configuration.auto_setup_new_users = true + + if auto_setup_vm + Rails.configuration.auto_setup_new_users_with_vm_uuid = virtual_machines(:testvm)['uuid'] + else + Rails.configuration.auto_setup_new_users_with_vm_uuid = false + end + + Rails.configuration.auto_setup_new_users_with_repository = auto_setup_repo + + create_user_and_verify_setup_and_notifications active, new_user_recipients, inactive_recipients, email, expect_username + end + end + test "update existing user" do - Thread.current[:user] = @active_user # set active user as current user + set_user_from_auth :active # set active user as current user + + @active_user = users(:active) # get the active user + @active_user.first_name = "first_name_changed" @active_user.save @@ -118,7 +405,7 @@ class UserTest < ActiveSupport::TestCase assert_equal(@active_user.first_name, 'first_name_changed') # admin user also should be able to update the "active" user info - Thread.current[:user] = @admin_user # set admin user as current user + set_user_from_auth :admin # set admin user as current user @active_user.first_name = "first_name_changed_by_admin_for_active_user" @active_user.save @@ -127,9 +414,10 @@ class UserTest < ActiveSupport::TestCase end test "delete a user and verify" do + @active_user = users(:active) # get the active user active_user_uuid = @active_user.uuid - Thread.current[:user] = @admin_user + set_user_from_auth :admin @active_user.delete found_deleted_user = false @@ -144,19 +432,12 @@ class UserTest < ActiveSupport::TestCase end test "create new user as non-admin user" do - Thread.current[:user] = @active_user - - begin - user = User.new - user.save - rescue ArvadosModel::PermissionDeniedError => e - end - assert (e.message.include? 'PermissionDeniedError'), - 'Expected PermissionDeniedError' + set_user_from_auth :active + assert_not_allowed { User.new.save } end test "setup new user" do - Thread.current[:user] = @admin_user + set_user_from_auth :admin email = 'foo@example.com' openid_prefix = 'http://openid/prefix' @@ -165,7 +446,7 @@ class UserTest < ActiveSupport::TestCase vm = VirtualMachine.create - response = User.setup user, openid_prefix, 'test_repo', vm.uuid + response = User.setup user, openid_prefix, 'foo/testrepo', vm.uuid resp_user = find_obj_in_resp response, 'User' verify_user resp_user, email @@ -175,21 +456,65 @@ class UserTest < ActiveSupport::TestCase verify_link oid_login_perm, 'permission', 'can_login', resp_user[:email], resp_user[:uuid] - assert_equal openid_prefix, oid_login_perm[:properties][:identity_url_prefix], + assert_equal openid_prefix, oid_login_perm[:properties]['identity_url_prefix'], 'expected identity_url_prefix not found for oid_login_perm' group_perm = find_obj_in_resp response, 'Link', 'arvados#group' verify_link group_perm, 'permission', 'can_read', resp_user[:uuid], nil repo_perm = find_obj_in_resp response, 'Link', 'arvados#repository' - verify_link repo_perm, 'permission', 'can_write', resp_user[:uuid], nil + verify_link repo_perm, 'permission', 'can_manage', resp_user[:uuid], nil vm_perm = find_obj_in_resp response, 'Link', 'arvados#virtualMachine' verify_link vm_perm, 'permission', 'can_login', resp_user[:uuid], vm.uuid + assert_equal("foo", vm_perm.properties["username"]) + end + + test "setup new user with junk in database" do + set_user_from_auth :admin + + email = 'foo@example.com' + openid_prefix = 'http://openid/prefix' + + user = User.create ({uuid: 'zzzzz-tpzed-abcdefghijklmno', email: email}) + + vm = VirtualMachine.create + + # Set up the bogus Link + bad_uuid = 'zzzzz-tpzed-xyzxyzxyzxyzxyz' + + resp_link = Link.create ({tail_uuid: email, link_class: 'permission', + name: 'can_login', head_uuid: bad_uuid}) + resp_link.save(validate: false) + + verify_link resp_link, 'permission', 'can_login', email, bad_uuid + + response = User.setup user, openid_prefix, 'foo/testrepo', vm.uuid + + resp_user = find_obj_in_resp response, 'User' + verify_user resp_user, email + + oid_login_perm = find_obj_in_resp response, 'Link', 'arvados#user' + + verify_link oid_login_perm, 'permission', 'can_login', resp_user[:email], + resp_user[:uuid] + + assert_equal openid_prefix, oid_login_perm[:properties]['identity_url_prefix'], + 'expected identity_url_prefix not found for oid_login_perm' + + group_perm = find_obj_in_resp response, 'Link', 'arvados#group' + verify_link group_perm, 'permission', 'can_read', resp_user[:uuid], nil + + repo_perm = find_obj_in_resp response, 'Link', 'arvados#repository' + verify_link repo_perm, 'permission', 'can_manage', resp_user[:uuid], nil + + vm_perm = find_obj_in_resp response, 'Link', 'arvados#virtualMachine' + verify_link vm_perm, 'permission', 'can_login', resp_user[:uuid], vm.uuid + assert_equal("foo", vm_perm.properties["username"]) end test "setup new user in multiple steps" do - Thread.current[:user] = @admin_user + set_user_from_auth :admin email = 'foo@example.com' openid_prefix = 'http://openid/prefix' @@ -204,14 +529,14 @@ class UserTest < ActiveSupport::TestCase oid_login_perm = find_obj_in_resp response, 'Link', 'arvados#user' verify_link oid_login_perm, 'permission', 'can_login', resp_user[:email], resp_user[:uuid] - assert_equal openid_prefix, oid_login_perm[:properties][:identity_url_prefix], + assert_equal openid_prefix, oid_login_perm[:properties]['identity_url_prefix'], 'expected identity_url_prefix not found for oid_login_perm' group_perm = find_obj_in_resp response, 'Link', 'arvados#group' verify_link group_perm, 'permission', 'can_read', resp_user[:uuid], nil # invoke setup again with repo_name - response = User.setup user, openid_prefix, 'test_repo' + response = User.setup user, openid_prefix, 'foo/testrepo' resp_user = find_obj_in_resp response, 'User', nil verify_user resp_user, email assert_equal user.uuid, resp_user[:uuid], 'expected uuid not found' @@ -220,12 +545,12 @@ class UserTest < ActiveSupport::TestCase verify_link group_perm, 'permission', 'can_read', resp_user[:uuid], nil repo_perm = find_obj_in_resp response, 'Link', 'arvados#repository' - verify_link repo_perm, 'permission', 'can_write', resp_user[:uuid], nil + verify_link repo_perm, 'permission', 'can_manage', resp_user[:uuid], nil # invoke setup again with a vm_uuid vm = VirtualMachine.create - response = User.setup user, openid_prefix, 'test_repo', vm.uuid + response = User.setup user, openid_prefix, 'foo/testrepo', vm.uuid resp_user = find_obj_in_resp response, 'User', nil verify_user resp_user, email @@ -235,10 +560,11 @@ class UserTest < ActiveSupport::TestCase verify_link group_perm, 'permission', 'can_read', resp_user[:uuid], nil repo_perm = find_obj_in_resp response, 'Link', 'arvados#repository' - verify_link repo_perm, 'permission', 'can_write', resp_user[:uuid], nil + verify_link repo_perm, 'permission', 'can_manage', resp_user[:uuid], nil vm_perm = find_obj_in_resp response, 'Link', 'arvados#virtualMachine' verify_link vm_perm, 'permission', 'can_login', resp_user[:uuid], vm.uuid + assert_equal("foo", vm_perm.properties["username"]) end def find_obj_in_resp (response_items, object_type, head_kind=nil) @@ -286,4 +612,101 @@ class UserTest < ActiveSupport::TestCase end end + def create_user_and_verify_setup_and_notifications (active, new_user_recipients, inactive_recipients, email, expect_username) + Rails.configuration.new_user_notification_recipients = new_user_recipients + Rails.configuration.new_inactive_user_notification_recipients = inactive_recipients + + ActionMailer::Base.deliveries = [] + + can_setup = (Rails.configuration.auto_setup_new_users and + (not expect_username.nil?)) + expect_repo_name = "#{expect_username}/#{expect_username}" + prior_repo = Repository.where(name: expect_repo_name).first + + user = User.new + user.first_name = "first_name_for_newly_created_user" + user.email = email + user.is_active = active + user.save! + assert_equal(expect_username, user.username) + + # check user setup + verify_link_exists(Rails.configuration.auto_setup_new_users, + groups(:all_users).uuid, user.uuid, + "permission", "can_read") + # Check for OID login link. + verify_link_exists(Rails.configuration.auto_setup_new_users, + user.uuid, user.email, "permission", "can_login") + # Check for repository. + if named_repo = (prior_repo or + Repository.where(name: expect_repo_name).first) + verify_link_exists((can_setup and prior_repo.nil? and + Rails.configuration.auto_setup_new_users_with_repository), + named_repo.uuid, user.uuid, "permission", "can_manage") + end + # Check for VM login. + if auto_vm_uuid = Rails.configuration.auto_setup_new_users_with_vm_uuid + verify_link_exists(can_setup, auto_vm_uuid, user.uuid, + "permission", "can_login", "username", expect_username) + end + + # check email notifications + new_user_email = nil + new_inactive_user_email = nil + + new_user_email_subject = "#{Rails.configuration.email_subject_prefix}New user created notification" + if Rails.configuration.auto_setup_new_users + new_user_email_subject = (expect_username or active) ? + "#{Rails.configuration.email_subject_prefix}New user created and setup notification" : + "#{Rails.configuration.email_subject_prefix}New user created, but not setup notification" + end + + ActionMailer::Base.deliveries.each do |d| + if d.subject == new_user_email_subject then + new_user_email = d + elsif d.subject == "#{Rails.configuration.email_subject_prefix}New inactive user notification" then + new_inactive_user_email = d + end + end + + # both active and inactive user creations should result in new user creation notification mails, + # if the new user email recipients config parameter is set + if not new_user_recipients.empty? then + assert_not_nil new_user_email, 'Expected new user email after setup' + assert_equal Rails.configuration.user_notifier_email_from, new_user_email.from[0] + assert_equal new_user_recipients, new_user_email.to[0] + assert_equal new_user_email_subject, new_user_email.subject + else + assert_nil new_user_email, 'Did not expect new user email after setup' + end + + if not active + if not inactive_recipients.empty? then + assert_not_nil new_inactive_user_email, 'Expected new inactive user email after setup' + assert_equal Rails.configuration.user_notifier_email_from, new_inactive_user_email.from[0] + assert_equal inactive_recipients, new_inactive_user_email.to[0] + assert_equal "#{Rails.configuration.email_subject_prefix}New inactive user notification", new_inactive_user_email.subject + else + assert_nil new_inactive_user_email, 'Did not expect new inactive user email after setup' + end + else + assert_nil new_inactive_user_email, 'Expected no inactive user email after setting up active user' + end + ActionMailer::Base.deliveries = [] + + end + + def verify_link_exists link_exists, head_uuid, tail_uuid, link_class, link_name, property_name=nil, property_value=nil + all_links = Link.where(head_uuid: head_uuid, + tail_uuid: tail_uuid, + link_class: link_class, + name: link_name) + assert_equal link_exists, all_links.any?, "Link #{'not' if link_exists} found for #{link_name} #{link_class} #{property_value}" + if link_exists && property_name && property_value + all_links.each do |link| + assert_equal true, all_links.first.properties[property_name].start_with?(property_value), 'Property not found in link' + end + end + end + end