X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/b9bf39b18d1e161b6b971270d15c1024ece86243..0c0f18dfbcdcf552889258b76563315fbe2eb060:/services/datamanager/datamanager.go

diff --git a/services/datamanager/datamanager.go b/services/datamanager/datamanager.go
index 301aa81f4e..3c53b4ad2a 100644
--- a/services/datamanager/datamanager.go
+++ b/services/datamanager/datamanager.go
@@ -3,6 +3,7 @@
 package main
 
 import (
+	"errors"
 	"flag"
 	"fmt"
 	"git.curoverse.com/arvados.git/sdk/go/arvadosclient"
@@ -41,31 +42,42 @@ func init() {
 func main() {
 	flag.Parse()
 	if minutesBetweenRuns == 0 {
-		singlerun()
+		arv, err := arvadosclient.MakeArvadosClient()
+		if err != nil {
+			loggerutil.FatalWithMessage(arvLogger, fmt.Sprintf("Error making arvados client: %v", err))
+		}
+		err = singlerun(arv)
+		if err != nil {
+			loggerutil.FatalWithMessage(arvLogger, fmt.Sprintf("singlerun: %v", err))
+		}
 	} else {
 		waitTime := time.Minute * time.Duration(minutesBetweenRuns)
 		for {
 			log.Println("Beginning Run")
-			singlerun()
+			arv, err := arvadosclient.MakeArvadosClient()
+			if err != nil {
+				loggerutil.FatalWithMessage(arvLogger, fmt.Sprintf("Error making arvados client: %v", err))
+			}
+			err = singlerun(arv)
+			if err != nil {
+				log.Printf("singlerun: %v", err)
+			}
 			log.Printf("Sleeping for %d minutes", minutesBetweenRuns)
 			time.Sleep(waitTime)
 		}
 	}
 }
 
-func singlerun() {
-	arv, err := arvadosclient.MakeArvadosClient()
-	if err != nil {
-		log.Fatalf("Error setting up arvados client %s", err.Error())
-	}
+var arvLogger *logger.Logger
 
-	if is_admin, err := util.UserIsAdmin(arv); err != nil {
-		log.Fatalf("Error querying current arvados user %s", err.Error())
-	} else if !is_admin {
-		log.Fatalf("Current user is not an admin. Datamanager can only be run by admins.")
+func singlerun(arv arvadosclient.ArvadosClient) error {
+	var err error
+	if isAdmin, err := util.UserIsAdmin(arv); err != nil {
+		return errors.New("Error verifying admin token: " + err.Error())
+	} else if !isAdmin {
+		return errors.New("Current user is not an admin. Datamanager requires a privileged token.")
 	}
 
-	var arvLogger *logger.Logger
 	if logEventTypePrefix != "" {
 		arvLogger = logger.NewLogger(logger.LoggerParams{
 			Client:          arv,
@@ -79,31 +91,27 @@ func singlerun() {
 	}
 
 	var (
+		dataFetcher     summary.DataFetcher
 		readCollections collection.ReadCollections
 		keepServerInfo  keep.ReadServers
 	)
 
-	if !summary.MaybeReadData(arvLogger, &readCollections, &keepServerInfo) {
-		collectionChannel := make(chan collection.ReadCollections)
-
-		go func() {
-			collectionChannel <- collection.GetCollectionsAndSummarize(
-				collection.GetCollectionsParams{
-					Client:    arv,
-					Logger:    arvLogger,
-					BatchSize: 50})
-		}()
+	if summary.ShouldReadData() {
+		dataFetcher = summary.ReadData
+	} else {
+		dataFetcher = BuildDataFetcher(arv)
+	}
 
-		keepServerInfo = keep.GetKeepServersAndSummarize(
-			keep.GetKeepServersParams{
-				Client: arv,
-				Logger: arvLogger,
-				Limit:  1000})
+	dataFetcher(arvLogger, &readCollections, &keepServerInfo)
 
-		readCollections = <-collectionChannel
+	if readCollections.Err != nil {
+		return readCollections.Err
 	}
 
-	summary.MaybeWriteData(arvLogger, readCollections, keepServerInfo)
+	err = summary.MaybeWriteData(arvLogger, readCollections, keepServerInfo)
+	if err != nil {
+		return err
+	}
 
 	buckets := summary.BucketReplication(readCollections, keepServerInfo)
 	bucketCounts := buckets.Counts()
@@ -113,7 +121,7 @@ func singlerun() {
 
 	log.Printf("Blocks In Collections: %d, "+
 		"\nBlocks In Keep: %d.",
-		len(readCollections.BlockToReplication),
+		len(readCollections.BlockToDesiredReplication),
 		len(keepServerInfo.BlockToServers))
 	log.Println(replicationCounts.PrettyPrint())
 
@@ -126,23 +134,13 @@ func singlerun() {
 
 	kc, err := keepclient.MakeKeepClient(&arv)
 	if err != nil {
-		loggerutil.FatalWithMessage(arvLogger,
-			fmt.Sprintf("Error setting up keep client %s", err.Error()))
+		return fmt.Errorf("Error setting up keep client %v", err.Error())
 	}
 
-	pullServers := summary.ComputePullServers(&kc,
-		&keepServerInfo,
-		readCollections.BlockToReplication,
-		replicationSummary.UnderReplicatedBlocks)
-
-	pullLists := summary.BuildPullLists(pullServers)
-
-	summary.WritePullLists(arvLogger, pullLists)
-
 	// Log that we're finished. We force the recording, since go will
 	// not wait for the write timer before exiting.
 	if arvLogger != nil {
-		arvLogger.FinalUpdate(func(p map[string]interface{}, e map[string]interface{}) {
+		defer arvLogger.FinalUpdate(func(p map[string]interface{}, e map[string]interface{}) {
 			summaryInfo := logger.GetOrCreateMap(p, "summary_info")
 			summaryInfo["block_replication_counts"] = bucketCounts
 			summaryInfo["replication_summary"] = replicationCounts
@@ -151,4 +149,57 @@ func singlerun() {
 			p["run_info"].(map[string]interface{})["finished_at"] = time.Now()
 		})
 	}
+
+	pullServers := summary.ComputePullServers(kc,
+		&keepServerInfo,
+		readCollections.BlockToDesiredReplication,
+		replicationSummary.UnderReplicatedBlocks)
+
+	pullLists := summary.BuildPullLists(pullServers)
+
+	trashLists, trashErr := summary.BuildTrashLists(kc,
+		&keepServerInfo,
+		replicationSummary.KeepBlocksNotInCollections)
+
+	err = summary.WritePullLists(arvLogger, pullLists)
+	if err != nil {
+		return err
+	}
+
+	if trashErr != nil {
+		return err
+	}
+	keep.SendTrashLists(kc, trashLists)
+
+	return nil
+}
+
+// BuildDataFetcher returns a data fetcher that fetches data from remote servers.
+func BuildDataFetcher(arv arvadosclient.ArvadosClient) summary.DataFetcher {
+	return func(arvLogger *logger.Logger,
+		readCollections *collection.ReadCollections,
+		keepServerInfo *keep.ReadServers) {
+		collectionChannel := make(chan collection.ReadCollections)
+
+		go func() {
+			collectionChannel <- collection.GetCollectionsAndSummarize(
+				collection.GetCollectionsParams{
+					Client:    arv,
+					Logger:    arvLogger,
+					BatchSize: 50})
+		}()
+
+		var err error
+		*keepServerInfo, err = keep.GetKeepServersAndSummarize(
+			keep.GetKeepServersParams{
+				Client: arv,
+				Logger: arvLogger,
+				Limit:  1000})
+
+		if err != nil {
+			return
+		}
+
+		*readCollections = <-collectionChannel
+	}
 }