X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/b30dca66a056bc6ee627bab5956dd8884a0e74aa..9f37e0dd819730350a82c229c12e7856c325212e:/services/keepstore/command.go diff --git a/services/keepstore/command.go b/services/keepstore/command.go index 006d244639..0927b18704 100644 --- a/services/keepstore/command.go +++ b/services/keepstore/command.go @@ -15,12 +15,12 @@ import ( "os" "sync" - "git.curoverse.com/arvados.git/lib/config" - "git.curoverse.com/arvados.git/lib/service" - "git.curoverse.com/arvados.git/sdk/go/arvados" - "git.curoverse.com/arvados.git/sdk/go/arvadosclient" - "git.curoverse.com/arvados.git/sdk/go/ctxlog" - "git.curoverse.com/arvados.git/sdk/go/keepclient" + "git.arvados.org/arvados.git/lib/config" + "git.arvados.org/arvados.git/lib/service" + "git.arvados.org/arvados.git/sdk/go/arvados" + "git.arvados.org/arvados.git/sdk/go/arvadosclient" + "git.arvados.org/arvados.git/sdk/go/ctxlog" + "git.arvados.org/arvados.git/sdk/go/keepclient" "github.com/prometheus/client_golang/prometheus" "github.com/sirupsen/logrus" ) @@ -132,6 +132,10 @@ func (h *handler) CheckHealth() error { return h.err } +func (h *handler) Done() <-chan struct{} { + return nil +} + func newHandlerOrErrorHandler(ctx context.Context, cluster *arvados.Cluster, token string, reg *prometheus.Registry) service.Handler { var h handler serviceURL, ok := service.URLFromContext(ctx) @@ -153,9 +157,8 @@ func (h *handler) setup(ctx context.Context, cluster *arvados.Cluster, token str } bufs = newBufferPool(h.Logger, h.Cluster.API.MaxKeepBlobBuffers, BlockSize) - if h.Cluster.API.MaxConcurrentRequests < 1 { - h.Cluster.API.MaxConcurrentRequests = h.Cluster.API.MaxKeepBlobBuffers * 2 - h.Logger.Warnf("API.MaxConcurrentRequests <1 or not specified; defaulting to MaxKeepBlobBuffers * 2 == %d", h.Cluster.API.MaxConcurrentRequests) + if h.Cluster.API.MaxConcurrentRequests > 0 && h.Cluster.API.MaxConcurrentRequests < h.Cluster.API.MaxKeepBlobBuffers { + h.Logger.Warnf("Possible configuration mistake: not useful to set API.MaxKeepBlobBuffers (%d) higher than API.MaxConcurrentRequests (%d)", h.Cluster.API.MaxKeepBlobBuffers, h.Cluster.API.MaxConcurrentRequests) } if h.Cluster.Collections.BlobSigningKey != "" {