X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/b1f3c944c3217b6e42a377f4b0a04985c9cea908..57d3837ca9a8c5e4e71f9741931cc67e908fb3dd:/services/keepstore/logging_router.go

diff --git a/services/keepstore/logging_router.go b/services/keepstore/logging_router.go
index fd4e23467d..47bb6d7717 100644
--- a/services/keepstore/logging_router.go
+++ b/services/keepstore/logging_router.go
@@ -7,14 +7,19 @@ import (
 	"github.com/gorilla/mux"
 	"log"
 	"net/http"
+	"strings"
+	"time"
 )
 
+// LoggingResponseWriter has anonymous fields ResponseWriter and ResponseBody
 type LoggingResponseWriter struct {
 	Status int
 	Length int
 	http.ResponseWriter
+	ResponseBody string
 }
 
+// WriteHeader writes header to ResponseWriter
 func (loggingWriter *LoggingResponseWriter) WriteHeader(code int) {
 	loggingWriter.Status = code
 	loggingWriter.ResponseWriter.WriteHeader(code)
@@ -22,20 +27,31 @@ func (loggingWriter *LoggingResponseWriter) WriteHeader(code int) {
 
 func (loggingWriter *LoggingResponseWriter) Write(data []byte) (int, error) {
 	loggingWriter.Length += len(data)
+	if loggingWriter.Status >= 400 {
+		loggingWriter.ResponseBody += string(data)
+	}
 	return loggingWriter.ResponseWriter.Write(data)
 }
 
+// LoggingRESTRouter is used to add logging capabilities to mux.Router
 type LoggingRESTRouter struct {
 	router *mux.Router
 }
 
+// MakeLoggingRESTRouter initializes LoggingRESTRouter
 func MakeLoggingRESTRouter() *LoggingRESTRouter {
 	router := MakeRESTRouter()
 	return (&LoggingRESTRouter{router})
 }
 
 func (loggingRouter *LoggingRESTRouter) ServeHTTP(resp http.ResponseWriter, req *http.Request) {
-	loggingWriter := LoggingResponseWriter{200, 0, resp}
+	t0 := time.Now()
+	loggingWriter := LoggingResponseWriter{http.StatusOK, 0, resp, ""}
 	loggingRouter.router.ServeHTTP(&loggingWriter, req)
-	log.Printf("[%s] %s %s %d %d", req.RemoteAddr, req.Method, req.URL.Path[1:], loggingWriter.Status, loggingWriter.Length)
+	statusText := http.StatusText(loggingWriter.Status)
+	if loggingWriter.Status >= 400 {
+		statusText = strings.Replace(loggingWriter.ResponseBody, "\n", "", -1)
+	}
+	log.Printf("[%s] %s %s %.6fs %d %d \"%s\"", req.RemoteAddr, req.Method, req.URL.Path[1:], time.Since(t0).Seconds(), loggingWriter.Status, loggingWriter.Length, statusText)
+
 }