X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/afca15637ba53e38238405afb2e14342cca33052..64c74f24fcdfbbef0e08b72c09d85c53390ca3b3:/services/api/test/unit/crunch_dispatch_test.rb

diff --git a/services/api/test/unit/crunch_dispatch_test.rb b/services/api/test/unit/crunch_dispatch_test.rb
index 04b06d747e..3460abe3cc 100644
--- a/services/api/test/unit/crunch_dispatch_test.rb
+++ b/services/api/test/unit/crunch_dispatch_test.rb
@@ -1,7 +1,14 @@
+# Copyright (C) The Arvados Authors. All rights reserved.
+#
+# SPDX-License-Identifier: AGPL-3.0
+
 require 'test_helper'
 require 'crunch_dispatch'
+require 'helpers/git_test_helper'
 
 class CrunchDispatchTest < ActiveSupport::TestCase
+  include GitTestHelper
+
   test 'choose cheaper nodes first' do
     act_as_system_user do
       # Replace test fixtures with a set suitable for testing dispatch
@@ -56,7 +63,8 @@ class CrunchDispatchTest < ActiveSupport::TestCase
      [2, 16384, ['compute2', 'compute1']],
      [2, 8000, ['compute4', 'compute3']],
     ].each do |min_nodes, min_ram, expect_nodes|
-      job = Job.new(runtime_constraints: {
+      job = Job.new(uuid: 'zzzzz-8i9sb-382lhiizavzhqlp',
+                    runtime_constraints: {
                       'min_nodes' => min_nodes,
                       'min_ram_mb_per_node' => min_ram,
                     })
@@ -100,6 +108,30 @@ class CrunchDispatchTest < ActiveSupport::TestCase
     end
   end
 
+  test 'override --cgroup-root with CRUNCH_CGROUP_ROOT' do
+    ENV['CRUNCH_CGROUP_ROOT'] = '/path/to/cgroup'
+    Rails.configuration.crunch_job_wrapper = :none
+    act_as_system_user do
+      j = Job.create(repository: 'active/foo',
+                     script: 'hash',
+                     script_version: '4fe459abe02d9b365932b8f5dc419439ab4e2577',
+                     script_parameters: {})
+      ok = false
+      Open3.expects(:popen3).at_least_once.with do |*args|
+        if args.index(j.uuid)
+          ok = ((i = args.index '--cgroup-root') and
+                (args[i+1] == '/path/to/cgroup'))
+        end
+        true
+      end.raises(StandardError.new('all is well'))
+      dispatch = CrunchDispatch.new
+      dispatch.parse_argv ['--jobs']
+      dispatch.refresh_todo
+      dispatch.start_jobs
+      assert ok
+    end
+  end
+
   def assert_with_timeout timeout, message
     t = 0
     while (t += 0.1) < timeout
@@ -139,40 +171,59 @@ class CrunchDispatchTest < ActiveSupport::TestCase
       assert_equal 1, job[:log_throttle_lines_so_far]
 
       # first partial line segment is skipped and counted towards skipped lines
-      now = Time.now
-      line = "#{Time.now} stderr [...] this is first partial line segment [...]"
+      now = Time.now.strftime('%Y-%m-%d-%H:%M:%S')
+      line = "#{now} localhost 100 0 stderr [...] this is first partial line segment [...]"
       limit = dispatch.rate_limit(job, line)
       assert_equal true, limit
       assert_includes line, "Rate-limiting partial segments of long lines", line
       assert_equal 2, job[:log_throttle_lines_so_far]
 
       # next partial line segment within throttle interval is skipped but not counted towards skipped lines
-      line = "#{Time.now} stderr [...] second partial line segment within the interval [...]"
+      line = "#{now} localhost 100 0 stderr [...] second partial line segment within the interval [...]"
       limit = dispatch.rate_limit(job, line)
       assert_equal false, limit
       assert_equal 2, job[:log_throttle_lines_so_far]
 
       # next partial line after interval is counted towards skipped lines
       sleep(1)
-      line = "#{Time.now} stderr [...] third partial line segment after the interval [...]"
+      line = "#{now} localhost 100 0 stderr [...] third partial line segment after the interval [...]"
       limit = dispatch.rate_limit(job, line)
       assert_equal false, limit
       assert_equal 3, job[:log_throttle_lines_so_far]
 
-      now = Time.now
       # this is not a valid line segment
-      line = "#{now} stderr [...] does not end with [...] and is not a partial segment"
+      line = "#{now} localhost 100 0 stderr [...] does not end with [...] and is not a partial segment"
       limit = dispatch.rate_limit(job, line)
       assert_equal true, limit
-      assert_equal "#{now} stderr [...] does not end with [...] and is not a partial segment", line
+      assert_equal "#{now} localhost 100 0 stderr [...] does not end with [...] and is not a partial segment", line
       assert_equal 4, job[:log_throttle_lines_so_far]
 
       # this also is not a valid line segment
-      line = "#{now} stderr does not start correctly but ends with [...]"
+      line = "#{now} localhost 100 0 stderr does not start correctly but ends with [...]"
       limit = dispatch.rate_limit(job, line)
       assert_equal true, limit
-      assert_equal "#{now} stderr does not start correctly but ends with [...]", line
+      assert_equal "#{now} localhost 100 0 stderr does not start correctly but ends with [...]", line
       assert_equal 5, job[:log_throttle_lines_so_far]
     end
   end
+
+  test 'scancel orphaned job nodes' do
+    Rails.configuration.crunch_job_wrapper = :slurm_immediate
+    act_as_system_user do
+      dispatch = CrunchDispatch.new
+
+      squeue_resp = IO.popen("echo zzzzz-8i9sb-pshmckwoma9plh7\necho thisisnotvalidjobuuid\necho zzzzz-8i9sb-4cf0abc123e809j\necho zzzzz-dz642-o04e3r651turtdr\n")
+      scancel_resp = IO.popen("true")
+
+      IO.expects(:popen).
+        with(['squeue', '-a', '-h', '-o', '%j']).
+        returns(squeue_resp)
+
+      IO.expects(:popen).
+        with(dispatch.sudo_preface + ['scancel', '-n', 'zzzzz-8i9sb-4cf0abc123e809j']).
+        returns(scancel_resp)
+
+      dispatch.check_orphaned_slurm_jobs
+    end
+  end
 end