X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/aebf03862c0e5303cc4bb926585b8892ba7d0e4f..8ce476b7864f1a2d1f05cd0a770ae159eeb845eb:/services/api/test/functional/application_controller_test.rb diff --git a/services/api/test/functional/application_controller_test.rb b/services/api/test/functional/application_controller_test.rb index 2cfa054448..af7882141e 100644 --- a/services/api/test/functional/application_controller_test.rb +++ b/services/api/test/functional/application_controller_test.rb @@ -24,9 +24,6 @@ class ApplicationControllerTest < ActionController::TestCase token_time = token.split('+', 2).first.to_i assert_operator(token_time, :>=, @start_stamp, "error token too old") assert_operator(token_time, :<=, now_timestamp, "error token too new") - json_response['errors'].each do |err| - assert_match(/req-[a-z0-9]{20}/, err, "X-Request-Id value missing on error message") - end end def check_404(errmsg="Path not found") @@ -56,28 +53,6 @@ class ApplicationControllerTest < ActionController::TestCase check_error_token end - test "X-Request-Id header" do - authorize_with :spectator - get(:index) - assert_match /^req-[0-9a-zA-Z]{20}$/, response.headers['X-Request-Id'] - end - - # The response header is the one that gets logged, so this test also - # ensures we log the ID supplied in the request, if any. - test "X-Request-Id given by client" do - authorize_with :spectator - @request.headers['X-Request-Id'] = 'abcdefG' - get(:index) - assert_equal 'abcdefG', response.headers['X-Request-Id'] - end - - test "X-Request-Id given by client is ignored if too long" do - authorize_with :spectator - @request.headers['X-Request-Id'] = 'abcdefG' * 1000 - get(:index) - assert_match /^req-[0-9a-zA-Z]{20}$/, response.headers['X-Request-Id'] - end - ['foo', '', 'FALSE', 'TRUE', nil, [true], {a:true}, '"true"'].each do |bogus| test "bogus boolean parameter #{bogus.inspect} returns error" do @controller = Arvados::V1::GroupsController.new