X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/a7a482db3954fa6470be74f0e00f6e1e105e0b6c..15661585c028bedf752603b37cab07746209c3cc:/lib/controller/router/router.go diff --git a/lib/controller/router/router.go b/lib/controller/router/router.go index bc70963dab..e42d9a555b 100644 --- a/lib/controller/router/router.go +++ b/lib/controller/router/router.go @@ -7,9 +7,11 @@ package router import ( "context" "fmt" + "math" "net/http" "strings" + "git.arvados.org/arvados.git/lib/controller/api" "git.arvados.org/arvados.git/sdk/go/arvados" "git.arvados.org/arvados.git/sdk/go/auth" "git.arvados.org/arvados.git/sdk/go/ctxlog" @@ -19,137 +21,202 @@ import ( ) type router struct { - mux *mux.Router - fed arvados.API + mux *mux.Router + backend arvados.API + config Config } -func New(fed arvados.API) *router { +type Config struct { + // Return an error if request body exceeds this size. 0 means + // unlimited. + MaxRequestSize int + + // If wrapCalls is not nil, it is called once for each API + // method, and the returned method is used in its place. This + // can be used to install hooks before and after each API call + // and alter responses; see localdb.WrapCallsInTransaction for + // an example. + WrapCalls func(api.RoutableFunc) api.RoutableFunc +} + +// New returns a new router (which implements the http.Handler +// interface) that serves requests by calling Arvados API methods on +// the given backend. +func New(backend arvados.API, config Config) *router { rtr := &router{ - mux: mux.NewRouter(), - fed: fed, + mux: mux.NewRouter(), + backend: backend, + config: config, } rtr.addRoutes() return rtr } -type routableFunc func(ctx context.Context, opts interface{}) (interface{}, error) - func (rtr *router) addRoutes() { for _, route := range []struct { endpoint arvados.APIEndpoint defaultOpts func() interface{} - exec routableFunc + exec api.RoutableFunc }{ { arvados.EndpointConfigGet, func() interface{} { return &struct{}{} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.ConfigGet(ctx) + return rtr.backend.ConfigGet(ctx) + }, + }, + { + arvados.EndpointVocabularyGet, + func() interface{} { return &struct{}{} }, + func(ctx context.Context, opts interface{}) (interface{}, error) { + return rtr.backend.VocabularyGet(ctx) }, }, { arvados.EndpointLogin, func() interface{} { return &arvados.LoginOptions{} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.Login(ctx, *opts.(*arvados.LoginOptions)) + return rtr.backend.Login(ctx, *opts.(*arvados.LoginOptions)) + }, + }, + { + arvados.EndpointLogout, + func() interface{} { return &arvados.LogoutOptions{} }, + func(ctx context.Context, opts interface{}) (interface{}, error) { + return rtr.backend.Logout(ctx, *opts.(*arvados.LogoutOptions)) }, }, { arvados.EndpointCollectionCreate, func() interface{} { return &arvados.CreateOptions{} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.CollectionCreate(ctx, *opts.(*arvados.CreateOptions)) + return rtr.backend.CollectionCreate(ctx, *opts.(*arvados.CreateOptions)) }, }, { arvados.EndpointCollectionUpdate, func() interface{} { return &arvados.UpdateOptions{} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.CollectionUpdate(ctx, *opts.(*arvados.UpdateOptions)) + return rtr.backend.CollectionUpdate(ctx, *opts.(*arvados.UpdateOptions)) }, }, { arvados.EndpointCollectionGet, func() interface{} { return &arvados.GetOptions{} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.CollectionGet(ctx, *opts.(*arvados.GetOptions)) + return rtr.backend.CollectionGet(ctx, *opts.(*arvados.GetOptions)) }, }, { arvados.EndpointCollectionList, func() interface{} { return &arvados.ListOptions{Limit: -1} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.CollectionList(ctx, *opts.(*arvados.ListOptions)) + return rtr.backend.CollectionList(ctx, *opts.(*arvados.ListOptions)) }, }, { arvados.EndpointCollectionProvenance, func() interface{} { return &arvados.GetOptions{} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.CollectionProvenance(ctx, *opts.(*arvados.GetOptions)) + return rtr.backend.CollectionProvenance(ctx, *opts.(*arvados.GetOptions)) }, }, { arvados.EndpointCollectionUsedBy, func() interface{} { return &arvados.GetOptions{} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.CollectionUsedBy(ctx, *opts.(*arvados.GetOptions)) + return rtr.backend.CollectionUsedBy(ctx, *opts.(*arvados.GetOptions)) }, }, { arvados.EndpointCollectionDelete, func() interface{} { return &arvados.DeleteOptions{} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.CollectionDelete(ctx, *opts.(*arvados.DeleteOptions)) + return rtr.backend.CollectionDelete(ctx, *opts.(*arvados.DeleteOptions)) }, }, { arvados.EndpointCollectionTrash, func() interface{} { return &arvados.DeleteOptions{} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.CollectionTrash(ctx, *opts.(*arvados.DeleteOptions)) + return rtr.backend.CollectionTrash(ctx, *opts.(*arvados.DeleteOptions)) }, }, { arvados.EndpointCollectionUntrash, func() interface{} { return &arvados.UntrashOptions{} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.CollectionUntrash(ctx, *opts.(*arvados.UntrashOptions)) + return rtr.backend.CollectionUntrash(ctx, *opts.(*arvados.UntrashOptions)) }, }, { arvados.EndpointContainerCreate, func() interface{} { return &arvados.CreateOptions{} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.ContainerCreate(ctx, *opts.(*arvados.CreateOptions)) + return rtr.backend.ContainerCreate(ctx, *opts.(*arvados.CreateOptions)) }, }, { arvados.EndpointContainerUpdate, func() interface{} { return &arvados.UpdateOptions{} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.ContainerUpdate(ctx, *opts.(*arvados.UpdateOptions)) + return rtr.backend.ContainerUpdate(ctx, *opts.(*arvados.UpdateOptions)) }, }, { arvados.EndpointContainerGet, func() interface{} { return &arvados.GetOptions{} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.ContainerGet(ctx, *opts.(*arvados.GetOptions)) + return rtr.backend.ContainerGet(ctx, *opts.(*arvados.GetOptions)) }, }, { arvados.EndpointContainerList, func() interface{} { return &arvados.ListOptions{Limit: -1} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.ContainerList(ctx, *opts.(*arvados.ListOptions)) + return rtr.backend.ContainerList(ctx, *opts.(*arvados.ListOptions)) }, }, { arvados.EndpointContainerDelete, func() interface{} { return &arvados.DeleteOptions{} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.ContainerDelete(ctx, *opts.(*arvados.DeleteOptions)) + return rtr.backend.ContainerDelete(ctx, *opts.(*arvados.DeleteOptions)) + }, + }, + { + arvados.EndpointContainerRequestCreate, + func() interface{} { return &arvados.CreateOptions{} }, + func(ctx context.Context, opts interface{}) (interface{}, error) { + return rtr.backend.ContainerRequestCreate(ctx, *opts.(*arvados.CreateOptions)) + }, + }, + { + arvados.EndpointContainerRequestUpdate, + func() interface{} { return &arvados.UpdateOptions{} }, + func(ctx context.Context, opts interface{}) (interface{}, error) { + return rtr.backend.ContainerRequestUpdate(ctx, *opts.(*arvados.UpdateOptions)) + }, + }, + { + arvados.EndpointContainerRequestGet, + func() interface{} { return &arvados.GetOptions{} }, + func(ctx context.Context, opts interface{}) (interface{}, error) { + return rtr.backend.ContainerRequestGet(ctx, *opts.(*arvados.GetOptions)) + }, + }, + { + arvados.EndpointContainerRequestList, + func() interface{} { return &arvados.ListOptions{Limit: -1} }, + func(ctx context.Context, opts interface{}) (interface{}, error) { + return rtr.backend.ContainerRequestList(ctx, *opts.(*arvados.ListOptions)) + }, + }, + { + arvados.EndpointContainerRequestDelete, + func() interface{} { return &arvados.DeleteOptions{} }, + func(ctx context.Context, opts interface{}) (interface{}, error) { + return rtr.backend.ContainerRequestDelete(ctx, *opts.(*arvados.DeleteOptions)) }, }, { @@ -158,7 +225,7 @@ func (rtr *router) addRoutes() { return &arvados.GetOptions{Select: []string{"uuid", "state", "priority", "auth_uuid", "locked_by_uuid"}} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.ContainerLock(ctx, *opts.(*arvados.GetOptions)) + return rtr.backend.ContainerLock(ctx, *opts.(*arvados.GetOptions)) }, }, { @@ -167,143 +234,295 @@ func (rtr *router) addRoutes() { return &arvados.GetOptions{Select: []string{"uuid", "state", "priority", "auth_uuid", "locked_by_uuid"}} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.ContainerUnlock(ctx, *opts.(*arvados.GetOptions)) + return rtr.backend.ContainerUnlock(ctx, *opts.(*arvados.GetOptions)) + }, + }, + { + arvados.EndpointContainerSSH, + func() interface{} { return &arvados.ContainerSSHOptions{} }, + func(ctx context.Context, opts interface{}) (interface{}, error) { + return rtr.backend.ContainerSSH(ctx, *opts.(*arvados.ContainerSSHOptions)) + }, + }, + { + arvados.EndpointGroupCreate, + func() interface{} { return &arvados.CreateOptions{} }, + func(ctx context.Context, opts interface{}) (interface{}, error) { + return rtr.backend.GroupCreate(ctx, *opts.(*arvados.CreateOptions)) + }, + }, + { + arvados.EndpointGroupUpdate, + func() interface{} { return &arvados.UpdateOptions{} }, + func(ctx context.Context, opts interface{}) (interface{}, error) { + return rtr.backend.GroupUpdate(ctx, *opts.(*arvados.UpdateOptions)) + }, + }, + { + arvados.EndpointGroupList, + func() interface{} { return &arvados.ListOptions{Limit: -1} }, + func(ctx context.Context, opts interface{}) (interface{}, error) { + return rtr.backend.GroupList(ctx, *opts.(*arvados.ListOptions)) + }, + }, + { + arvados.EndpointGroupContents, + func() interface{} { return &arvados.GroupContentsOptions{Limit: -1} }, + func(ctx context.Context, opts interface{}) (interface{}, error) { + return rtr.backend.GroupContents(ctx, *opts.(*arvados.GroupContentsOptions)) + }, + }, + { + arvados.EndpointGroupContentsUUIDInPath, + func() interface{} { return &arvados.GroupContentsOptions{Limit: -1} }, + func(ctx context.Context, opts interface{}) (interface{}, error) { + return rtr.backend.GroupContents(ctx, *opts.(*arvados.GroupContentsOptions)) + }, + }, + { + arvados.EndpointGroupShared, + func() interface{} { return &arvados.ListOptions{Limit: -1} }, + func(ctx context.Context, opts interface{}) (interface{}, error) { + return rtr.backend.GroupShared(ctx, *opts.(*arvados.ListOptions)) + }, + }, + { + arvados.EndpointGroupGet, + func() interface{} { return &arvados.GetOptions{} }, + func(ctx context.Context, opts interface{}) (interface{}, error) { + return rtr.backend.GroupGet(ctx, *opts.(*arvados.GetOptions)) + }, + }, + { + arvados.EndpointGroupDelete, + func() interface{} { return &arvados.DeleteOptions{} }, + func(ctx context.Context, opts interface{}) (interface{}, error) { + return rtr.backend.GroupDelete(ctx, *opts.(*arvados.DeleteOptions)) + }, + }, + { + arvados.EndpointGroupTrash, + func() interface{} { return &arvados.DeleteOptions{} }, + func(ctx context.Context, opts interface{}) (interface{}, error) { + return rtr.backend.GroupTrash(ctx, *opts.(*arvados.DeleteOptions)) + }, + }, + { + arvados.EndpointGroupUntrash, + func() interface{} { return &arvados.UntrashOptions{} }, + func(ctx context.Context, opts interface{}) (interface{}, error) { + return rtr.backend.GroupUntrash(ctx, *opts.(*arvados.UntrashOptions)) + }, + }, + { + arvados.EndpointLinkCreate, + func() interface{} { return &arvados.CreateOptions{} }, + func(ctx context.Context, opts interface{}) (interface{}, error) { + return rtr.backend.LinkCreate(ctx, *opts.(*arvados.CreateOptions)) + }, + }, + { + arvados.EndpointLinkUpdate, + func() interface{} { return &arvados.UpdateOptions{} }, + func(ctx context.Context, opts interface{}) (interface{}, error) { + return rtr.backend.LinkUpdate(ctx, *opts.(*arvados.UpdateOptions)) + }, + }, + { + arvados.EndpointLinkList, + func() interface{} { return &arvados.ListOptions{Limit: -1} }, + func(ctx context.Context, opts interface{}) (interface{}, error) { + return rtr.backend.LinkList(ctx, *opts.(*arvados.ListOptions)) + }, + }, + { + arvados.EndpointLinkGet, + func() interface{} { return &arvados.GetOptions{} }, + func(ctx context.Context, opts interface{}) (interface{}, error) { + return rtr.backend.LinkGet(ctx, *opts.(*arvados.GetOptions)) + }, + }, + { + arvados.EndpointLinkDelete, + func() interface{} { return &arvados.DeleteOptions{} }, + func(ctx context.Context, opts interface{}) (interface{}, error) { + return rtr.backend.LinkDelete(ctx, *opts.(*arvados.DeleteOptions)) }, }, { arvados.EndpointSpecimenCreate, func() interface{} { return &arvados.CreateOptions{} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.SpecimenCreate(ctx, *opts.(*arvados.CreateOptions)) + return rtr.backend.SpecimenCreate(ctx, *opts.(*arvados.CreateOptions)) }, }, { arvados.EndpointSpecimenUpdate, func() interface{} { return &arvados.UpdateOptions{} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.SpecimenUpdate(ctx, *opts.(*arvados.UpdateOptions)) + return rtr.backend.SpecimenUpdate(ctx, *opts.(*arvados.UpdateOptions)) }, }, { arvados.EndpointSpecimenGet, func() interface{} { return &arvados.GetOptions{} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.SpecimenGet(ctx, *opts.(*arvados.GetOptions)) + return rtr.backend.SpecimenGet(ctx, *opts.(*arvados.GetOptions)) }, }, { arvados.EndpointSpecimenList, func() interface{} { return &arvados.ListOptions{Limit: -1} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.SpecimenList(ctx, *opts.(*arvados.ListOptions)) + return rtr.backend.SpecimenList(ctx, *opts.(*arvados.ListOptions)) }, }, { arvados.EndpointSpecimenDelete, func() interface{} { return &arvados.DeleteOptions{} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.SpecimenDelete(ctx, *opts.(*arvados.DeleteOptions)) + return rtr.backend.SpecimenDelete(ctx, *opts.(*arvados.DeleteOptions)) + }, + }, + { + arvados.EndpointAPIClientAuthorizationCreate, + func() interface{} { return &arvados.CreateOptions{} }, + func(ctx context.Context, opts interface{}) (interface{}, error) { + return rtr.backend.APIClientAuthorizationCreate(ctx, *opts.(*arvados.CreateOptions)) + }, + }, + { + arvados.EndpointAPIClientAuthorizationUpdate, + func() interface{} { return &arvados.UpdateOptions{} }, + func(ctx context.Context, opts interface{}) (interface{}, error) { + return rtr.backend.APIClientAuthorizationUpdate(ctx, *opts.(*arvados.UpdateOptions)) + }, + }, + { + arvados.EndpointAPIClientAuthorizationDelete, + func() interface{} { return &arvados.DeleteOptions{} }, + func(ctx context.Context, opts interface{}) (interface{}, error) { + return rtr.backend.APIClientAuthorizationDelete(ctx, *opts.(*arvados.DeleteOptions)) + }, + }, + { + arvados.EndpointAPIClientAuthorizationList, + func() interface{} { return &arvados.ListOptions{} }, + func(ctx context.Context, opts interface{}) (interface{}, error) { + return rtr.backend.APIClientAuthorizationList(ctx, *opts.(*arvados.ListOptions)) + }, + }, + { + arvados.EndpointAPIClientAuthorizationCurrent, + func() interface{} { return &arvados.GetOptions{} }, + func(ctx context.Context, opts interface{}) (interface{}, error) { + return rtr.backend.APIClientAuthorizationCurrent(ctx, *opts.(*arvados.GetOptions)) + }, + }, + { + arvados.EndpointAPIClientAuthorizationGet, + func() interface{} { return &arvados.GetOptions{} }, + func(ctx context.Context, opts interface{}) (interface{}, error) { + return rtr.backend.APIClientAuthorizationGet(ctx, *opts.(*arvados.GetOptions)) }, }, { arvados.EndpointUserCreate, func() interface{} { return &arvados.CreateOptions{} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.UserCreate(ctx, *opts.(*arvados.CreateOptions)) + return rtr.backend.UserCreate(ctx, *opts.(*arvados.CreateOptions)) }, }, { arvados.EndpointUserMerge, func() interface{} { return &arvados.UserMergeOptions{} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.UserMerge(ctx, *opts.(*arvados.UserMergeOptions)) + return rtr.backend.UserMerge(ctx, *opts.(*arvados.UserMergeOptions)) }, }, { arvados.EndpointUserActivate, func() interface{} { return &arvados.UserActivateOptions{} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.UserActivate(ctx, *opts.(*arvados.UserActivateOptions)) + return rtr.backend.UserActivate(ctx, *opts.(*arvados.UserActivateOptions)) }, }, { arvados.EndpointUserSetup, func() interface{} { return &arvados.UserSetupOptions{} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.UserSetup(ctx, *opts.(*arvados.UserSetupOptions)) + return rtr.backend.UserSetup(ctx, *opts.(*arvados.UserSetupOptions)) }, }, { arvados.EndpointUserUnsetup, func() interface{} { return &arvados.GetOptions{} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.UserUnsetup(ctx, *opts.(*arvados.GetOptions)) + return rtr.backend.UserUnsetup(ctx, *opts.(*arvados.GetOptions)) }, }, { arvados.EndpointUserGetCurrent, func() interface{} { return &arvados.GetOptions{} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.UserGetCurrent(ctx, *opts.(*arvados.GetOptions)) + return rtr.backend.UserGetCurrent(ctx, *opts.(*arvados.GetOptions)) }, }, { arvados.EndpointUserGetSystem, func() interface{} { return &arvados.GetOptions{} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.UserGetSystem(ctx, *opts.(*arvados.GetOptions)) + return rtr.backend.UserGetSystem(ctx, *opts.(*arvados.GetOptions)) }, }, { arvados.EndpointUserGet, func() interface{} { return &arvados.GetOptions{} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.UserGet(ctx, *opts.(*arvados.GetOptions)) - }, - }, - { - arvados.EndpointUserUpdateUUID, - func() interface{} { return &arvados.UpdateUUIDOptions{} }, - func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.UserUpdateUUID(ctx, *opts.(*arvados.UpdateUUIDOptions)) + return rtr.backend.UserGet(ctx, *opts.(*arvados.GetOptions)) }, }, { arvados.EndpointUserUpdate, func() interface{} { return &arvados.UpdateOptions{} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.UserUpdate(ctx, *opts.(*arvados.UpdateOptions)) + return rtr.backend.UserUpdate(ctx, *opts.(*arvados.UpdateOptions)) }, }, { arvados.EndpointUserList, func() interface{} { return &arvados.ListOptions{Limit: -1} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.UserList(ctx, *opts.(*arvados.ListOptions)) + return rtr.backend.UserList(ctx, *opts.(*arvados.ListOptions)) }, }, { arvados.EndpointUserBatchUpdate, func() interface{} { return &arvados.UserBatchUpdateOptions{} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.UserBatchUpdate(ctx, *opts.(*arvados.UserBatchUpdateOptions)) + return rtr.backend.UserBatchUpdate(ctx, *opts.(*arvados.UserBatchUpdateOptions)) }, }, { arvados.EndpointUserDelete, func() interface{} { return &arvados.DeleteOptions{} }, func(ctx context.Context, opts interface{}) (interface{}, error) { - return rtr.fed.UserDelete(ctx, *opts.(*arvados.DeleteOptions)) + return rtr.backend.UserDelete(ctx, *opts.(*arvados.DeleteOptions)) + }, + }, + { + arvados.EndpointUserAuthenticate, + func() interface{} { return &arvados.UserAuthenticateOptions{} }, + func(ctx context.Context, opts interface{}) (interface{}, error) { + return rtr.backend.UserAuthenticate(ctx, *opts.(*arvados.UserAuthenticateOptions)) }, }, } { - rtr.addRoute(route.endpoint, route.defaultOpts, route.exec) - if route.endpoint.Method == "PATCH" { - // Accept PUT as a synonym for PATCH. - endpointPUT := route.endpoint - endpointPUT.Method = "PUT" - rtr.addRoute(endpointPUT, route.defaultOpts, route.exec) + exec := route.exec + if rtr.config.WrapCalls != nil { + exec = rtr.config.WrapCalls(exec) } + rtr.addRoute(route.endpoint, route.defaultOpts, exec) } rtr.mux.NotFoundHandler = http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) { httpserver.Errors(w, []string{"API endpoint not found"}, http.StatusNotFound) @@ -313,8 +532,17 @@ func (rtr *router) addRoutes() { }) } -func (rtr *router) addRoute(endpoint arvados.APIEndpoint, defaultOpts func() interface{}, exec routableFunc) { - rtr.mux.Methods(endpoint.Method).Path("/" + endpoint.Path).HandlerFunc(func(w http.ResponseWriter, req *http.Request) { +var altMethod = map[string]string{ + "PATCH": "PUT", // Accept PUT as a synonym for PATCH + "GET": "HEAD", // Accept HEAD at any GET route +} + +func (rtr *router) addRoute(endpoint arvados.APIEndpoint, defaultOpts func() interface{}, exec api.RoutableFunc) { + methods := []string{endpoint.Method} + if alt, ok := altMethod[endpoint.Method]; ok { + methods = append(methods, alt) + } + rtr.mux.Methods(methods...).Path("/" + endpoint.Path).HandlerFunc(func(w http.ResponseWriter, req *http.Request) { logger := ctxlog.FromContext(req.Context()) params, err := rtr.loadRequestParams(req, endpoint.AttrsKey) if err != nil { @@ -360,6 +588,19 @@ func (rtr *router) addRoute(endpoint arvados.APIEndpoint, defaultOpts func() int "apiOptsType": fmt.Sprintf("%T", opts), "apiOpts": opts, }).Debug("exec") + // Extract the token UUIDs (or a placeholder for v1 tokens) + var tokenUUIDs []string + for _, t := range creds.Tokens { + if strings.HasPrefix(t, "v2/") { + tokenParts := strings.Split(t, "/") + if len(tokenParts) >= 3 { + tokenUUIDs = append(tokenUUIDs, tokenParts[1]) + } + } else { + tokenUUIDs = append(tokenUUIDs, "v1 token ending in "+t[len(t)-5:]) + } + } + httpserver.SetResponseLogFields(req.Context(), logrus.Fields{"tokenUUIDs": tokenUUIDs}) resp, err := exec(ctx, opts) if err != nil { logger.WithError(err).Debugf("returning error type %T", err) @@ -376,21 +617,41 @@ func (rtr *router) ServeHTTP(w http.ResponseWriter, r *http.Request) { default: w.Header().Set("Access-Control-Allow-Origin", "*") w.Header().Set("Access-Control-Allow-Methods", "GET, HEAD, PUT, POST, PATCH, DELETE") - w.Header().Set("Access-Control-Allow-Headers", "Authorization, Content-Type") + w.Header().Set("Access-Control-Allow-Headers", "Authorization, Content-Type, X-Http-Method-Override") w.Header().Set("Access-Control-Max-Age", "86486400") } if r.Method == "OPTIONS" { return } - r.ParseForm() - if m := r.FormValue("_method"); m != "" { - r2 := *r - r = &r2 - r.Method = m - } else if m = r.Header.Get("X-Http-Method-Override"); m != "" { - r2 := *r - r = &r2 - r.Method = m + if r.Body != nil { + // Wrap r.Body in a http.MaxBytesReader(), otherwise + // r.ParseForm() uses a default max request body size + // of 10 megabytes. Note we rely on the Nginx + // configuration to enforce the real max body size. + max := int64(rtr.config.MaxRequestSize) + if max < 1 { + max = math.MaxInt64 - 1 + } + r.Body = http.MaxBytesReader(w, r.Body, max) + } + if r.Method == "POST" { + err := r.ParseForm() + if err != nil { + if err.Error() == "http: request body too large" { + err = httpError(http.StatusRequestEntityTooLarge, err) + } + rtr.sendError(w, err) + return + } + if m := r.FormValue("_method"); m != "" { + r2 := *r + r = &r2 + r.Method = m + } else if m = r.Header.Get("X-Http-Method-Override"); m != "" { + r2 := *r + r = &r2 + r.Method = m + } } rtr.mux.ServeHTTP(w, r) }