X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/9df51438367e129d0d306801eb20215cc2a0fafc..fb4921f56d1c13a86add2e59205ec32fa1f6efe4:/services/api/test/unit/arvados_model_test.rb

diff --git a/services/api/test/unit/arvados_model_test.rb b/services/api/test/unit/arvados_model_test.rb
index 4d8e00398d..750b9334df 100644
--- a/services/api/test/unit/arvados_model_test.rb
+++ b/services/api/test/unit/arvados_model_test.rb
@@ -90,7 +90,7 @@ class ArvadosModelTest < ActiveSupport::TestCase
   test "store long string" do
     set_user_from_auth :active
     longstring = "a"
-    while longstring.length < 2**28
+    while longstring.length < 2**16
       longstring = longstring + longstring
     end
     g = Group.create! name: 'Has a long description', description: longstring
@@ -98,43 +98,26 @@ class ArvadosModelTest < ActiveSupport::TestCase
     assert_equal g.description, longstring
   end
 
-  test "unique uuid index exists on all models with the column uuid" do
-    tables = ActiveRecord::Base.connection.tables
-    tables.each do |table|
-      columns = ActiveRecord::Base.connection.columns(table)
+  [['uuid', {unique: true}],
+   ['owner_uuid', {}]].each do |the_column, requires|
+    test "unique index on all models with #{the_column}" do
+      checked = 0
+      ActiveRecord::Base.connection.tables.each do |table|
+        columns = ActiveRecord::Base.connection.columns(table)
 
-      uuid_column = columns.select do |column|
-        column.name == 'uuid'
-      end
-
-      if !uuid_column.empty?
-        indexes = ActiveRecord::Base.connection.indexes(table)
-        uuid_index = indexes.select do |index|
-          index.columns == ['uuid'] and index.unique == true
-        end
-
-        assert !uuid_index.empty?, "#{table} does not have unique uuid index"
-      end
-    end
-  end
-
-  test "owner uuid index exists on all models with the owner_uuid column" do
-    all_tables = ActiveRecord::Base.connection.tables
-
-    all_tables.each do |table|
-      columns = ActiveRecord::Base.connection.columns(table)
-
-      uuid_column = columns.select do |column|
-        column.name == 'owner_uuid'
-      end
+        next unless columns.collect(&:name).include? the_column
 
-      if !uuid_column.empty?
-        indexes = ActiveRecord::Base.connection.indexes(table)
-        owner_uuid_index = indexes.select do |index|
-          index.columns == ['owner_uuid']
+        indexes = ActiveRecord::Base.connection.indexes(table).reject do |index|
+          requires.map do |key, val|
+            index.send(key) == val
+          end.include? false
         end
-        assert !owner_uuid_index.empty?, "#{table} does not have owner_uuid index"
+        assert_includes indexes.collect(&:columns), [the_column], 'no index'
+        checked += 1
       end
+      # Sanity check: make sure we didn't just systematically miss everything.
+      assert_operator(10, :<, checked,
+                      "Only #{checked} tables have a #{the_column}?!")
     end
   end
 
@@ -146,6 +129,10 @@ class ArvadosModelTest < ActiveSupport::TestCase
       table_class = table.classify.constantize
       if table_class.respond_to?('searchable_columns')
         search_index_columns = table_class.searchable_columns('ilike')
+        # Disappointing, but text columns aren't indexed yet.
+        search_index_columns -= table_class.columns.select { |c|
+          c.type == :text or c.name == 'description'
+        }.collect(&:name)
 
         indexes = ActiveRecord::Base.connection.indexes(table)
         search_index_by_columns = indexes.select do |index|
@@ -158,4 +145,26 @@ class ArvadosModelTest < ActiveSupport::TestCase
       end
     end
   end
+
+  test "selectable_attributes includes database attributes" do
+    assert_includes(Job.selectable_attributes, "success")
+  end
+
+  test "selectable_attributes includes non-database attributes" do
+    assert_includes(Job.selectable_attributes, "node_uuids")
+  end
+
+  test "selectable_attributes includes common attributes in extensions" do
+    assert_includes(Job.selectable_attributes, "uuid")
+  end
+
+  test "selectable_attributes does not include unexposed attributes" do
+    refute_includes(Job.selectable_attributes, "nodes")
+  end
+
+  test "selectable_attributes on a non-default template" do
+    attr_a = Job.selectable_attributes(:common)
+    assert_includes(attr_a, "uuid")
+    refute_includes(attr_a, "success")
+  end
 end