X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/98d6a7c2db7b8be7050fe7394147df5c5ce392bb..da3f22835804cc1bafe7daf373867ef46cbb20e8:/sdk/go/auth/auth.go diff --git a/sdk/go/auth/auth.go b/sdk/go/auth/auth.go index 4a719e922d..ea492430e4 100644 --- a/sdk/go/auth/auth.go +++ b/sdk/go/auth/auth.go @@ -1,6 +1,11 @@ +// Copyright (C) The Arvados Authors. All rights reserved. +// +// SPDX-License-Identifier: Apache-2.0 + package auth import ( + "encoding/base64" "net/http" "net/url" "strings" @@ -20,18 +25,27 @@ func NewCredentialsFromHTTPRequest(r *http.Request) *Credentials { return c } +// EncodeTokenCookie accepts a token and returns a byte slice suitable +// for use as a cookie value, such that it will be decoded correctly +// by LoadTokensFromHTTPRequest. +var EncodeTokenCookie func([]byte) string = base64.URLEncoding.EncodeToString + +// DecodeTokenCookie accepts a cookie value and returns the encoded +// token. +var DecodeTokenCookie func(string) ([]byte, error) = base64.URLEncoding.DecodeString + // LoadTokensFromHttpRequest loads all tokens it can find in the // headers and query string of an http query. func (a *Credentials) LoadTokensFromHTTPRequest(r *http.Request) { // Load plain token from "Authorization: OAuth2 ..." header // (typically used by smart API clients) - if toks := strings.SplitN(r.Header.Get("Authorization"), " ", 2); len(toks) == 2 && toks[0] == "OAuth2" { + if toks := strings.SplitN(r.Header.Get("Authorization"), " ", 2); len(toks) == 2 && (toks[0] == "OAuth2" || toks[0] == "Bearer") { a.Tokens = append(a.Tokens, toks[1]) } // Load base64-encoded token from "Authorization: Basic ..." // header (typically used by git via credential helper) - if _, password, ok := BasicAuth(r); ok { + if _, password, ok := r.BasicAuth(); ok { a.Tokens = append(a.Tokens, password) } @@ -51,10 +65,24 @@ func (a *Credentials) LoadTokensFromHTTPRequest(r *http.Request) { a.Tokens = append(a.Tokens, val...) } + a.loadTokenFromCookie(r) + // TODO: Load token from Rails session cookie (if Rails site // secret is known) } +func (a *Credentials) loadTokenFromCookie(r *http.Request) { + cookie, err := r.Cookie("arvados_api_token") + if err != nil || len(cookie.Value) == 0 { + return + } + token, err := DecodeTokenCookie(cookie.Value) + if err != nil { + return + } + a.Tokens = append(a.Tokens, string(token)) +} + // TODO: LoadTokensFromHttpRequestBody(). We can't assume in // LoadTokensFromHttpRequest() that [or how] we should read and parse // the request body. This has to be requested explicitly by the