X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/9878a4d9e0b535a13a323dfb8776866b542ece1a..1ac0e3da5fbd477bd2acbf5bd8baa3c86f08194b:/apps/workbench/app/controllers/pipeline_instances_controller.rb diff --git a/apps/workbench/app/controllers/pipeline_instances_controller.rb b/apps/workbench/app/controllers/pipeline_instances_controller.rb index e84d0e4597..394bb7b889 100644 --- a/apps/workbench/app/controllers/pipeline_instances_controller.rb +++ b/apps/workbench/app/controllers/pipeline_instances_controller.rb @@ -2,13 +2,58 @@ class PipelineInstancesController < ApplicationController skip_before_filter :find_object_by_uuid, only: :compare before_filter :find_objects_by_uuid, only: :compare include PipelineInstancesHelper + include PipelineComponentsHelper def copy - @object = @object.dup + template = PipelineTemplate.find?(@object.pipeline_template_uuid) + + source = @object + @object = PipelineInstance.new + @object.pipeline_template_uuid = source.pipeline_template_uuid + + if params['components'] == 'use_latest' and template + @object.components = template.components.deep_dup + @object.components.each do |cname, component| + # Go through the script parameters of each component + # that are marked as user input and copy them over. + # Skip any components that are not present in the + # source instance (there's nothing to copy) + if source.components.include? cname + component[:script_parameters].each do |pname, val| + if val.is_a? Hash and val[:dataclass] + # this is user-inputtable, so check the value from the source pipeline + srcvalue = source.components[cname][:script_parameters][pname] + if not srcvalue.nil? + component[:script_parameters][pname] = srcvalue + end + end + end + end + end + else + @object.components = source.components.deep_dup + end + + if params['script'] == 'use_same' + # Go through each component and copy the script_version from each job. + @object.components.each do |cname, component| + if source.components.include? cname and source.components[cname][:job] + component[:script_version] = source.components[cname][:job][:script_version] + end + end + end + @object.components.each do |cname, component| component.delete :job end @object.state = 'New' + + # set owner_uuid to that of source, provided it is a project and wriable by current user + current_project = Group.find(source.owner_uuid) rescue nil + if (current_project && current_project.writable_by.andand.include?(current_user.uuid)) + @object.owner_uuid = source.owner_uuid + end + super end @@ -19,7 +64,10 @@ class PipelineInstancesController < ApplicationController if component[:script_parameters] component[:script_parameters].each do |param, value_info| if value_info.is_a? Hash - if resource_class_for_uuid(value_info[:value]) == Link + value_info_partitioned = value_info[:value].partition('/') if value_info[:value].andand.class.eql?(String) + value_info_value = value_info_partitioned ? value_info_partitioned[0] : value_info[:value] + value_info_class = resource_class_for_uuid value_info_value + if value_info_class == Link # Use the link target, not the link itself, as script # parameter; but keep the link info around as well. link = Link.find value_info[:value] @@ -31,6 +79,20 @@ class PipelineInstancesController < ApplicationController value_info[:link_uuid] = nil value_info[:link_name] = nil end + if value_info_class == Collection + # to ensure reproducibility, the script_parameter for a + # collection should be the portable_data_hash + # keep the collection name and uuid for human-readability + obj = Collection.find value_info_value + if value_info_partitioned + value_info[:value] = obj.portable_data_hash + value_info_partitioned[1] + value_info_partitioned[2] + value_info[:selection_name] = obj.name + value_info_partitioned[1] + value_info_partitioned[2] + else + value_info[:value] = obj.portable_data_hash + value_info[:selection_name] = obj.name + end + value_info[:selection_uuid] = obj.uuid + end end end end @@ -42,44 +104,67 @@ class PipelineInstancesController < ApplicationController def graph(pipelines) return nil, nil if params['tab_pane'] != "Graph" - count = {} provenance = {} pips = {} n = 1 + # When comparing more than one pipeline, "pips" stores bit fields that + # indicates which objects are part of which pipelines. + pipelines.each do |p| collections = [] + hashes = [] + jobs = [] + + p[:components].each do |k, v| + provenance["component_#{p[:uuid]}_#{k}"] = v + + collections << v[:output_uuid] if v[:output_uuid] + jobs << v[:job][:uuid] if v[:job] + end - p.components.each do |k, v| - j = v[:job] || next + jobs = jobs.compact.uniq + if jobs.any? + Job.where(uuid: jobs).each do |j| + job_uuid = j.uuid - # The graph is interested in whether the component is - # indicated as persistent, more than whether the job - # satisfying it (which could have been reused, or someone - # else's) is. - j[:output_is_persistent] = v[:output_is_persistent] + provenance[job_uuid] = j + pips[job_uuid] = 0 unless pips[job_uuid] != nil + pips[job_uuid] |= n - uuid = j[:uuid].intern - provenance[uuid] = j - pips[uuid] = 0 unless pips[uuid] != nil - pips[uuid] |= n + hashes << j[:output] if j[:output] + ProvenanceHelper::find_collections(j) do |hash, uuid| + collections << uuid if uuid + hashes << hash if hash + end - collections << j[:output] - ProvenanceHelper::find_collections(j[:script_parameters]).each do |k| - collections << k + if j[:script_version] + script_uuid = j[:script_version] + provenance[script_uuid] = {:uuid => script_uuid} + pips[script_uuid] = 0 unless pips[script_uuid] != nil + pips[script_uuid] |= n + end end + end - uuid = j[:script_version].intern - provenance[uuid] = {:uuid => uuid} - pips[uuid] = 0 unless pips[uuid] != nil - pips[uuid] |= n + hashes = hashes.compact.uniq + if hashes.any? + Collection.where(portable_data_hash: hashes).each do |c| + hash_uuid = c.portable_data_hash + provenance[hash_uuid] = c + pips[hash_uuid] = 0 unless pips[hash_uuid] != nil + pips[hash_uuid] |= n + end end - Collection.where(uuid: collections.compact).each do |c| - uuid = c.uuid.intern - provenance[uuid] = c - pips[uuid] = 0 unless pips[uuid] != nil - pips[uuid] |= n + collections = collections.compact.uniq + if collections.any? + Collection.where(uuid: collections).each do |c| + collection_uuid = c.uuid + provenance[collection_uuid] = c + pips[collection_uuid] = 0 unless pips[collection_uuid] != nil + pips[collection_uuid] |= n + end end n = n << 1 @@ -103,8 +188,10 @@ class PipelineInstancesController < ApplicationController :request => request, :all_script_parameters => true, :combine_jobs => :script_and_version, - :script_version_nodes => true, - :pips => pips } + :pips => pips, + :only_components => true, + :no_docker => true, + :no_log => true} end super @@ -192,11 +279,11 @@ class PipelineInstancesController < ApplicationController end def show_pane_list - panes = %w(Components Graph Advanced) + panes = %w(Components Log Graph Advanced) if @object and @object.state.in? ['New', 'Ready'] - panes = %w(Inputs) + panes + panes = %w(Inputs) + panes - %w(Log) end - if not @object.components.values.collect { |x| x[:job] }.compact.any? + if not @object.components.values.any? { |x| x[:job] rescue false } panes -= ['Graph'] end panes