X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/981c7264123f24a1873f2692a72f012ac43e726b..8b873a9b3b8865a4d451263e48b49122b9c32759:/apps/workbench/test/integration/jobs_test.rb diff --git a/apps/workbench/test/integration/jobs_test.rb b/apps/workbench/test/integration/jobs_test.rb index 9ab98a0519..7b510f2be9 100644 --- a/apps/workbench/test/integration/jobs_test.rb +++ b/apps/workbench/test/integration/jobs_test.rb @@ -1,9 +1,16 @@ +# Copyright (C) The Arvados Authors. All rights reserved. +# +# SPDX-License-Identifier: AGPL-3.0 + require 'fileutils' require 'tmpdir' require 'integration_helper' class JobsTest < ActionDispatch::IntegrationTest + setup do + need_javascript + end def fakepipe_with_log_data content = @@ -13,103 +20,66 @@ class JobsTest < ActionDispatch::IntegrationTest StringIO.new content, 'r' end - test "add job description" do - need_javascript - visit page_with_token("active", "/jobs") - - # go to job running the script "doesnotexist" - within first('tr', text: 'doesnotexist') do - find("a").click - end - - # edit job description - within('.arv-description-as-subtitle') do - find('.fa-pencil').click - find('.editable-input textarea').set('*Textile description for job* - "Go to dashboard":/') - find('.editable-submit').click - end - wait_for_ajax - - # Verify edited description - assert page.has_no_text? '*Textile description for job*' - assert page.has_text? 'Textile description for job' - assert page.has_link? 'Go to dashboard' - click_link 'Go to dashboard' - assert page.has_text? 'Active pipelines' - end - - test "view job log" do - need_javascript - job = api_fixture('jobs')['job_with_real_log'] - - IO.expects(:popen).returns(fakepipe_with_log_data) - - visit page_with_token("active", "/jobs/#{job['uuid']}") - assert page.has_text? job['script_version'] - - click_link 'Log' - wait_for_ajax - assert page.has_text? 'Started at' - assert page.has_text? 'Finished at' - assert page.has_text? 'log message 1' - assert page.has_text? 'log message 2' - assert page.has_text? 'log message 3' - assert page.has_no_text? 'Showing only 100 bytes of this log' - end - - test 'view partial job log' do - need_javascript - # This config will be restored during teardown by ../test_helper.rb: - Rails.configuration.log_viewer_max_bytes = 100 - - IO.expects(:popen).returns(fakepipe_with_log_data) - job = api_fixture('jobs')['job_with_real_log'] - - visit page_with_token("active", "/jobs/#{job['uuid']}") - assert page.has_text? job['script_version'] - - click_link 'Log' - wait_for_ajax - assert page.has_text? 'Showing only 100 bytes of this log' - end - [ - ['foobar', false, false], - ['job_with_latest_version', true, false], - ['job_with_latest_version', true, true], - ].each do |job_name, expect_options, use_latest| - test "Rerun #{job_name} job, expect options #{expect_options}, - and use latest version option #{use_latest}" do - need_javascript - - job = api_fixture('jobs')[job_name] - visit page_with_token 'active', '/jobs/'+job['uuid'] - - if expect_options - assert_text 'supplied_script_version: master' + ['active', true], + ['job_reader2', false], + ].each do |user, readable| + test "view job with components as #{user} user" do + Rails.configuration.Users.AnonymousUserToken = "" + job = api_fixture('jobs')['running_job_with_components'] + component1 = api_fixture('jobs')['completed_job_in_publicly_accessible_project'] + component2 = api_fixture('pipeline_instances')['running_pipeline_with_complete_job'] + component2_child1 = api_fixture('jobs')['previous_job_run'] + component2_child2 = api_fixture('jobs')['running'] + + visit page_with_token(user, "/jobs/#{job['uuid']}") + assert page.has_text? job['script_version'] + assert page.has_no_text? 'script_parameters' + + # The job_reader2 is allowed to read job, component2, and component2_child1, + # and component2_child2 only as a component of the pipeline component2 + if readable + assert page.has_link? 'component1' + assert page.has_link? 'component2' else - assert_text 'supplied_script_version: (none)' + assert page.has_no_link? 'component1' + assert page.has_link? 'component2' end - assert_triggers_dom_event 'shown.bs.modal' do - find('a,button', text: 'Re-run job...').click - end - within('.modal-dialog') do - assert_selector 'a,button', text: 'Cancel' - if use_latest - page.choose("job_script_version_#{job['supplied_script_version']}") + if readable + click_link('component1') + within('.panel-collapse') do + assert(has_text? component1['uuid']) + assert(has_text? component1['script_version']) + assert(has_text? 'script_parameters') end - click_on "Run now" + click_link('component1') end - # Re-running jobs doesn't currently work because the test API - # server has no git repository to check against. For now, check - # that the correct script version is mentioned in the - # Fiddlesticks error message. - if expect_options && use_latest - assert_text "Script version #{job['supplied_script_version']} does not resolve to a commit" - else - assert_text "Script version #{job['script_version']} does not resolve to a commit" + click_link('component2') + within('.panel-collapse') do + assert(has_text? component2['uuid']) + assert(has_text? component2['script_version']) + assert(has_no_text? 'script_parameters') + assert(has_link? 'previous') + assert(has_link? 'running') + + click_link('previous') + within('.panel-collapse') do + assert(has_text? component2_child1['uuid']) + assert(has_text? component2_child1['script_version']) + end + click_link('previous') + + click_link('running') + within('.panel-collapse') do + assert(has_text? component2_child2['uuid']) + if readable + assert(has_text? component2_child2['script_version']) + else + assert(has_no_text? component2_child2['script_version']) + end + end end end end