X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/97a2555a220d424b029d39b6b6e62f28bc3bc148..659a8c75c837ec30e2f9fb6f1a1859b625626c3e:/services/keepstore/logging_router.go diff --git a/services/keepstore/logging_router.go b/services/keepstore/logging_router.go index 6927019fd9..e30df87632 100644 --- a/services/keepstore/logging_router.go +++ b/services/keepstore/logging_router.go @@ -7,12 +7,14 @@ import ( "github.com/gorilla/mux" "log" "net/http" + "strings" ) type LoggingResponseWriter struct { Status int Length int http.ResponseWriter + ResponseBody string } func (loggingWriter *LoggingResponseWriter) WriteHeader(code int) { @@ -21,7 +23,10 @@ func (loggingWriter *LoggingResponseWriter) WriteHeader(code int) { } func (loggingWriter *LoggingResponseWriter) Write(data []byte) (int, error) { - loggingWriter.Length = len(data) + loggingWriter.Length += len(data) + if loggingWriter.Status >= 400 { + loggingWriter.ResponseBody += string(data) + } return loggingWriter.ResponseWriter.Write(data) } @@ -35,11 +40,12 @@ func MakeLoggingRESTRouter() *LoggingRESTRouter { } func (loggingRouter *LoggingRESTRouter) ServeHTTP(resp http.ResponseWriter, req *http.Request) { - loggingWriter := LoggingResponseWriter{200, 0, resp} + loggingWriter := LoggingResponseWriter{200, 0, resp, ""} loggingRouter.router.ServeHTTP(&loggingWriter, req) - if loggingWriter.Status == 200 { - log.Printf("[%s] %s %s %d %d", req.RemoteAddr, req.Method, req.URL.Path[1:], loggingWriter.Status, loggingWriter.Length) - } else { - log.Printf("[%s] %s %s %d", req.RemoteAddr, req.Method, req.URL.Path[1:], loggingWriter.Status) + statusText := "OK" + if loggingWriter.Status >= 400 { + statusText = strings.Replace(loggingWriter.ResponseBody, "\n", "", -1) } + log.Printf("[%s] %s %s %d %d \"%s\"", req.RemoteAddr, req.Method, req.URL.Path[1:], loggingWriter.Status, loggingWriter.Length, statusText) + }