X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/964ab3dd90ff1508efc0c77378cde2b3a4da1029..42c20b25e1325124b88e3b9b285544dc41122b56:/apps/workbench/test/controllers/users_controller_test.rb diff --git a/apps/workbench/test/controllers/users_controller_test.rb b/apps/workbench/test/controllers/users_controller_test.rb index 213a2a53c1..742fe6b13e 100644 --- a/apps/workbench/test/controllers/users_controller_test.rb +++ b/apps/workbench/test/controllers/users_controller_test.rb @@ -1,43 +1,112 @@ +# Copyright (C) The Arvados Authors. All rights reserved. +# +# SPDX-License-Identifier: AGPL-3.0 + require 'test_helper' class UsersControllerTest < ActionController::TestCase + test "valid token works in controller test" do - get :index, {}, session_for(:active) + get :index, params: {}, session: session_for(:active) assert_response :success end test "ignore previously valid token (for deleted user), don't crash" do - get :activity, {}, session_for(:valid_token_deleted_user) + get :activity, params: {}, session: session_for(:valid_token_deleted_user) assert_response :redirect - assert_match /^#{Rails.configuration.arvados_login_base}/, @response.redirect_url + assert_match /^#{Rails.configuration.Services.Controller.ExternalURL}\/login/, @response.redirect_url assert_nil assigns(:my_jobs) assert_nil assigns(:my_ssh_keys) end test "expired token redirects to api server login" do - get :show, { + get :show, params: { id: api_fixture('users')['active']['uuid'] - }, session_for(:expired_trustedclient) + }, session: session_for(:expired_trustedclient) assert_response :redirect - assert_match /^#{Rails.configuration.arvados_login_base}/, @response.redirect_url + assert_match /^#{Rails.configuration.Services.Controller.ExternalURL}\/login/, @response.redirect_url assert_nil assigns(:my_jobs) assert_nil assigns(:my_ssh_keys) end test "show welcome page if no token provided" do - get :index, {} + get :index, params: {} assert_response :redirect assert_match /\/users\/welcome/, @response.redirect_url end - test "show repositories with read, write, or manage permission" do - get :manage_account, {}, session_for(:active) + test "'log in as user' feature uses a v2 token" do + post :sudo, params: { + id: api_fixture('users')['active']['uuid'] + }, session: session_for('admin_trustedclient') + assert_response :redirect + assert_match /api_token=v2%2F/, @response.redirect_url + end + + test "request shell access" do + user = api_fixture('users')['spectator'] + + ActionMailer::Base.deliveries = [] + + post :request_shell_access, params: { + id: user['uuid'], + format: 'js' + }, session: session_for(:spectator) assert_response :success - repos = assigns(:my_repositories) - assert repos - assert_not_empty repos, "my_repositories should not be empty" - editables = repos.collect { |r| !!assigns(:repo_writable)[r.uuid] } - assert_includes editables, true, "should have a writable repository" - assert_includes editables, false, "should have a readonly repository" + + full_name = "#{user['first_name']} #{user['last_name']}" + expected = "Shell account request from #{full_name} (#{user['email']}, #{user['uuid']})" + found_email = 0 + ActionMailer::Base.deliveries.each do |email| + if email.subject.include?(expected) + found_email += 1 + break + end + end + assert_equal 1, found_email, "Expected 1 email after requesting shell access" + end + + [ + 'admin', + 'active', + ].each do |username| + test "access users page as #{username} and verify show button is available" do + admin_user = api_fixture('users','admin') + active_user = api_fixture('users','active') + get :index, params: {}, session: session_for(username) + if username == 'admin' + assert_match /Home<\/a>/, @response.body + assert_match /Home<\/a>/, @response.body + assert_match /href="\/users\/#{admin_user['uuid']}"><\/i> Show<\/a/, @response.body + assert_match /href="\/users\/#{active_user['uuid']}"><\/i> Show<\/a/, @response.body + assert_includes @response.body, admin_user['email'] + assert_includes @response.body, active_user['email'] + else + refute_match /Home<\/a>/, @response.body + refute_match /href="\/users\/#{admin_user['uuid']}"><\/i> Show<\/a/, @response.body + assert_match /href="\/users\/#{active_user['uuid']}"><\/i> Show<\/a/, @response.body + assert_includes @response.body, active_user['email'] + end + end + end + + [ + 'admin', + 'active', + ].each do |username| + test "access settings drop down menu as #{username}" do + admin_user = api_fixture('users','admin') + active_user = api_fixture('users','active') + get :show, params: { + id: api_fixture('users')[username]['uuid'] + }, session: session_for(username) + if username == 'admin' + assert_includes @response.body, admin_user['email'] + refute_empty css_select('[id="system-menu"]') + else + assert_includes @response.body, active_user['email'] + assert_empty css_select('[id="system-menu"]') + end + end end end