X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/95e2bdda5afc3ffc6afb2f08ea6d7cba8f8d62f1..6246cacc17e8b90519143e717b7241e527678be9:/services/keep-web/handler.go diff --git a/services/keep-web/handler.go b/services/keep-web/handler.go index 620ed9cfb4..42c37b8eeb 100644 --- a/services/keep-web/handler.go +++ b/services/keep-web/handler.go @@ -1,6 +1,7 @@ package main import ( + "encoding/json" "fmt" "html" "io" @@ -64,6 +65,16 @@ func parseCollectionIDFromURL(s string) string { func (h *handler) setup() { h.clientPool = arvadosclient.MakeClientPool() + keepclient.RefreshServiceDiscoveryOnSIGHUP() +} + +func (h *handler) serveStatus(w http.ResponseWriter, r *http.Request) { + status := struct { + cacheStats + }{ + cacheStats: h.Config.Cache.Stats(), + } + json.NewEncoder(w).Encode(status) } // ServeHTTP implements http.Handler. @@ -150,6 +161,9 @@ func (h *handler) ServeHTTP(wOrig http.ResponseWriter, r *http.Request) { // http://ID.collections.example/PATH... credentialsOK = true targetPath = pathParts + } else if r.URL.Path == "/status.json" { + h.serveStatus(w, r) + return } else if len(pathParts) >= 2 && strings.HasPrefix(pathParts[0], "c=") { // /c=ID/PATH... targetID = parseCollectionIDFromURL(pathParts[0][2:]) @@ -274,11 +288,17 @@ func (h *handler) ServeHTTP(wOrig http.ResponseWriter, r *http.Request) { targetPath = targetPath[1:] } + forceReload := false + if cc := r.Header.Get("Cache-Control"); strings.Contains(cc, "no-cache") || strings.Contains(cc, "must-revalidate") { + forceReload = true + } + + var collection map[string]interface{} tokenResult := make(map[string]int) - collection := make(map[string]interface{}) found := false for _, arv.ApiToken = range tokens { - err := arv.Get("collections", targetID, nil, &collection) + var err error + collection, err = h.Config.Cache.Get(arv, targetID, forceReload) if err == nil { // Success found = true @@ -335,12 +355,6 @@ func (h *handler) ServeHTTP(wOrig http.ResponseWriter, r *http.Request) { statusCode, statusText = http.StatusInternalServerError, err.Error() return } - if kc.Client != nil && kc.Client.Transport != nil { - // Workaround for https://dev.arvados.org/issues/9005 - if t, ok := kc.Client.Transport.(*http.Transport); ok { - defer t.CloseIdleConnections() - } - } rdr, err := kc.CollectionFileReader(collection, filename) if os.IsNotExist(err) { statusCode = http.StatusNotFound