X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/91c929939c115f1abac3c5a3d0497a09901559a6..07f18157a5f8b72c20c0050c4617564effe91bd2:/services/datamanager/summary/file.go

diff --git a/services/datamanager/summary/file.go b/services/datamanager/summary/file.go
index 18b3aec819..63c8adeb74 100644
--- a/services/datamanager/summary/file.go
+++ b/services/datamanager/summary/file.go
@@ -22,7 +22,7 @@ type serializedData struct {
 }
 
 var (
-	writeDataTo  string
+	WriteDataTo  string
 	readDataFrom string
 )
 
@@ -32,7 +32,7 @@ type DataFetcher func(arvLogger *logger.Logger,
 	keepServerInfo *keep.ReadServers)
 
 func init() {
-	flag.StringVar(&writeDataTo,
+	flag.StringVar(&WriteDataTo,
 		"write-data-to",
 		"",
 		"Write summary of data received to this file. Used for development only.")
@@ -51,14 +51,13 @@ func init() {
 // working with stale data.
 func MaybeWriteData(arvLogger *logger.Logger,
 	readCollections collection.ReadCollections,
-	keepServerInfo keep.ReadServers) bool {
-	if writeDataTo == "" {
-		return false
+	keepServerInfo keep.ReadServers) error {
+	if WriteDataTo == "" {
+		return nil
 	}
-	summaryFile, err := os.Create(writeDataTo)
+	summaryFile, err := os.Create(WriteDataTo)
 	if err != nil {
-		loggerutil.FatalWithMessage(arvLogger,
-			fmt.Sprintf("Failed to open %s: %v", writeDataTo, err))
+		return err
 	}
 	defer summaryFile.Close()
 
@@ -68,11 +67,10 @@ func MaybeWriteData(arvLogger *logger.Logger,
 		KeepServerInfo:  keepServerInfo}
 	err = enc.Encode(data)
 	if err != nil {
-		loggerutil.FatalWithMessage(arvLogger,
-			fmt.Sprintf("Failed to write summary data: %v", err))
+		return err
 	}
-	log.Printf("Wrote summary data to: %s", writeDataTo)
-	return true
+	log.Printf("Wrote summary data to: %s", WriteDataTo)
+	return nil
 }
 
 // ShouldReadData should not be used outside of development